- Nov 15, 2018
-
-
Anna Henningsen authored
This is part of the streams API contract, and aligns network sockets with other streams in this respect. PR-URL: https://github.com/nodejs/node/pull/24291 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Dan Corman authored
PR-URL: https://github.com/nodejs/node/pull/24179 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Dan Corman authored
PR-URL: https://github.com/nodejs/node/pull/24190 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/24322 Fixes: https://github.com/nodejs/node/issues/24320 Fixes: https://github.com/nodejs/node/issues/24362 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Gus Caplan authored
This reverts commit ac7450a0. This fully reverts the changes to util.inspect depth. It has caused breakage in logging to existing apps, and even something as simple as `console.log(require)` will cause >1m freezes. I've heard nothing but negative feedback (seriously not a single person has expressed anything positive about this change) and personally i find this change extremely annoying. PR-URL: https://github.com/nodejs/node/pull/24326 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com>
-
Osmond van Hemert authored
PR-URL: https://github.com/nodejs/node/pull/24257 Reviewed-By:
-
szabolcsit authored
While checking the arguments passed to http.Server, the case where the options argument was of wrong type was not handled. Now it throws an ERR_INVALID_ARG_TYPE error if the options argument is not a function, object, null, or undefined. PR-URL: https://github.com/nodejs/node/pull/24176 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Joyee Cheung authored
This patch refactors out a part of NativeModule.prototype.compile (in JS land) into a C++ NativeModule class, this enables a couple of possibilities: 1. By moving the code to the C++ land, we have more opportunity to specialize the compilation process of the native modules (e.g. compilation options, code cache) that is orthogonal to how user land modules are compiled 2. We can reuse the code to compile bootstrappers and context fixers and enable them to be compiled with the code cache later, since they are not loaded by NativeModule in the JS land their caching must be done in C++. 3. Since there is no need to pass the static data to JS for compilation anymore, this enables us to use (std::map<std::string, const char*>) in the generated node_code_cache.cc and node_javascript.cc later, and scope every actual access to the source of native modules to a std::map lookup instead of a lookup on a v8::Object in dictionary mode. This patch also refactor the code cache generator and tests a bit and trace the `withCodeCache` and `withoutCodeCache` in a Set instead of an Array, and makes sure that all the cachable builtins are tested. PR-URL: https://github.com/nodejs/node/pull/24221 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
João Reis authored
PR-URL: https://github.com/nodejs/node/pull/24348 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/24319 Reviewed-By:
-
- Nov 14, 2018
-
-
Anna Henningsen authored
Use the same property name as http2 does to indicate that the stream is in the state before the `ready` event is emitted. PR-URL: https://github.com/nodejs/node/pull/24067 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
cjihrig authored
This commit documents the NODE_TLS_REJECT_UNAUTHORIZED environment variable so that the world can know how potentially dangerous it is. PR-URL: https://github.com/nodejs/node/pull/24289 Fixes: https://github.com/nodejs/node/issues/24284 Reviewed-By:
-
Yang Guo authored
PR-URL: https://github.com/nodejs/node/pull/24274 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Peter Marshall <petermarshall@chromium.org> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Yang Guo authored
Original commit message: [profiler] introduce API to enable detailed source positions This allows Node.js to enable detailed source positions for optimized code early on, without having to pass a flag string. R=petermarshall@chromium.org Change-Id: Ie74ea41f600cf6e31acbe802116df4976ccf1c75 Reviewed-on: https://chromium-review.googlesource.com/c/1319757 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Rich Trott authored
Removed the "Managing Issues and Pull Requests" header as "managing" is unclear in this context. Useful information from the section was retained as an introductory paragraph for the "Issues and Pull Requests" section. Vague terminology (e.g., "full responsibility") was removed. PR-URL: https://github.com/nodejs/node/pull/24316 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/24357 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
James Herrington authored
PR-URL: https://github.com/nodejs/node/pull/24250 Reviewed-By:
-
Sam Roberts authored
Add an API to get the local certificate chosen during TLS handshake from the SSL context. Fix: https://github.com/nodejs/node/issues/24095 PR-URL: https://github.com/nodejs/node/pull/24261 Fixes: https://github.com/nodejs/node/issues/24095 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Steven Gabarro authored
PR-URL: https://github.com/nodejs/node/pull/24222 Reviewed-By:
-
Philipp Dunkel authored
Checked all call-sites to ensure that this code is truly unreachable. addressType is always checked before internalConnect is even called. PR-URL: https://github.com/nodejs/node/pull/24158 Reviewed-By:
-
Rich Trott authored
This reverts commit 420d8afe. PR-URL: https://github.com/nodejs/node/pull/24034 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
Florin-Daniel BÎLBÎE authored
PR-URL: https://github.com/nodejs/node/pull/24181 Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/24232 Reviewed-By:
-
Joyee Cheung authored
The usage of NODE_PUSH_VAL_TO_ARRAY_MAX and push_values_to_array_function has all been removed in favor of the new Array::New API that takes a C++ array. Remove the unused code. PR-URL: https://github.com/nodejs/node/pull/24264 Reviewed-By:
-
Joyee Cheung authored
Instead of calling into JS from C++ to push values into an array, use the new Array::New API that takes a pointer and a length directly. PR-URL: https://github.com/nodejs/node/pull/24264 Reviewed-By:
-
Joyee Cheung authored
Instead of calling into JS from C++ to push values into an array, use the new Array::New API that takes a pointer and a length directly. PR-URL: https://github.com/nodejs/node/pull/24264 Reviewed-By:
-
Joyee Cheung authored
Instead of calling into JS from C++ to push values into an array, use the new Array::New API that takes a pointer and a length directly. PR-URL: https://github.com/nodejs/node/pull/24264 Reviewed-By:
-
Joyee Cheung authored
Instead of calling into JS from C++ to push values into an array, use the new Array::New API that takes a pointer and a length directly. PR-URL: https://github.com/nodejs/node/pull/24264 Reviewed-By:
-
Joyee Cheung authored
Instead of calling into JS from C++ to push values into an array, use the new Array::New API that takes a pointer and a length directly. PR-URL: https://github.com/nodejs/node/pull/24264 Reviewed-By:
-
Joyee Cheung authored
Instead of calling into JS from C++ to push values into an array, use the new Array::New API that takes a pointer and a length directly. PR-URL: https://github.com/nodejs/node/pull/24264 Reviewed-By:
-
Joyee Cheung authored
Instead of calling into JS from C++ to push values into an array, use the new Array::New API that takes a pointer and a length directly. PR-URL: https://github.com/nodejs/node/pull/24264 Reviewed-By:
-
- Nov 13, 2018
-
-
Ben Noordhuis authored
Refs: https://blog.mozilla.org/security/2018/10/15/removing-old-versions-of-tls/ PR-URL: https://github.com/nodejs/node/pull/23814 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
Anna Henningsen authored
Add `HandleScope`s to the public C++ API for embedders/addons, since these methods create V8 handles that should not leak into the outer scopes. In particular, for some of the methods it was not clear from the function signatures that these functions previously needed to be invoked with a `HandleScope`. PR-URL: https://github.com/nodejs/node/pull/24285 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
razvanbh authored
PR-URL: https://github.com/nodejs/node/pull/24196 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Andrey Melikhov authored
Add a test case that verifies that calling _setSimultaneousAccepts() function twice does not trigger the deprecation warning twice. PR-URL: https://github.com/nodejs/node/pull/24180 Reviewed-By:
-
kiyomizumia authored
PR-URL: https://github.com/nodejs/node/pull/24187 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/24331 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
alyssaq authored
PR-URL: https://github.com/nodejs/node/pull/24161 Reviewed-By:
-
Rich Trott authored
Use a larger timeout on slower platforms so that the timeout doesn't fire before the error condition occurs. PR-URL: https://github.com/nodejs/node/pull/24296 Reviewed-By:
-
Sam Roberts authored
Adjust to work with self-signed certificates, and certificates that do not name "localhost" as their host name. Removed duplicate examples, they differed only by using `pfx`. Its not necessary to show every option, and we don't, and the example wouldn't work with most pfx anyway, since it didn't specify a password. PR-URL: https://github.com/nodejs/node/pull/24235 Reviewed-By:
-
