- Feb 16, 2017
-
-
Timothy Gu authored
Also remove executable bit from doc/api/url.md's mode. PR-URL: https://github.com/nodejs/node/pull/11330 Fixes: 4757ddcc "doc: add basic documentation for WHATWG URL API" Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/11330 Reviewed-By:
-
Rich Trott authored
When splitting PEM string into separate certs, use non-capturing regexp to avoid having to put the split string back with .map(). As a bonus, this splits the PEM into two certs, rather than 2 certs and a third crufty whitespace-only string. PR-URL: https://github.com/nodejs/node/pull/11367 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/11314 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/831 Fixes: https://github.com/nodejs/node/issues/947 Ref: https://github.com/nodejs/node/pull/9470 PR-URL: https://github.com/nodejs/node/pull/9744 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Rich Trott authored
Before: `Missing expected exception..` Afer: `Missing expected exception.` PR-URL: https://github.com/nodejs/node/pull/11254 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
James M Snell authored
Since slowToString only has one callsite, refactor to eliminate the use of call. PR-URL: https://github.com/nodejs/node/pull/11358 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
James M Snell authored
Avoid use of arguments in Buffer.prototype.toString() PR-URL: https://github.com/nodejs/node/pull/11358 Reviewed-By:
-
Rich Trott authored
Change the Stability Index on `assert` from Locked to Stable. PR-URL: https://github.com/nodejs/node/pull/11304 Ref: https://github.com/nodejs/node/issues/11200 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
cjihrig authored
env was unused since the ref'd commit Ref: https://github.com/nodejs/node/commit/e34ee1d2c978d46f8aee3fedda0f32bc2a04d7d4 PR-URL: https://github.com/nodejs/node/pull/11361 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
James M Snell authored
Replace use of arguments with `...args` ``` tls/tls-connect.js dur=5 concurrency=1 -9.43 % 0.172136744 tls/tls-connect.js dur=5 concurrency=10 29.05 % ** 0.001108115 ``` PR-URL: https://github.com/nodejs/node/pull/11357 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/11359 Reviewed-By:
-
Ben Noordhuis authored
Upstream V8 is removing SIMD support. Be proactive and follow suit. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4124 PR-URL: https://github.com/nodejs/node/pull/11346 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/11346 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/11264 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/11264 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/11264 Reviewed-By:
-
Akito Ito authored
* call Certificate function directly * check exception when sign option is undefined PR-URL: https://github.com/nodejs/node/pull/11280 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
- Feb 15, 2017
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/11206 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
John Barboza authored
PR-URL: https://github.com/nodejs/node/pull/10522 Fixes: https://github.com/nodejs/node/issues/1271 Reviewed-By:
-
Vse Mozhet Byt authored
* var -> const * string concatenation -> template strings PR-URL: https://github.com/nodejs/node/pull/11110 Reviewed-By:
-
Timothy Gu authored
Also factor out common parts in querystring and url. PR-URL: https://github.com/nodejs/node/pull/11161 Reviewed-By:
-
Ben Noordhuis authored
Seems to have been overlooked in commit dd93c53c ("Make node::DLOpen use uv_dlopen") from 2011. PR-URL: https://github.com/nodejs/node/pull/11322 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com>
-
cjihrig authored
When a non-exclusive dgram socket is bound from a cluster worker, it attempts to get a handle from the cluster module. This commit adds coverage for the case where the socket is closed while querying the cluster module for a handle. PR-URL: https://github.com/nodejs/node/pull/11292 Reviewed-By:
-
cjihrig authored
This commit sets the spawnSync() exit code to null when the child is killed via signal. This brings the behavior more in sync with spawn(). Fixes: https://github.com/nodejs/node/issues/11284 PR-URL: https://github.com/nodejs/node/pull/11288 Reviewed-By:
-
- Feb 14, 2017
-
-
Ben Noordhuis authored
Remove the explicit dependency on $(NODE_EXE), it always triggers a rebuild due to it being a .PHONY rule. Add-ons in test/addons/ have the same implicit dependency so it isn't completely without precedent. PR-URL: https://github.com/nodejs/node/pull/11311 Reviewed-By:
-
Franziska Hinkelmann authored
V8 moved the Embeder's guide to GitHub. PR-URL: https://github.com/nodejs/node/pull/11336 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/11098 Fixes: https://github.com/nodejs/node/issues/10760 Ref: https://github.com/whatwg/url/issues/26 Ref: https://github.com/whatwg/url/pull/199 Ref: https://github.com/w3c/web-platform-tests/pull/4531 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/11098 Fixes: https://github.com/nodejs/node/issues/10760 Ref: https://github.com/whatwg/url/issues/26 Ref: https://github.com/whatwg/url/pull/199 Ref: https://github.com/w3c/web-platform-tests/pull/4531 Reviewed-By:
-
cjihrig authored
This commit adds code coverage to _createSocketHandle(), which the cluster module uses to create dgram sockets. PR-URL: https://github.com/nodejs/node/pull/11291 Reviewed-By:
-
Rich Trott authored
* remove debugging code that prints child stdout * indexOf() -> includes() * improved messages on assertion failures PR-URL: https://github.com/nodejs/node/pull/11303 Reviewed-By:
-
David Benjamin authored
The return value of loadSession is ultimately ignored, so don't fill it in. This inches Node closer to 1.1.0 compatibility and is less code. Also remove a comment which appears to have long since become invalid. It dates to 048e0e77 when the SNI value was actually extracted from the session. This also fixes a segfault should d2i_SSL_SESSION fail to parse the input and return NULL. Add a test for this case based on test-tls-session-cache.js. PR-URL: https://github.com/nodejs/node/pull/10882 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
-
Sota Yamashita authored
PR-URL: https://github.com/nodejs/node/pull/11095 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Sebastian Van Sande authored
Adds two additional tests for mapDomain function in punycode.js. When an email address is given to the toASCII() and toUnicode() functions, only the parts before the '@' character should be encoded/decoded. PR-URL: https://github.com/nodejs/node/pull/11144 Reviewed-By:
-
James M Snell authored
Commit a1163582 added a deprecation warning when pbkdf2 was called without an explicit `digest` argument. This was because the default digest is `sha1`, which is not-recommended from a security point of view. This upgrades it to a runtime error when `digest` is undefined per the plan discussed in the original issue. Ref: https://github.com/nodejs/node/commit/a1163582c53dc6e00f3680084269600913b1cad2 PR-URL: https://github.com/nodejs/node/pull/11305 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/11234 Reviewed-By:
Nicu Micleușanu <micnic90@gmail.com>
-
Brian White authored
This commit fixes handling of empty pairs that occur before the end of the query string so that they are also ignored. Additionally, some optimizations have been made, including: * Avoid unnecessary code execution where possible * Use a lookup table when checking for hex characters * Avoid forced decoding when '+' characters are encountered and we are using the default decoder Fixes: https://github.com/nodejs/node/issues/10454 PR-URL: https://github.com/nodejs/node/pull/11234 Reviewed-By:
-
cjihrig authored
When a non-exclusive dgram socket is bound from a cluster worker, a handle is requested from the cluster module. This commit adds coverage for the case where an error occurs while retrieving the handle. PR-URL: https://github.com/nodejs/node/pull/11295 Reviewed-By:
-
Ben Noordhuis authored
The previous commit stores baked-in files with non-ASCII characters as UTF-16. Replace the \u2019 with a regular quote character so that the files they're in can be stored as one-byte strings. The UTF-16 functionality is still tested by the Unicode diagram in lib/timers.js. PR-URL: https://github.com/nodejs/node/pull/11129 Reviewed-By:
-
Ben Noordhuis authored
Detect it when source files in lib/ are not ASCII. Decode them as UTF-8 and store them as UTF-16 in the binary so they can be used as external string resources without non-ASCII characters getting mangled. Fixes: https://github.com/nodejs/node/issues/10673 PR-URL: https://github.com/nodejs/node/pull/11129 Reviewed-By:
-
