- Jan 17, 2019
-
-
Benjamin Coe authored
Original commit message 9365d09: [coverage] Rework continuation counter handling This changes a few bits about how continuation counters are handled. It introduces a new mechanism that allows removal of a continuation range after it has been created. If coverage is enabled, we run a first post-processing pass on the AST immediately after parsing, which removes problematic continuation ranges in two situations: 1. nested continuation counters - only the outermost stays alive. 2. trailing continuation counters within a block-like structure are removed if the containing structure itself has a continuation. R=bmeurer@chromium.org, jgruber@chromium.org, yangguo@chromium.org Bug: v8:8381, v8:8539 Change-Id: I6bcaea5060d8c481d7bae099f6db9f993cc30ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1339119 Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58443} Refs: v8/v8@9365d09 Original commit message aac2f8c: [coverage] Filter out singleton ranges that alias full ranges Block coverage is based on a system of ranges that can either have both a start and end position, or only a start position (so-called singleton ranges). When formatting coverage information, singletons are expanded until the end of the immediate full parent range. E.g. in: {0, 10} // Full range. {5, -1} // Singleton range. the singleton range is expanded to {5, 10}. Singletons are produced mostly for continuation counters that track whether we execute past a specific language construct. Unfortunately, continuation counters can turn up in spots that confuse our post-processing. For example: if (true) { ... block1 ... } else { ... block2 ... } If block1 produces a continuation counter, it could end up with the same start position as the else-branch counter. Since we merge identical blocks, the else-branch could incorrectly end up with an execution count of one. We need to avoid merging such cases. A full range should always take precedence over a singleton range; a singleton range should never expand to completely fill a full range. An additional post-processing pass ensures this. Bug: v8:8237 Change-Id: Idb3ec7b2feddc0585313810b9c8be1e9f4ec64bf Reviewed-on: https://chromium-review.googlesource.com/c/1273095 Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Jan 16, 2019
-
-
Anna Henningsen authored
Call `Environment::Exit()` rather than the process-wide `exit()` function, since JS exceptions generally only affect the current JS engine instance. PR-URL: https://github.com/nodejs/node/pull/25472 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Anna Henningsen authored
This makes sure that `StopTracingAgent()` is always called before tearing down the `tracing::Agent`, since previously its destructor might have tried to access the agent, which would be destroyed by the (earlier) `Dispose()` call. PR-URL: https://github.com/nodejs/node/pull/25472 Reviewed-By:
-
Rich Trott authored
* Use port 0 instead of `common.PORT`. * Use `//` for comments, capitalize comments, and add punctuation. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Rich Trott authored
* Use port 0 instead of `common.PORT`. * Reduce `concurrent` from 100 to 50 and `connections_per_client` from 5 to 3. This is to avoid side effects from other tests. Prior to this change, running this along with test-keep-alive would result in failures on my local setup, apparently due to network throttling. * Remove unnecessary `console.log()` and improve remaining `console.log()` to provide clearer information. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Rich Trott authored
* Reduce ROUNDS and ATTEMPTS_PER_ROUND by half to avoid spurious test failures as a result of side effects from other tests. (For my local setup, test-keep-alive seems to cause this test to fail with ETIMEDOUT and/or EADDRNOTAVAIL. It would seem to be a result of throttling. Reducing the pummel-iness of that test and this one seems to solve the problem.) * Apply capitalization and punctuation to comment. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Rich Trott authored
* Reduce concurrent and duration options by half so as to avoid interference with other tests. (Excessive TCP activity in this test resulted in throttling that caused subsequent tests to fail on my local setup.) * Use an OS-provided port rather than `common.PORT`. This possibly reduces side-effects on other tests (that may also be using `common.PORT`). * Add punctuation in comments. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Joyee Cheung authored
Remove the following properties: - `preserveSymlinks` - `preserveSymlinksMain` - `experimentalModules` - `userLoader` - `experimentalVMModules` - `experimentalREPLAwait` - `exposeInternals` We used to use them to pass cli option values from C++ into JS, but now the values are obtained in JS land using `require('internal/options').getOptionValue` instead so they are unused. Also removes `test/parallel/test-internal-modules-expose.js` which tests `--expose-internals`. We already have hundreds of tests depending on `--expose-internals`, they are more than enough to test the functionality of the flag. PR-URL: https://github.com/nodejs/node/pull/25463 Reviewed-By:Anna Henningsen <anna@addaleax.net> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Joyee Cheung authored
Instead of using `internalBinding('config')` which should be used to carry information about build-time options, directly pass the run-time cli options into bootstrap/loaders.js lexically via function arguments. PR-URL: https://github.com/nodejs/node/pull/25463 Reviewed-By: -
Joyee Cheung authored
So it's easier to tell the side effects of this setup. PR-URL: https://github.com/nodejs/node/pull/25443 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Eugene Ostroukhov authored
Many Inspector protocol clients rely on the top frame reported for the console messages. This test makes sure correct location is reported. PR-URL: https://github.com/nodejs/node/pull/25455 Reviewed-By:
-
Joyee Cheung authored
- Renamed `internal/process/write-coverage.js` to `internal/coverage-gen/with_instrumentation.js`, `internal/process/coverage.js` to `internal/coverage-gen/with_profiler.js` to distinguish the two better and added comments. - Separate the coverage directory setup and the connection setup, moves the directory setup into `node.js` and closer to the exit hooks because that's where it's used. - Moves the `process.reallyExit` overwrite and `process.on('exit')` hooks setup into bootstrap/node.js for clarity, and move them to a later stage of bootstrap since they do not have to happen that early. PR-URL: https://github.com/nodejs/node/pull/25398 Reviewed-By:Ben Coe <bencoe@gmail.com>
-
Minwoo Jung authored
For an unsupported OS, a call to os.cpus() throws an error within os.cpus() itself where it tries to get the length of it. This fixes the issue by adding fallback for undefined CPUs. Fixes: https://github.com/nodejs/node/issues/25483 PR-URL: https://github.com/nodejs/node/pull/25493 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/25481 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Joyee Cheung authored
The idea is to allow the C++ layer to run arbitrary scripts as the main script. This paves the way for - cctest of the execution of Node.js instances - Earlier handling of per-process CLI options that affect execution modes (those usually do not make sense for the embedders). - Targets like mkcodecache or mksnapshot. Also moves the handling of `_third_party_main.js` into C++. PR-URL: https://github.com/nodejs/node/pull/25474 Reviewed-By:
-
- Jan 15, 2019
-
-
Rich Trott authored
Improve known_issues/test-vm-timeout-escape-queuemicrotask to mitigate CI failures on ubuntu1604-arm64. Failures are due to a race condition. Use `common.platformTimeout()` to help, adjust timeout to make sure `queueMicrotasks()` has a chance to run, and improve error message. PR-URL: https://github.com/nodejs/node/pull/25503 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/25432 Reviewed-By:
-
Matteo Collina authored
https://github.com/nodejs/node/pull/17979 introduced a change in the doc that was not correct about _read always being called asynchronously. This does not hold true when it is in flowing mode. See: https://github.com/nodejs/node/pull/17979 Fixes: https://github.com/nodejs/node/issues/24919 PR-URL: https://github.com/nodejs/node/pull/25442 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me>
-
Sam Roberts authored
The API has existed forever and is used in our unit tests. It is supported for TLS1.3 as well as 1.2 and useful for troubleshooting, so it should be documented. PR-URL: https://github.com/nodejs/node/pull/25423 Reviewed-By:
-
Sam Roberts authored
- Use complete examples that can be pasted and run as-is - Move note about algorithm to the functions it applies to - Uncapitalize inconsistence use of "Class" - Use both EC and RSA keys in the examples - Note that hash and digest are two names for the same algorithms PR-URL: https://github.com/nodejs/node/pull/25452 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/25439 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
Joyee Cheung authored
Move `node::errno_string` into node_errors.h/cc and move it into the `node:errors` namespace to reduce the size of the header. It's not on any performance-critical code path so does not need to be inlined. PR-URL: https://github.com/nodejs/node/pull/25396 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/25394 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
-
Ankur Oberoi authored
PR-URL: https://github.com/nodejs/node/pull/25103 Reviewed-By:
-
- Jan 14, 2019
-
-
Richard Lau authored
https://github.com/nodejs/node/pull/17604 refactored the gyp files so that `-blibpath:` on AIX was only set if `node_shared=="true"`. Restore the setting for non-shared builds. Fixes: https://github.com/nodejs/node/issues/25444 PR-URL: https://github.com/nodejs/node/pull/25447 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Vse Mozhet Byt authored
This PR just places the `vm.SourceTextModule` class section after the `vm.Script` class section, restoring the alphabetical order. PR-URL: https://github.com/nodejs/node/pull/25374 Reviewed-By:
-
Sam Roberts authored
Remove: - use of tls global so tests can run in parallel - test counting in favour of common.mustCall() - limit of only one cipher suite per ephemeral key type tested The last change will allow adding TLS 1.3 cipher suites and testing 'ECDH' key info with them. PR-URL: https://github.com/nodejs/node/pull/25409 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/25410 Reviewed-By:
-
Sam Roberts authored
Check that the return value and callback error for tls.renegotiate() does not indicate a failure. Also, remove unnecessary line wrapping and indentation. PR-URL: https://github.com/nodejs/node/pull/25437 Reviewed-By:
-
Anto Aravinth authored
PR-URL: https://github.com/nodejs/node/pull/24054 Reviewed-By:
-
Vse Mozhet Byt authored
This PR places `Buffer.from(object...)` section before `Buffer.from(string...)` section and upper-cased bottom references before backtick-started ones. PR-URL: https://github.com/nodejs/node/pull/25477 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Philipp Renoth authored
- parameter `resource_object` is mandatory PR-URL: https://github.com/nodejs/node/pull/25366 Reviewed-By:
-
- Jan 13, 2019
-
-
Rich Trott authored
test-net-connect-econnrefused was recently fixed, but only in certain circumstances. This change allows it to succeed whether it is invoked with `node` or `tools/test.py`. Makes sure no Socket handles are left, which is what the test is trying to determine, rather than failing if there are no handles of any kind left. PR-URL: https://github.com/nodejs/node/pull/25438 Reviewed-By:
-
Anna Henningsen authored
Calling `process.exit()` calls the C `exit()` function, which in turn calls the destructors of static C++ objects. This can lead to race conditions with other concurrently executing threads; disposing of all Worker threads and then the V8 platform instance helps with this (although it might not be a full solution for all problems of this kind). Refs: https://github.com/nodejs/node/issues/24403 Refs: https://github.com/nodejs/node/issues/25007 PR-URL: https://github.com/nodejs/node/pull/25061 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Jan 12, 2019
-
-
Joyee Cheung authored
- Remove `NativeModule._source` - the compilation is now entirely done in C++ and `process.binding('natives')` is implemented directly in the binding loader so there is no need to store additional source code strings. - Instead of using an object as `NativeModule._cached` and insert into it after compilation of each native module, simply prebuild a JS map filled with all the native modules and infer the state of compilation through `mod.loading`/`mod.loaded`. - Rename `NativeModule.nonInternalExists` to `NativeModule.canBeRequiredByUsers` and precompute that property for all the native modules during bootstrap instead of branching in every require call during runtime. This also fixes the bug where `worker_threads` can be made available with `--expose-internals`. - Rename `NativeModule.requireForDeps` to `NativeModule.requireWithFallbackInDeps`. - Add a test to make sure we do not accidentally leak any module to the global namespace. PR-URL: https://github.com/nodejs/node/pull/25352 Reviewed-By: -
Matteo Collina authored
See: https://github.com/nodejs/node/issues/25373 See: https://github.com/nodejs/node/pull/18438 PR-URL: https://github.com/nodejs/node/pull/25413 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Rich Trott authored
test-inspector-port-cluster passes in workers. Remove skipIfWorker() from the test. PR-URL: https://github.com/nodejs/node/pull/25427 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
Now that `worker_threads` do not require a flag, the logic around loading `isMainThread` can be removed. PR-URL: https://github.com/nodejs/node/pull/25426 Reviewed-By:
-
cjihrig authored
Use of process.binding() has largely been replaced by internalBinding(). This commit updates the custom crypto check ESLint rule to check for both process.binding() and internalBinding(). Refs: https://github.com/nodejs/node/pull/24952 PR-URL: https://github.com/nodejs/node/pull/25395 Reviewed-By:
-
Vse Mozhet Byt authored
`vm` module API heavily reuses common code, but the doc seems to be a bit out of date: some options are listed in wrong places, some options and history entries are missed. Also some fragments need to be formalized and unified. PR-URL: https://github.com/nodejs/node/pull/25422 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
