Commits · b08ef63fcbfdb8f2ec0ca8ab550f000a582b38ed · github.com / v8-riscv / node

Jul 20, 2021

deps: V8: cherry-pick 53784bdb8f01 · b08ef63f

Michaël Zasso authored Jul 10, 2021

Original commit message:

    [liftoff] Handle constant memory indexes specially

    This adds detection for constant memory indexes which can statically be
    proven to be in-bounds (because the effective offset is within the
    minimum memory size). In these cases, we can skip the bounds check and
    the out-of-line code for the trap-handler.
    This often saves 1-2% of code size.

    R=ahaas@chromium.org

    Bug: v8:11802
    Change-Id: I0ee094e6f1f5d132af1d6a8a7c539a4af6c3cb5e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919827


    Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74825}

Refs: https://github.com/v8/v8/commit/53784bdb8f01a6ff76fc3acd3aec4d605cb3bfcc

PR-URL: https://github.com/nodejs/node/pull/39337


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

b08ef63f

deps: V8: cherry-pick 7ff6609a5385 · bc6a101e

Michaël Zasso authored Jun 20, 2021

Original commit message:

    Move DCHECK() in JSCallOrConstructNode ctor into a helper function.

    As is, the DCHECK() has a #if inside, and MSVC has trouble
    pre-processing that. Fix this by moving the conditional inside the
    DCHECK() into a separate helper function.

    Bug: v8:11760
    Change-Id: Ib4ae0fe263029bb426da378afa5b6881557ce652
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919421


Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74807}

Refs: https://github.com/v8/v8/commit/7ff6609a53854f859b12ba4b76606f397e074a70

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

bc6a101e

deps: V8: cherry-pick a5cea1bfc38c · 0479bcf5

Michaël Zasso authored Jun 20, 2021

Original commit message:

    Mark Node::opcode() and Operator::opcode() as constexpr.

    Without the explicit constexpr keyword, Clang seems to be able to treat
    these methods as constexpr, whereas MSVC will not.

    Bug: v8:11760
    Change-Id: I9f6492f38fb50dcaf7a4f09da0bd79c0da6a50eb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912916


Reviewed-by: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74791}

Refs: https://github.com/v8/v8/commit/a5cea1bfc38ceafc74f4baddd6ab94ea13757ef8

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

0479bcf5

deps: V8: cherry-pick 986299250e6d · c516f2c3

Richard Lau authored Jun 16, 2021

Original commit message:

    [wasm-simd] Skip tests which require Simd enabled

    These tests require Simd enabled which causes failures
    on machines without the support.

    They are already skipped on Mips: https://crrev.com/c/2841887

    Change-Id: I4b9a9bb3cb208a0e9aa12dc135393bc515ad766e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2927210


Reviewed-by: Zhi An Ng <zhin@chromium.org>
    Commit-Queue: Milad Fa <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/master@{#74891}

Refs: https://github.com/v8/v8/commit/986299250e6dd176c18055b46b4696bdb37d0bc2

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

c516f2c3

deps: V8: backport 71e8f8bb3c26 · 2090932b

Michaël Zasso authored Jun 16, 2021

Original commit message:

    [codegen] Move definition of GetRegisterParameter to inline header

    This fixes compilation of V8 in Node.js with Visual Studio 2019.
    Without this change, MSVC errors with C3779 (a function that returns
    'auto' cannot be used before it is defined) on the `static constexpr
    auto registers()` method.

    Bug: v8:11420
    Change-Id: Id545199e2cdc10c8560031fb5950ec1171e5d554
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964095


    Commit-Queue: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75173}

Refs: https://github.com/v8/v8/commit/71e8f8bb3c2654ba3b114f24d64a939b116f23e1

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

2090932b

deps: V8: cherry-pick 3d24b3ab8af0 · 03096f41

Michaël Zasso authored Jun 10, 2021

Original commit message:

    ARM64: VRegister::from_code expected to be constexpr

    GCC build fails trying to use a non constexpr function from a
    constexpr function.

    ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-register.h: In member function 'constexpr v8::internal::DoubleRegister v8::internal::wasm::LiftoffRegister::fp() const':
    ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-register.h:286:71: error: call to non-'constexpr' function 'static v8::internal::VRegister v8::internal::VRegister::from_code(int)'
      286 |     return DoubleRegister::from_code(code_ - kAfterMaxLiftoffGpRegCode);
          |                                                                       ^
    In file included from ../chromium-92.0.4503.0/v8/src/codegen/register-arch.h:16,
                     from ../chromium-92.0.4503.0/v8/src/deoptimizer/translation-array.h:8,
                     from ../chromium-92.0.4503.0/v8/src/objects/code.h:10,
                     from ../chromium-92.0.4503.0/v8/src/codegen/reloc-info.h:10,
                     from ../chromium-92.0.4503.0/v8/src/codegen/assembler.h:47,
                     from ../chromium-92.0.4503.0/v8/src/codegen/assembler-arch.h:8,
                     from ../chromium-92.0.4503.0/v8/src/codegen/turbo-assembler.h:12,
                     from ../chromium-92.0.4503.0/v8/src/codegen/macro-assembler.h:8,
                     from ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-assembler.h:13,
                     from ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-assembler.cc:5:
    ../chromium-92.0.4503.0/v8/src/codegen/arm64/register-arm64.h:416:20: note: 'static v8::internal::VRegister v8::internal::VRegister::from_code(int)' declared here
      416 |   static VRegister from_code(int code) {
          |                    ^~~~~~~~~

    Bug: chromium:819294
    Change-Id: Ia19ea90f3f666702d32c90e147af17dcda7e08a6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929805


Reviewed-by: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: José Dapena Paz <jdapena@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#74889}

Refs: https://github.com/v8/v8/commit/3d24b3ab8af0e822081f1b446a2439f13a086843

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

03096f41

deps: bump minimum ICU version to 69 · 630f9682

Michaël Zasso authored May 15, 2021

Refs: https://github.com/v8/v8/commit/edac49681843447cc483b164a26d00755870b08c

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

630f9682

test: ensure microtask queues are not automatically drained · 11d691ef

Jochen Eisinger authored Apr 29, 2021

V8 had a bug that in certain cases the default microtask queue was
drained, and this test relies on the behavior.

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

11d691ef

test: remove test-debug-args · dbc0312c

Michaël Zasso authored Apr 26, 2021

It it's not testing anything useful anymore.

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

dbc0312c

test: update trace events test expectations · db0ca87c

Michaël Zasso authored Apr 21, 2021

V8 9.2 doesn't emit the "V8.ScriptCompiler" event anymore.
Use "V8.GCScavenger" instead.

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

db0ca87c

src: stop using deprecated v8::ApiObject · 6ceefa79

Michaël Zasso authored Apr 26, 2021

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

6ceefa79

src: use non-deprecated Symbol::Description · 7d4c7502

Michaël Zasso authored Apr 14, 2021

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

7d4c7502

tools: update V8 gypfiles for 9.2 · b41c0c99

Michaël Zasso authored Apr 11, 2021

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

b41c0c99

deps: silence irrelevant V8 warning · 5190bead

Michaël Zasso authored May 01, 2021

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

5190bead

deps: silence irrelevant V8 warnings · 2bb1e6c7

Michaël Zasso authored Jan 30, 2021

PR-URL: https://github.com/nodejs/node/pull/37587


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

2bb1e6c7

deps: fix V8 build issue with inline methods · 323f285e

Jiawen Geng authored Oct 14, 2020

PR-URL: https://github.com/nodejs/node/pull/35415


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

323f285e

deps: make v8.h compatible with VS2015 · 7f51e2c4

Joao Reis authored Nov 01, 2019

There is a bug in the most recent version of VS2015 that affects v8.h
and therefore prevents compilation of addons.

Refs: https://stackoverflow.com/q/38378693

PR-URL: https://github.com/nodejs/node/pull/32116


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

7f51e2c4

deps: V8: forward declaration of `Rtl*FunctionTable` · 536896d7

Refael Ackermann authored May 22, 2019

This should be semver-patch since actual invocation is version
conditional.

PR-URL: https://github.com/nodejs/node/pull/32116


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

536896d7

deps: V8: patch register-arm64.h · e4a9da99

Refael Ackermann authored May 22, 2019

Fixes a compilation issue on some platforms

PR-URL: https://github.com/nodejs/node/pull/32116


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

e4a9da99

deps: V8: un-cherry-pick bd019bd · 92c18c95

Refael Ackermann authored Mar 27, 2019

Original commit message:

    [testrunner] delete ancient junit compatible format support

    Testrunner has ancient support for JUnit compatible XML output.

    This CL removes this old feature.

    R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
    CC=machenbach@chromium.org

    Bug: v8:8728
    Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1430065


Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Tamer Tas <tmrts@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59045}

Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c

PR-URL: https://github.com/nodejs/node/pull/32116


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

92c18c95

src: update NODE_MODULE_VERSION to 95 · d9dad36b

Michaël Zasso authored Jun 10, 2021

Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 9.2.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

d9dad36b

build: reset embedder string to "-node.0" · 9fc4c978

Michaël Zasso authored Jul 14, 2021

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

9fc4c978

deps: update V8 to 9.2.230.21 · 6cdd3102

Michaël Zasso authored Jul 14, 2021

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

6cdd3102

http2: on receiving rst_stream with cancel code add it to pending list · c0f10006

Akshay K authored Jul 16, 2021

PR-URL: https://github.com/nodejs/node/pull/39423
Fixes: https://github.com/nodejs/node/issues/38964


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

c0f10006

doc: update checkbox label in backporting guide · 3cbaabc4

Darshan Sen authored Jul 17, 2021



Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/39420


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

3cbaabc4

doc: remove _Addenda_ from headers · a73fcda5

Rich Trott authored Jul 17, 2021

PR-URL: https://github.com/nodejs/node/pull/39427


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

a73fcda5

Jul 19, 2021

build: update coverage Makefile target comments · 7959b6d8

Richard Lau authored Jul 12, 2021

Update the comments for the `coverage` Makefile target.
- Source files under `lib` are no longer instrumented since
https://github.com/nodejs/node/commit/d1dee495db1451e74f5364c8687148a53ff0b50d
- Fix the name of the related CI job.

PR-URL: https://github.com/nodejs/node/pull/39365
Refs: https://github.com/nodejs/node/pull/25157


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

7959b6d8

tools: added remark-frontmatter · 74e319f2

Ben Halverson authored Mar 08, 2021

remark-frontmatter allows the use of frontmatter metadata in markdown
files

PR-URL: https://github.com/nodejs/node/pull/38717


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>

74e319f2

inspector: mark as stable · 8f70a099

Gireesh Punathil authored Mar 14, 2021

The module has been there for a while,
evidence of usage in the field exists,
and we have good test coverage for it.
Last API change has been 18 months ago.

Refs: https://github.com/nodejs/node/issues/37440#issuecomment-785763306

PR-URL: https://github.com/nodejs/node/pull/37748


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8f70a099

doc: simplify .mailmap file · fcddd673

Rich Trott authored Jul 17, 2021

We have a few cases in .mailmap where multiple entries are used where
a single one would do. Consolidate those entries.

PR-URL: https://github.com/nodejs/node/pull/39418


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

fcddd673

meta: add .mailmap entry for new email for existing contributor · d0b440c6

Rich Trott authored Jul 18, 2021

PR-URL: https://github.com/nodejs/node/pull/39431


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

d0b440c6

doc: fix broken internal link in http.md · 42e85c70

Rich Trott authored Jul 17, 2021

PR-URL: https://github.com/nodejs/node/pull/39425


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

42e85c70

doc: remove outdated step in onboarding exercise · c154c6c5

Rich Trott authored Jul 16, 2021

The GitHub bot will leave a comment asking people to thumbs-up a fast
track request so there is no need to manually leave such a comment.

PR-URL: https://github.com/nodejs/node/pull/39410


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

c154c6c5

doc: revise strategic initiatives text · 057e31df

Rich Trott authored Jul 17, 2021

Now that it's in the core repo, so ome of the TSC-centric text doesn't
make as much sense as it did when it was in the TSC repo.

PR-URL: https://github.com/nodejs/node/pull/39417


Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

057e31df

doc: remove typo (extra ' character) · 1405a9ea

Nikita Rykov authored Jul 17, 2021

PR-URL: https://github.com/nodejs/node/pull/39414


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1405a9ea

doc: update mailmap and AUTHORS · ea93efdb

Rich Trott authored Jul 14, 2021

Based on their GitHub and other social media profiles as well as the
most recent of their authored commits, I suspect watson goes by "Thomas
Watson" and not the name currently listed in the .mailmap and AUTHORS
files. Update.

I'm doing this because it  helps avoid false positives in
`find-inactive-collaborators.mjs` which uses `git shortlog` which uses
`.mailmap`.

PR-URL: https://github.com/nodejs/node/pull/39393


Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

ea93efdb

build: run workflows when a PR is ready for review · c7d66d43

Michaël Zasso authored Jul 16, 2021

Add `ready_for_review` to the activity types for the pull_request event.

PR-URL: https://github.com/nodejs/node/pull/39405


Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

c7d66d43

doc: use a details tag for completed initiatves · 284dec77

Rich Trott authored Jul 17, 2021

The list of completed initiatives is longer and visually more noticeable
than the list of current initiatives, but the current initiatives are
likely the ones of interest. The completed initiatives list is only
going to get longer and longer, so let's put it in a details tag.

PR-URL: https://github.com/nodejs/node/pull/39416

Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

284dec77

stream: add stream.compose · e579acb8

Robert Nagy authored Jun 18, 2021

Refs: #32020

PR-URL: https://github.com/nodejs/node/pull/39029


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

e579acb8

test: add test for WebSocket secret verification in debugger · 36bcc292

Rich Trott authored Jul 11, 2021

PR-URL: https://github.com/nodejs/node/pull/39357
Refs: https://github.com/nodejs/node-inspect/pull/93


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

36bcc292