Unverified Commit bc6a101e authored by Michaël Zasso's avatar Michaël Zasso
Browse files

deps: V8: cherry-pick 7ff6609a5385

Original commit message:

    Move DCHECK() in JSCallOrConstructNode ctor into a helper function.

    As is, the DCHECK() has a #if inside, and MSVC has trouble
    pre-processing that. Fix this by moving the conditional inside the
    DCHECK() into a separate helper function.

    Bug: v8:11760
    Change-Id: Ib4ae0fe263029bb426da378afa5b6881557ce652
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919421


Reviewed-by: default avatarMaya Lekova <mslekova@chromium.org>
Reviewed-by: default avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74807}

Refs: https://github.com/v8/v8/commit/7ff6609a53854f859b12ba4b76606f397e074a70

PR-URL: https://github.com/nodejs/node/pull/38990


Reviewed-By: default avatarJiawen Geng <technicalcute@gmail.com>
Reviewed-By: default avatarMatteo Collina <matteo.collina@gmail.com>
Reviewed-By: default avatarRobert Nagy <ronagy@icloud.com>
Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
parent 0479bcf5
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment