- Mar 07, 2013
-
-
isaacs authored
Fix #4909
-
isaacs authored
Now that highWaterMark increases when there are large reads, this greatly reduces the number of calls necessary to _read(size), assuming that _read actually respects the size argument.
-
isaacs authored
It's not actually necessary for backwards compatibility, isn't used anywhere, and isn't even tested. Better to just remove it.
-
isaacs authored
If the consumer of a Readable is asking for N bytes, and N > hwm, then clearly we have set the hwm to low, and ought to increase it. Fix #4931
-
isaacs authored
Fix #4928
-
isaacs authored
-
isaacs authored
Extremely handy when tracking down a flood of recursive nextTick warnings.
-
Eugene Girshov authored
Fixed up slightly by @isaacs so as not to miss 'timeout' events in some cases.
-
- Mar 06, 2013
-
-
Ben Noordhuis authored
Don't emit the 'close' event with process.nextTick. Closing a handle is an operation that usually *but not always* completes on the next tick of the event loop, hence using process.nextTick is not reliable. Use a proper handle close callback and emit the 'close' event from inside the callback. Update tests that depend on the intricacies of the old model. Fixes #3459.
-
Ben Noordhuis authored
-
Ben Noordhuis authored
Prep work for a follow-up commit that adds support for close callbacks.
-
Ben Noordhuis authored
-
Pavel Lang authored
They were previously removed in a90bc785.
-
isaacs authored
This makes test-internet pass
-
Scott Blomquist authored
-
Timothy J Fontaine authored
-
isaacs authored
-
isaacs authored
This vastly reduces the overhead of decodeStrings:false streams, such as net and http.
-
isaacs authored
Just use stream.push(outputChunk) instead.
-
isaacs authored
1. Get rid of unnecessary 'finishing' flag 2. Dont check both ending and ended. Extraneous. Also: Remove extraneous 'finishing' flag, and don't check both 'ending' and 'ended', since checking just 'ending' is sufficient.
-
isaacs authored
This is helpful in tracking down bailouts and deopts in Stream classes, without triggering one from the string write in console.log
-
Nathan Rajlich authored
This properly sets the `_maxListeners` property, which fixes the max listener warning. Closes #4924.
-
Bert Belder authored
This is no longer necessary - the underlying issue was fixed in 01fa5ee2. This reverts commit d8790428.
-
Bert Belder authored
There are no unsafe structured exception handlers in object files generated from hand-crafted assembly - because they contain no exception handlers at all.
-
Paolo Fragomeni authored
-
- Mar 05, 2013
-
-
Ben Noordhuis authored
-
Ben Noordhuis authored
-
Ben Noordhuis authored
This commit fixes a bug where the cluster module fails to propagate EADDRINUSE errors. When a worker starts a (net, http) server, it requests the listen socket from its master who then creates and binds the socket. Now, OS X and Windows don't always signal EADDRINUSE from bind() but instead defer the error until a later syscall. libuv mimics this behaviour to provide consistent behaviour across platforms but that means the worker could end up with a socket that is not actually bound to the requested addresss. That's why the worker now checks if the socket is bound, raising EADDRINUSE if that's not the case. Fixes #2721.
-
Felix Böhm authored
`removeAllListeners` is removing events from end to start. Therefore it spends O(n^2) time, since `removeListener` is searching from start to end.
-
Trevor Norris authored
v8 likes when smaller functions have a single return point, and cleaned up the single non-strict check.
-
Trevor Norris authored
Strict checking for typeof types broke backwards compatibility for other libraries. This reverts those checks. The subclass test has been changed to ensure all operations can be performed on the inherited EE before instantiation. Including the ability to set event names with numbers.
-
Ben Noordhuis authored
Fixes #4913.
-
Bert Belder authored
-
- Mar 04, 2013
-
-
isaacs authored
When a readable listener is added, call read(0) so that data will flow in, up to the high water mark. Otherwise, it's somewhat confusing that you have to listen for readable, and ALSO call read() (when it will certainly return null) just to get some data out of the stream. See: #4720
-
Xidorn Quan authored
A typo in the variable name makes it throw a ReferenceError instead of the expected "Unknown type" error when dns.resolve() is passed a bad record type argument. Fixes the following exception: ReferenceError: type is not defined at Object.exports.resolve (dns.js:189:40) at /Users/bnoordhuis/src/master/test/simple/test-c-ares.js:48:9 <snip> -
Rod Vagg authored
-
Rod Vagg authored
-
isaacs authored
Fix #4133, bringing the cluster worker API more in line with the child process API.
-
isaacs authored
Calling end(data) calls write(data). Doing this after end should raise a 'write after end' error. However, because end() calls were previously ignored on already ended streams, this error was confusingly suppressed, even though the data never is written, and cannot get to the other side. This is a re-hash of 5222d19a, but without assuming that the data passed to end() is valid, and thus breaking a bunch of tests.
-
Aaron Cannon authored
-