- Jul 31, 2018
-
-
shisama authored
To increase test coverage for fs/promises, add tests for methods chown(), filehandle.chown() and lchown(). PR-URL: https://github.com/nodejs/node/pull/20574 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
- Jul 30, 2018
-
-
Michaël Zasso authored
Refs: https://github.com/nodejs/node/pull/21079#discussion_r194251183 PR-URL: https://github.com/nodejs/node/pull/21982 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
- Jul 29, 2018
-
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/21967 PR-URL: https://github.com/nodejs/node/pull/21968 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Ujjwal Sharma authored
Use a UTF-8 encoded string for naming interfaces in unix, instead of using Latin-1, as had been done on windows previously. PR-URL: https://github.com/nodejs/node/pull/21926 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Ujjwal Sharma authored
Use v8::NewStringType::kInternalized instead of v8::NewStringType::kNormal in different calls to v8::String::NewFromUtf8 in node.h and node.cc wherever it makes sense, to save the GC some work which would largely be redundant. PR-URL: https://github.com/nodejs/node/pull/21926 Reviewed-By:
-
Ujjwal Sharma authored
Remove all calls to deprecated v8 functions (here: String::NewFromUtf8) inside the code (src directory only). PR-URL: https://github.com/nodejs/node/pull/21926 Reviewed-By:
-
Ujjwal Sharma authored
Previously running ./configure with only the Xcode Command Line Tools installed would give: xcrun: error: unable to lookup item 'PlatformPath' from command line tools installation xcrun: error: unable to lookup item 'PlatformPath' in SDK '/' Co-authored-by:
Ben Noordhuis <info@bnoordhuis.nl> Fixes: https://github.com/nodejs/node/issues/12531 PR-URL: https://github.com/nodejs/node/pull/21520 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Ujjwal Sharma authored
Update cpplint.py to check for inline headers when the corresponding header is already included. PR-URL: https://github.com/nodejs/node/pull/21521 Reviewed-By:
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/21592 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
James Ide authored
The `Http2Session#request()` method internally listens to the "connect" event if the session has not yet established a connection so that the actual request can be sent after the connection has been established. This commit removes the event listener after it runs and carries out the request and is no longer needed. In practice this shouldn't affect the behavior of the session object since the "connect" event fires only once anyway, but removing the listener releases its references. The rest of this class subscribes to the "connect" event with `once` instead of `on` as well. Tested by adding a new test that ensures `Http2Session#request()` is called before the connection is established, indicated by a "connect" listener that is run. The test also ensures all "connect" listeners are removed after the connection is established. PR-URL: https://github.com/nodejs/node/pull/21916 Reviewed-By:
-
- Jul 28, 2018
-
-
Yuta Hiroto authored
PR-URL: https://github.com/nodejs/node/pull/21817 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Sam Ruby authored
This is the last use of the remark *module*. tools/remark-cli and tools/remark-preset-lint-node remain. PR-URL: https://github.com/nodejs/node/pull/21978 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
cjihrig authored
This commit makes all previously private APIs available via getters, setters, and wrapper functions. PR-URL: https://github.com/nodejs/node/pull/21923 Reviewed-By:
Wyatt Preul <wpreul@gmail.com> Reviewed-By:
-
cjihrig authored
_createSocketHandle() is used internally by the cluster module. This commit makes it internal only API. PR-URL: https://github.com/nodejs/node/pull/21923 Reviewed-By:
-
cjihrig authored
dgram sockets have a fair number of exposed private properties. This commit hides them all behind a single symbol property. PR-URL: https://github.com/nodejs/node/pull/21923 Reviewed-By:
-
cjihrig authored
These methods are private APIs of dgram sockets, but do not need to be exposed via the Socket prototype. PR-URL: https://github.com/nodejs/node/pull/21923 Reviewed-By:
-
Michael Dawson authored
PR-URL: https://github.com/nodejs/node/pull/21898 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
Jon Moss authored
Use available `ReqWrap` descendant to make call to libuv -- avoid doing call with the `ReqWrap`'s request member and then calling `Dispatched()` afterwards. PR-URL: https://github.com/nodejs/node/pull/21980 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
cclauss authored
__xrange()__ was removed in Python 3 in favor of __range()__. This PR ensures similar functionality on both Python 2 and Python 3. Discovered via https://travis-ci.com/nodejs/node/builds/79706150 (https://github.com/nodejs/node/pull/21942). PR-URL: https://github.com/nodejs/node/pull/21945 Reviewed-By:
-
Benjamin Gruenbaum authored
ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER was missing from the docs - add it there based on the wording Anna used in the her PR. PR-URL: https://github.com/nodejs/node/pull/21947 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Brian White authored
Fixes: https://github.com/nodejs/node/issues/21963 PR-URL: https://github.com/nodejs/node/pull/21964 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure values without prototype will still be inspected properly and do not cause errors. It restores the original information if possible. Besides that it fixes an issue with boxed symbols: extra keys were not visualized so far. PR-URL: https://github.com/nodejs/node/pull/21869 Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com>
-
- Jul 27, 2018
-
-
Joyee Cheung authored
- Use camel case names for memory retainers inherited from AsyncWrap instead of their provider names (which are all in upper case) - Assign class names to wraps so that they appear in the heap snapshot as nodes with class names as node names. Previously some nodes are named with reference names, which are supposed to be edge names instead. PR-URL: https://github.com/nodejs/node/pull/21939 Reviewed-By:
-
João Reis authored
This makes compiling v8_base much faster on Windows. Sharding is disabled because the header would have to be precompiled for each shard but is only once. The library is much smaller, so sharding is unnecessary. This is enabled by default, but disabled for CI and releases. PR-URL: https://github.com/nodejs/node/pull/21772 Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
Joyee Cheung authored
This patch makes it possible to generate the code cache for the builtins directly from the original script object (instead of compiling a new one) and after the script has been run (via `NativeModule.require`). Before this patch only the top level functions (the wrapped ones) are included in the cache, after this patch the inner functions in those modules will be included as well. Also blacklists modules from dependencies like V8 and node-inspect since we cannot guarantee that they are suitable to be executed directly. PR-URL: https://github.com/nodejs/node/pull/21567 Refs: https://github.com/nodejs/node/issues/21563 Reviewed-By:
-
Vitor Bruno de Oliveira Barth authored
PR-URL: https://github.com/nodejs/node/pull/21990 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Jon Moss authored
- Updates `test/README.md` with new suites - Fixes some outdated `IGNORED_SUITES` listings - Allows for `test/known_issues` suite to be run by default PR-URL: https://github.com/nodejs/node/pull/21910 Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
-
conectado authored
Removes the setTimeout since if the test were to fail it would time out due to the tools/test.py wrapper PR-URL: https://github.com/nodejs/node/pull/21969 Reviewed-By:
-
Rich Trott authored
The LICENSE file has a few entries for things that no longer ship with the code base. They are installed via npm instead. Remove them from the license file. Running the license builder on a fresh checkout will result in errors until this change lands, since the necessary information is not in the source tree until the `npm install` happens. PR-URL: https://github.com/nodejs/node/pull/21979 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
-
- Jul 26, 2018
-
-
Vse Mozhet Byt authored
Refs: https://github.com/nodejs/node/pull/21938#discussion_r204257281 and discussion below the comment. PR-URL: https://github.com/nodejs/node/pull/21977 Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
-
Anna Henningsen authored
The timeout is unnecessary and the suspected cause of the following failure (even though I could not reproduce it locally): 11:53:54 not ok 197 parallel/test-pipe-stream 11:53:54 --- 11:53:54 duration_ms: 6.253 11:53:54 severity: fail 11:53:54 exitcode: 1 11:53:54 stack: |- 11:53:54 assert.js:338 11:53:54 throw err; 11:53:54 ^ 11:53:54 11:53:54 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value: 11:53:54 11:53:54 assert.ok(have_ping) 11:53:54 11:53:54 at check (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:14:12) 11:53:54 at Server.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-pipe-stream.js:61:5) 11:53:54 at Server.emit (events.js:182:13) 11:53:54 at emitCloseNT (net.js:1668:8) 11:53:54 at process._tickCallback (internal/process/next_tick.js:63:19) (From https://ci.nodejs.org/job/node-test-binary-arm/2235/RUN_SUBSET=5,label=pi3-docker/console.) PR-URL: https://github.com/nodejs/node/pull/21837 Reviewed-By: -
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/21903 PR-URL: https://github.com/nodejs/node/pull/21924 Reviewed-By:
-
Gabriel Charette authored
Precursor to removing deprecated APIs on the v8 side @ https://chromium-review.googlesource.com/c/v8/v8/+/1045310 PR-URL: https://github.com/nodejs/node/pull/21079 Reviewed-By:
Yang Guo <yangguo@chromium.org>
-
cjihrig authored
This commit updates the following postmortem metadata constant: - v8dbg_context_idx_closure - Renamed: v8dbg_context_idx_scope_info - V8 commit: https://github.com/v8/v8/commit/39496a95c53934ecb80d083003b4dd11056c9f20#diff-f3f182b0510ba2ee39ae87e421ff110b Fixes: https://github.com/nodejs/node-v8/issues/59 PR-URL: https://github.com/nodejs/node/pull/21079 Reviewed-By:
-
Ingvar Stepanyan authored
As per Node.js docs, vm.Script instance is not bound to any context. However, this test was expecting otherwise and depended on implementation details which are going to change. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1013581 PR-URL: https://github.com/nodejs/node/pull/21079 Reviewed-By:
-
Matheus Marchini authored
Original commit message: [postmortem] add JS_ERROR_TYPE and context embedder index * JS_ERROR_TYPE is required for postmortem tools to inspect JSError objects (see https://github.com/nodejs/llnode/pull/215 for a usage example) * The context embedder index is required for postmortem tools to access embedder data stored in the context (see https://github.com/nodejs/llnode/pull/204 for a usage example) R=bmeurer@google.com, yangguo@google.com Change-Id: Ib7c7eb44f6ad327fc71a1d45f510c49377db7a25 Reviewed-on: https://chromium-review.googlesource.com/1138493 Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54475} Refs: https://github.com/v8/v8/commit/804a693eb4ac2fed160c683d16444a53b5 PR-URL: https://github.com/nodejs/node/pull/21855 Reviewed-By:
-
James M Snell authored
Original commit message: Reland "[builtins] Add %IsTraceCategoryEnabled and %Trace builtins" This is a reland of 8d4572a Original change's description: > [builtins] Add %IsTraceCategoryEnabled and %Trace builtins > > Adds the builtin Trace and IsTraceCategoryEnabled functions > exposed via extra bindings. These are intended to use by > embedders to allow basic trace event support from JavaScript. > > ```js > isTraceCategoryEnabled('v8.some-category') > > trace('e'.charCodeAt(0), 'v8.some-category', > 'Foo', 0, { abc: 'xyz'}) > ``` > > Bug: v8:7851 > Change-Id: I7bfb9bb059efdf87d92a56a0aae326650730c250 > Reviewed-on: chromium-review.googlesource.com/1103294 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by:Fadi Meawad <fmeawad@chromium.org> > Reviewed-by:
Camillo Bruni <cbruni@chromium.org> > Reviewed-by:
-
Michaël Zasso authored
Original commit message: [promise] Implement Swallowed Rejection Hook. This extends the current Promise Rejection Hook with two new events kPromiseRejectAfterResolved kPromiseResolveAfterResolved which are used to detect (and signal) misuse of the Promise constructor. Specifically the common bug like new Promise((res, rej) => { res(1); throw new Error("something") }); where the error is silently swallowed by the Promise constructor without the user ever noticing can be caught via this hook. Doc: https://goo.gl/2stLUY Bug: v8:7919 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I890a7e766cdd1be88db94844fb744f72823dba33 Reviewed-on: https://chromium-review.googlesource.com/1126099 Reviewed-by:Maya Lekova <mslekova@chromium.org> Reviewed-by:
Benedikt Meurer <benedikt.meurer@gmail.com>
-
Michaël Zasso authored
Original commit message: [turbofan] Remove optimization of default Promise capability functions. The JSCallReducer could in theory inline the default resolve and reject functions passed to the executor in the Promise constructor. But that inlining is almost never triggered because we don't have SFI based feedback in the CallIC. Also the use of the Promise constructor is discouraged, so we shouldn't really need to squeeze the last bit of performance out of this even in the future. Getting rid of this optimization will make significantly easier to implement the Swallowed Rejection Hook, as there's less churn on the TurboFan side then. Bug: v8:7919 Change-Id: If0c54f1c6c7ce95686cd74232be6b8693ac688c9 Reviewed-on: https://chromium-review.googlesource.com/1125926 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54210} Refs: https://github.com/v8/v8/commit/2075910f3d070159bebd80e128dd09fdd87be56e PR-URL: https://github.com/nodejs/node/pull/21838 Refs: https://github.com/nodejs/promises-debugging/issues/8 Reviewed-By:
-
Anna Henningsen authored
Original commit message: [api] Switch from `SetBuildEmbedderGraphCallback` to `AddBuildEmbedderGraphCallback` `SetBuildEmbedderGraphCallback`, unlike `SetWrapperClassInfoProvider`, assumes a monolithic embedder that can provide all necessary information. That is not the case for e.g. Node.js, which can e.g. provide multiple Node.js instances per V8 Isolate, as well as native addons that may allocate resources on their own. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib53dfde82416dd69934b08623e27d674a483ac2d Reviewed-on: https://chromium-review.googlesource.com/1082441 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
