Unverified Commit 72807807 authored by Michaël Zasso's avatar Michaël Zasso
Browse files

deps: cherry-pick 2075910 from upstream V8

Original commit message:

    [turbofan] Remove optimization of default Promise capability functions.

    The JSCallReducer could in theory inline the default resolve and reject
    functions passed to the executor in the Promise constructor. But that
    inlining is almost never triggered because we don't have SFI based feedback
    in the CallIC. Also the use of the Promise constructor is discouraged,
    so we shouldn't really need to squeeze the last bit of performance out
    of this even in the future.

    Getting rid of this optimization will make significantly easier to
    implement the Swallowed Rejection Hook, as there's less churn on the
    TurboFan side then.

    Bug: v8:7919
    Change-Id: If0c54f1c6c7ce95686cd74232be6b8693ac688c9
    Reviewed-on: https://chromium-review.googlesource.com/1125926


    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: default avatarJaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54210}

Refs: https://github.com/v8/v8/commit/2075910f3d070159bebd80e128dd09fdd87be56e

PR-URL: https://github.com/nodejs/node/pull/21838
Refs: https://github.com/nodejs/promises-debugging/issues/8


Reviewed-By: default avatarGus Caplan <me@gus.host>
Reviewed-By: default avatarBenjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
Reviewed-By: default avatarYang Guo <yangguo@chromium.org>
Reviewed-By: default avatarBenedikt Meurer <benedikt.meurer@gmail.com>
parent aa58e2e7
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment