- Jul 21, 2021
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39430 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
npm team authored
PR-URL: https://github.com/nodejs/node/pull/39403 Reviewed-By:
Ruy Adorno <ruyadorno@github.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Jul 20, 2021
-
-
Rich Trott authored
The internal link checker was missing some broken links because it was being too restrictive about the characters it accepted as part of a link hash. Accept anything that isn't a terminating quotation mark. Refs: https://github.com/nodejs/node/pull/39426 Refs: https://github.com/nodejs/node/pull/39425 PR-URL: https://github.com/nodejs/node/pull/39429 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Michaël Zasso authored
gtest_prod.h is not enough to build V8's cctests. PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Michaël Zasso authored
Original commit message: [mips][wasm][liftoff] Fix compile failed Port 2b77ca200c56667c68895e49c96c10ff77834f09 Bug: v8:11809 Change-Id: Idbbbc10d1339d6c8463686b6e701fb601a217cab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931557 Reviewed-by:Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#74934} Refs: https://github.com/v8/v8/commit/5c76da8ddcf89297a8dc2606b68da97d7a5329cb PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [riscv64] Fix build failed Port 2b77ca200c56667c68895e49c96c10ff77834f09 Change-Id: Ie953a1d54f5529423ae35d1b1cd3ca25e8101c6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931577 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Reviewed-by:Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/master@{#74937} Refs: https://github.com/v8/v8/commit/359d44df4cdd9cdb40cb683b47c2bea6bb7609f6 PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: PPC/s390: [wasm][liftoff] Always zero-extend 32 bit offsets Port 2b77ca200c56667c68895e49c96c10ff77834f09 Original Commit Message: The upper 32 bits of the 64 bit offset register are not guaranteed to be cleared, so a zero-extension is needed. We already do the zero-extension in the case of explicit bounds checking, but this should also be done if the trap handler is enabled. R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ife3ae4f93b85fe1b2c76fe4b98fa408b5b51ed71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929661 Reviewed-by:Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74886} Refs: https://github.com/v8/v8/commit/3805a698f7b6803dd6ee002cfdda71296c71b30b PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [wasm][arm64] Always zero-extend 32 bit offsets, for realz We've already been zero-extending 32-bit offset registers since https://chromium-review.googlesource.com/c/v8/v8/+/2917612, but that patch only covered the case where offset_imm == 0. When there is a non-zero offset, we need the same fix. Bug: chromium:1224882,v8:11809 Change-Id: I1908f735929798f411346807fc4f3c79d8e04362 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2998582 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75500} Refs: https://github.com/v8/v8/commit/56fe020eec0c35e9816590114b1d80836a504156 Fixes: https://github.com/nodejs/node/issues/39327 PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [wasm][liftoff] Always zero-extend 32 bit offsets The upper 32 bits of the 64 bit offset register are not guaranteed to be cleared, so a zero-extension is needed. We already do the zero-extension in the case of explicit bounds checking, but this should also be done if the trap handler is enabled. R=clemensb@chromium.org CC=jkummerow@chromium.org Bug: v8:11809 Change-Id: I21e2535c701041d11fa06c176fa683d82db0a3f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2917612 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: -
Michaël Zasso authored
Original commit message: [liftoff] Handle constant memory indexes specially This adds detection for constant memory indexes which can statically be proven to be in-bounds (because the effective offset is within the minimum memory size). In these cases, we can skip the bounds check and the out-of-line code for the trap-handler. This often saves 1-2% of code size. R=ahaas@chromium.org Bug: v8:11802 Change-Id: I0ee094e6f1f5d132af1d6a8a7c539a4af6c3cb5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919827 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74825} Refs: https://github.com/v8/v8/commit/53784bdb8f01a6ff76fc3acd3aec4d605cb3bfcc PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: Move DCHECK() in JSCallOrConstructNode ctor into a helper function. As is, the DCHECK() has a #if inside, and MSVC has trouble pre-processing that. Fix this by moving the conditional inside the DCHECK() into a separate helper function. Bug: v8:11760 Change-Id: Ib4ae0fe263029bb426da378afa5b6881557ce652 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919421 Reviewed-by:Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Michaël Zasso authored
Original commit message: Mark Node::opcode() and Operator::opcode() as constexpr. Without the explicit constexpr keyword, Clang seems to be able to treat these methods as constexpr, whereas MSVC will not. Bug: v8:11760 Change-Id: I9f6492f38fb50dcaf7a4f09da0bd79c0da6a50eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912916 Reviewed-by: -
Richard Lau authored
Original commit message: [wasm-simd] Skip tests which require Simd enabled These tests require Simd enabled which causes failures on machines without the support. They are already skipped on Mips: https://crrev.com/c/2841887 Change-Id: I4b9a9bb3cb208a0e9aa12dc135393bc515ad766e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2927210 Reviewed-by:Zhi An Ng <zhin@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74891} Refs: https://github.com/v8/v8/commit/986299250e6dd176c18055b46b4696bdb37d0bc2 PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [codegen] Move definition of GetRegisterParameter to inline header This fixes compilation of V8 in Node.js with Visual Studio 2019. Without this change, MSVC errors with C3779 (a function that returns 'auto' cannot be used before it is defined) on the `static constexpr auto registers()` method. Bug: v8:11420 Change-Id: Id545199e2cdc10c8560031fb5950ec1171e5d554 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964095 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#75173} Refs: https://github.com/v8/v8/commit/71e8f8bb3c2654ba3b114f24d64a939b116f23e1 PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
Original commit message: ARM64: VRegister::from_code expected to be constexpr GCC build fails trying to use a non constexpr function from a constexpr function. ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-register.h: In member function 'constexpr v8::internal::DoubleRegister v8::internal::wasm::LiftoffRegister::fp() const': ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-register.h:286:71: error: call to non-'constexpr' function 'static v8::internal::VRegister v8::internal::VRegister::from_code(int)' 286 | return DoubleRegister::from_code(code_ - kAfterMaxLiftoffGpRegCode); | ^ In file included from ../chromium-92.0.4503.0/v8/src/codegen/register-arch.h:16, from ../chromium-92.0.4503.0/v8/src/deoptimizer/translation-array.h:8, from ../chromium-92.0.4503.0/v8/src/objects/code.h:10, from ../chromium-92.0.4503.0/v8/src/codegen/reloc-info.h:10, from ../chromium-92.0.4503.0/v8/src/codegen/assembler.h:47, from ../chromium-92.0.4503.0/v8/src/codegen/assembler-arch.h:8, from ../chromium-92.0.4503.0/v8/src/codegen/turbo-assembler.h:12, from ../chromium-92.0.4503.0/v8/src/codegen/macro-assembler.h:8, from ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-assembler.h:13, from ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-assembler.cc:5: ../chromium-92.0.4503.0/v8/src/codegen/arm64/register-arm64.h:416:20: note: 'static v8::internal::VRegister v8::internal::VRegister::from_code(int)' declared here 416 | static VRegister from_code(int code) { | ^~~~~~~~~ Bug: chromium:819294 Change-Id: Ia19ea90f3f666702d32c90e147af17dcda7e08a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929805 Reviewed-by: -
Michaël Zasso authored
Refs: https://github.com/v8/v8/commit/edac49681843447cc483b164a26d00755870b08c PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Jochen Eisinger authored
V8 had a bug that in certain cases the default microtask queue was drained, and this test relies on the behavior. PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
It it's not testing anything useful anymore. PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
V8 9.2 doesn't emit the "V8.ScriptCompiler" event anymore. Use "V8.GCScavenger" instead. PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37587 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Jiawen Geng authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Joao Reis authored
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Refael Ackermann authored
This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 9.2. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
-
Akshay K authored
PR-URL: https://github.com/nodejs/node/pull/39423 Fixes: https://github.com/nodejs/node/issues/38964 Reviewed-By:
-
Darshan Sen authored
Signed-off-by:
Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/39420 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39427 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
- Jul 19, 2021
-
-
Richard Lau authored
Update the comments for the `coverage` Makefile target. - Source files under `lib` are no longer instrumented since https://github.com/nodejs/node/commit/d1dee495db1451e74f5364c8687148a53ff0b50d - Fix the name of the related CI job. PR-URL: https://github.com/nodejs/node/pull/39365 Refs: https://github.com/nodejs/node/pull/25157 Reviewed-By:
-
Ben Halverson authored
remark-frontmatter allows the use of frontmatter metadata in markdown files PR-URL: https://github.com/nodejs/node/pull/38717 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is>
-
Gireesh Punathil authored
The module has been there for a while, evidence of usage in the field exists, and we have good test coverage for it. Last API change has been 18 months ago. Refs: https://github.com/nodejs/node/issues/37440#issuecomment-785763306 PR-URL: https://github.com/nodejs/node/pull/37748 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
We have a few cases in .mailmap where multiple entries are used where a single one would do. Consolidate those entries. PR-URL: https://github.com/nodejs/node/pull/39418 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39431 Reviewed-By:
-
