- Apr 03, 2020
-
-
Rich Trott authored
Somehow thought I did this in 8905be2c but clearly did not. PR-URL: https://github.com/nodejs/node/pull/32588 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Anna Henningsen authored
This adds a regression test for terminating a Worker inside which another Worker is running. PR-URL: https://github.com/nodejs/node/pull/32623 Refs: https://github.com/nodejs/node/pull/32531 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Anna Henningsen authored
This reverts commit 037ac99e. As flaky CI failures have revealed, this feature was implemented incorrectly. `stop_sub_worker_contexts()` needs to be called on the thread on which the `Environment` is currently running, it’s not thread-safe. The current API requires `Stop()` to be thread-safe, though. We could add a new API for this, but unless there’s demand, that’s probably not necessary as `FreeEnvironment()` will also stop Workers, which is commonly the next action on an `Environment` instance after having `Stop()` called on it. Refs: https://github.com/nodejs/node/pull/32531 PR-URL: https://github.com/nodejs/node/pull/32623 Reviewed-By:
-
Harshitha KP authored
Fixes: https://github.com/nodejs/node/issues/32409 PR-URL: https://github.com/nodejs/node/pull/32514 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com>
-
Moni authored
PR-URL: https://github.com/nodejs/node/pull/32567 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Jan Krems authored
PR-URL: https://github.com/nodejs/node/pull/31303 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Myles Borins authored
s/PYTHON\_VERSION/python-version Refs: https://github.com/actions/setup-python PR-URL: https://github.com/nodejs/node/pull/32609 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Nick Kreeger authored
Due to how the Environment class is used throughout the codebase, there are a log of includes referencing eitehr env.h or env-inl.h. This commit cleans up the remaining extra includes of 'env.h' or 'env-inl.h' and adds forward declarations of the Environment class. PR-URL: https://github.com/nodejs/node/pull/32293 Refs: https://github.com/nodejs/node/issues/27531 Fixes: https://github.com/nodejs/node/issues/27531 Reviewed-By:
-
Harshitha KP authored
PR-URL: https://github.com/nodejs/node/pull/32305 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32541 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32278 Fixes: https://github.com/nodejs/node/issues/32250 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32550 Refs: https://github.com/nodejs/node/pull/32541 Reviewed-By:
-
Andrés M. Gómez authored
PR-URL: https://github.com/nodejs/node/pull/32573 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/32183 PR-URL: https://github.com/nodejs/node/pull/32617 Reviewed-By:
-
Robert Nagy authored
Refactors net.Socket into using autoDestroy functionality of streams. PR-URL: https://github.com/nodejs/node/pull/31806 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Alba Mendez authored
Fix broken links found by the checker, and exclude test/fixtures as it contains invalid links. Also exclude doc/changelogs because they're huge files which take very long to parse, and (IIRC) are auto-generated anyway. (Oh and also a nit at the README next to my link) PR-URL: https://github.com/nodejs/node/pull/32586 Reviewed-By:
-
Alba Mendez authored
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: https://github.com/nodejs/node/pull/32359 PR-URL: https://github.com/nodejs/node/pull/32586 Reviewed-By:
-
Gerhard Stoebich authored
PR-URL: https://github.com/nodejs/node/pull/32620 Fixes: https://github.com/nodejs/node/issues/32333 Reviewed-By:
-
Ruben Bridgewater authored
Inspecting errors results in duplicated information in case an error is created with enumerable `name`, `message` or `stack` properties. In that case, check if the output already contains that information and prevent listing that property. This reduces the noise as receiver. PR-URL: https://github.com/nodejs/node/pull/32327 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Ben Noordhuis authored
`actual` is the first argument, `expected` the second, but the test flipped them around and was producing confusing assertion messages as a result. Refs: https://github.com/nodejs/node/pull/32408#issuecomment-602170887 PR-URL: https://github.com/nodejs/node/pull/32420 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Lucas Holmquist authored
This makes the offset, length and position parameters optional by passing in an options object. PR-URL: https://github.com/nodejs/node/pull/32460 Reviewed-By:
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
cjihrig authored
Update ESLint to 7.0.0-alpha.3 PR-URL: https://github.com/nodejs/node/pull/32533 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32542 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32544 Reviewed-By:
-
Daniel Estiven Rico Posada authored
PR-URL: https://github.com/nodejs/node/pull/32549 Reviewed-By:
-
James M Snell authored
* Simplify Http2Priority struct * BooleanValue => IsTrue/IsFalse Signed-off-by:
-
James M Snell authored
Suppress compile warnings on Windows, rename class for consistent styling. Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
Anna Henningsen authored
There’s no reason for this to not be stored alongside the loop data structure itself. PR-URL: https://github.com/nodejs/node/pull/32562 Refs: https://github.com/nodejs/node/pull/32344 Reviewed-By:
-
Anna Henningsen authored
Instead of setting and then in the case of error un-setting properties, only set them when no error occurs. Refs: https://github.com/nodejs/node/pull/32344 PR-URL: https://github.com/nodejs/node/pull/32562 Reviewed-By:
-
Hachimi Aa (Sfeir) authored
PR-URL: https://github.com/nodejs/node/pull/29270 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Ben Noordhuis authored
Authenticated decryption works for file streams up to 32768 bytes but not beyond. Other streams and direct decryption are not affected. Refs: https://github.com/nodejs/node/issues/31733 PR-URL: https://github.com/nodejs/node/pull/31734 Reviewed-By:
-
- Apr 02, 2020
-
-
Anna Henningsen authored
Overlooked in 2fa74e3e. Refs: https://github.com/nodejs/node/pull/32207 PR-URL: https://github.com/nodejs/node/pull/32535 Reviewed-By:
-
Anna Henningsen authored
… and move them to `IsolateData`, because they should exist once per Isolate. PR-URL: https://github.com/nodejs/node/pull/32572 Reviewed-By:
-
Anna Henningsen authored
I’ve seen this fail a few times in CI, presumably because the inspector commmand did not reach the child thread in time. Explicitly waiting seems to solve that. Refs: https://github.com/nodejs/node/pull/30467 PR-URL: https://github.com/nodejs/node/pull/32563 Reviewed-By:
-
Anna Henningsen authored
The JSONWriter feature is not inherently related to the report feature in any way. As a drive-by fix, remove a number of unused header includes. PR-URL: https://github.com/nodejs/node/pull/32552 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Anna Henningsen authored
Class names are written in UpperCamelCase. Otherwise, this looks like it’s a variable, not a class name. PR-URL: https://github.com/nodejs/node/pull/32539 Reviewed-By:
-
Anna Henningsen authored
This makes sense given that terminating execution of the parent thread this way likely also is supposed to stop all running Worker threads spawned by it. PR-URL: https://github.com/nodejs/node/pull/32531 Reviewed-By:
-
