- Mar 21, 2020
-
-
Anna Henningsen authored
This makes this bit of the embedder situation a bit easier to use. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/31910 PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
Allow passing a string as the main module rather than using the callback variant. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
This allows embedders to flexibly control how they start JS code rather than using `third_party_main`. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
This addresses some long-standing TODOs by Joyee and me about making the embedder API more powerful and us less reliant on internal APIs for creating the main thread and Workers. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
In our codebase, the assumption generally is that `!is_main_thread()` means that the current Environment belongs to a Node.js Worker thread. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
Workers are fully in control of their Isolates, and this helps avoid a problem with later changes to `CreateEnvironment()` because now we can run the boostrapping code inside the latter. PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Anna Henningsen authored
Make the calls `stop_sub_worker_contexts()`, `RunCleanup()` part of the public API for easier embedding. (Note that calling `RunAtExit()` is idempotent because the at-exit callback queue is cleared after each call.) PR-URL: https://github.com/nodejs/node/pull/30467 Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Refs: https://github.com/sindresorhus/macos-term-size/pull/3 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ash Cripps <ashley.cripps@ibm.com> Signed-off-by:
Rod Vagg <rod@vagg.org>
-
Anna Henningsen authored
There’s no need to use `Isolate::GetCurrent()`, which is generally discouraged, as the `Isolate*` pointer can generally be looked up from the per-Isolate platform data structure. PR-URL: https://github.com/nodejs/node/pull/32269 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/31502#issuecomment-599242824 PR-URL: https://github.com/nodejs/node/pull/32300 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Steven R. Loomis authored
- ICU 66.1 http://site.icu-project.org/download/66 - Unicode 13 - CLDR 36.1 - Updated ./LICENSE PR-URL: https://github.com/nodejs/node/pull/32348 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Steven R. Loomis authored
- Docs used the word "copy" when it really meant a tool is needed. - README-FULL-ICU.txt was generated in binary mode, but it's a text file. This breaks on Python3 for maintaining ICU - The ICU downloader was broken (also probably python3). It's basically dead code since 1a25e901 landed (full icu in repo), unless someone deleted the deps/icu-small directory from their repo. Co-Authored-By:
-
Sam Roberts authored
There is lots of space to expand this not-so-well-known acronym in the option usage message. PR-URL: https://github.com/nodejs/node/pull/32325 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Gabriel Schulhof authored
This adds the new option `HUGEPAGES` to `NODE_DEBUG_NATIVE` that causes the code responsible for re-mapping to large pages to output memory range and page count information to `stderr`. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/32331 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
- Mar 20, 2020
-
-
Xu Meng authored
When TTY initialization failed, uv_tty_init returned EBADF on IBM i PASE, rather than EINVAL PR-URL: https://github.com/nodejs/node/pull/32338 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
Ben Noordhuis authored
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. PR-URL: https://github.com/nodejs/node/pull/32387 Refs: https://github.com/nodejs/node/pull/32368 Refs: https://github.com/npm/cli/issues/1037 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32251 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_0 PR-URL: https://github.com/nodejs/node/pull/32246 Reviewed-By:
-
Anna Henningsen authored
They do the same thing, but OnScopeLeave avoids an extra heap allocation and is more explicit about what it does. PR-URL: https://github.com/nodejs/node/pull/32247 Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/31679 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/32368 Refs: https://github.com/nodejs/node/issues/32296 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
- Mar 19, 2020
-
-
James M Snell authored
Signed-off-by:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Robert Nagy authored
- Ensure automatic destruction only happens after both 'end' and 'finish' has been emitted through autoDestroy. - Ensure close() callback is always invoked. - Ensure 'error' is only emitted once. PR-URL: https://github.com/nodejs/node/pull/32220 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/32309 Reviewed-By:
-
Matheus Marchini authored
GitHub Actions doesn't have enough memory to complete an ASAN+Debug with V8 8.1. Don't take ASAN into account on CI results until we find a workaround, or until we upgrade to V8 8.2. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Clemens Backes authored
PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
V8 is removing support for serializing wasm modules via the value serializer. Once this is complete (https://crrev.com/c/2013110), we can re-add this test. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Clemens Backes authored
This removes uses of the "IsWebAssemblyCompiledModule" method, which is deprecated in V8 v8.1 and will be removed in v8.2. We could replace it by "IsWasmModuleObject", but since it's unused in node anyway, I just remove the definition. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Clemens Backes authored
The {SetExpectInlineWasm} method is deprecated and non-functional since V8 v8.1. Thus node should stop calling it, so that it can be fully removed in a future v8 version. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By: -
cjihrig authored
This commit replaces Symbol::Name() with Symbol::Description(). Fixes: https://github.com/nodejs/node/issues/30916 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Clemens Backes authored
These methods will be removed in V8 8.1, hence we need to stop overriding them. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By:
Refael Ackermann <refack@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
Original commit message: [torque] fix build on VS2017 Node.js build fails on VS2017 without these headers, see the downstream issue (https://github.com/nodejs/node-v8/issues/128 ). Co-authored-by:Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66661} Refs: https://github.com/v8/v8/commit/931bdbd76f5b5416447bf02c8c41fbf64573e537 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Matheus Marchini authored
Original commit message: Remove unnecessary export, which happens to break MSVC DLL builds. Change-Id: I47c9211274cefd26bde6bd93aa7503e022df4357 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2042874 Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Bill Ticehurst <billti@microsoft.com> Cr-Commit-Position: refs/heads/master@{#66179} Refs: https://github.com/v8/v8/commit/1e36e21acc4016b066ea4d20f3957665b7fdbce6 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Michaël Zasso authored
Bump minimum version of ICU needed to build node to 65. Refs: https://github.com/v8/v8/commit/74bf96e508e3cb8f9991c48b421d48eb0bf4dbff PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Michaël Zasso authored
This reverts commit 5981fb7f. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
