- Apr 17, 2018
-
-
Yang Guo authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Yang Guo authored
Even if we only use v8_monolith build target, other targets in v8.gyp with possibly outdated file lists are parsed and could cause build to fail even with --build-v8-with-gn. PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Yang Guo authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Joyee Cheung authored
Refs: https://github.com/v8/v8/commit/f9934aa9cf77b76c5fa78137e32939f30d9e2f81 Fixes: https://github.com/nodejs/node-v8/issues/36 PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Michaël Zasso authored
Synchronize source files list with upstream's BUILD.gn. PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Myles Borins authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 6.6. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/19201 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/19942 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19938 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19881 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Luigi Pinca authored
Fix test-http-dump-req-when-res-ends and move it back to test/parallel/ PR-URL: https://github.com/nodejs/node/pull/19866 Refs: https://github.com/nodejs/node/pull/19823 Reviewed-By:
-
Pieter Mees authored
PR-URL: https://github.com/nodejs/node/pull/19842 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Pieter Mees authored
PR-URL: https://github.com/nodejs/node/pull/19842 Reviewed-By:
-
Daniel Bevenius authored
This test currently fails when configured --without-ssl: Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support This commit moves the require of http2 to come after the crypto check to avoid the error. PR-URL: https://github.com/nodejs/node/pull/19907 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Daniel Bevenius authored
Currently this test fails if run as the root user: Mismatched innerFn function calls. Expected exactly 62, actual 42. The motivation for this is that when building node in a docker container it is convenient to be able to build as root. PR-URL: https://github.com/nodejs/node/pull/19850 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/19682 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/19684 Reviewed-By:
Jackson Tian <shyvo1987@gmail.com> Reviewed-By:
-
- Apr 11, 2018
-
-
cjihrig authored
This commit adds basic functionality testing of the help URL printed when the inspector starts. PR-URL: https://github.com/nodejs/node/pull/19887 Refs: https://github.com/nodejs/node/pull/19871 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
- Apr 10, 2018
-
-
Jesse Gorzinski authored
PR-URL: https://github.com/nodejs/node/pull/19667 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19913 Reviewed-By:
-
Luigi Pinca authored
Strip the enclosing square brackets from the parsed hostname. PR-URL: https://github.com/nodejs/node/pull/19720 Reviewed-By:
-
juggernaut451 authored
PR-URL: https://github.com/nodejs/node/pull/18985 Reviewed-By:
-
juggernaut451 authored
Added common.mustCall and replaced function with arrow function. PR-URL: https://github.com/nodejs/node/pull/19096 Fixes: https://github.com/nodejs/node/issues/14544 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Nick Filatov authored
PR-URL: https://github.com/nodejs/node/pull/19871 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Kohei Hiraga authored
fs.ReadStream / fs.WriteStream destroy([error]) function should emit 'error' event if `error` is set. PR-URL: https://github.com/nodejs/node/pull/19735 Fixes: https://github.com/nodejs/node/issues/19727 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure acorn is only loaded in case it is necessary. PR-URL: https://github.com/nodejs/node/pull/19863 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
`assert.throws` also accepts objects and errors as input. This fixes the error message accodingly. PR-URL: https://github.com/nodejs/node/pull/19865 Reviewed-By:
-
Joyee Cheung authored
The old error name and message were trying to be consistent with ERR_BUFFER_TOO_LARGE but they were not really accurate. The kStringMaxLength was measured in number of characters, not number of bytes. The name ERR_STRING_TOO_LARGE also seems a bit awkward. This patch tries to correct them before they get released to users. PR-URL: https://github.com/nodejs/node/pull/19864 Refs: https://github.com/nodejs/node/pull/19739 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Santiago Gimeno authored
Close the connection immediately after receiving the `end` event to avoid that the `timeout` event is fired before the connection closes gracefully. Move the test back to parallel. PR-URL: https://github.com/nodejs/node/pull/19856 Fixes: https://github.com/nodejs/node/issues/19804 Reviewed-By:
-
Ryusei Yamaguchi authored
This fixes negation ommitted in a former commit. It also simplifies the text in general. PR-URL: https://github.com/nodejs/node/pull/19752 Refs: https://github.com/nodejs/node/commit/80ea0c5a64fe673011e8b1025de23a0ea7f3f7f8 Reviewed-By:
-
Anand Suresh authored
From the zlib v1.2.11 manual: > ZEXTERN int ZEXPORT inflateInit2 OF((z_streamp strm, > int windowBits)); > > ... > windowBits can also be zero to request that inflate use the window > size in the zlib header of the compressed stream. The current validation of windowBits in zlib.js doesn't check for this case. PR-URL: https://github.com/nodejs/node/pull/19686 Reviewed-By:
-
Ben Noordhuis authored
Original commit message: [intl] unbreak build with ICU 57 Remove a call to `icu::toUCharPtr()` that wasn't present in other similar looking call sites either, just reinterpret_cast directly. Fixes https://github.com/nodejs/node/issues/19656. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If281ce0a39356aa8bd20efb24c3e4b52b06841a3 Reviewed-on: https://chromium-review.googlesource.com/987953 Reviewed-by:Daniel Ehrenberg <littledan@chromium.org> Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl> Cr-Commit-Position: refs/heads/master@{#52311} PR-URL: https://github.com/nodejs/node/pull/19710 Fixes: https://github.com/nodejs/node/issues/19656 Refs: https://github.com/v8/v8/commit/b767cde1e7bb94b3fea13f2d7e10cd90e6813d6c Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
-
Sergey Golovin authored
PR-URL: https://github.com/nodejs/node/pull/19267 Reviewed-By:
-
Zhenzhen Zhan authored
Adds a test for module loading when throwing undefined or null. PR-URL: https://github.com/nodejs/node/pull/19282 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
-
Anna Henningsen authored
In addition to `--pending-deprecation`, emit a deprecation warning for usage of the `Buffer()` constructor for call sites that are outside of `node_modules`. The goal of this is to better target developers, rather than burdening users with an omnipresent and quickly ignored warning. This implements the result of a TSC meeting discussion from March 22, 2018. PR-URL: https://github.com/nodejs/node/pull/19524 Refs: https://github.com/nodejs/node/issues/19079#issuecomment-375121443 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
juggernaut451 authored
test: refactor parallel/test-tls-delayed-attach Added description to the test, replace function with arrow function and implemented common.mustCall PR-URL: https://github.com/nodejs/node/pull/19421 Reviewed-By:
-
Anna Henningsen authored
The introduction of `.bytesRead` to zlib streams was unfortunate, because other streams in Node.js core use the exact opposite naming of `.bytesRead` and `.bytesWritten`. While one could see how the original naming makes sense in a `Transform` stream context, we should try to work towards more consistent APIs in core for these things. This introduces `zlib.bytesWritten` and documentation-only deprecates `zlib.bytesRead`. PR-URL: https://github.com/nodejs/node/pull/19414 Refs: https://github.com/nodejs/node/issues/8874 Refs: https://github.com/nodejs/node/pull/13088 Reviewed-By:
-
Benjamin Gruenbaum authored
Currently whatwg URLs fail with an incorrect error when null is passed as the base. Adding a check before accessing a symbol for the URL makes the URL error correctly. Add test for it. PR-URL: https://github.com/nodejs/node/pull/19299 Fixes: https://github.com/nodejs/node/issues/19254 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
