- Apr 28, 2020
-
-
karan singh virdi authored
This commit fixes the interchangeably usage of "folder" and "directory" terms in fs.md Fixes: https://github.com/nodejs/node/issues/32902 PR-URL: https://github.com/nodejs/node/pull/32919 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
雨夜带刀 authored
PR-URL: https://github.com/nodejs/node/pull/32901 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32640 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32910 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
cjihrig authored
Notable changes: - The UV_UDP_RECVMMSG flag has been added. This flag is now required in order to utilize recvmmsg(). This was added in response to a regression introduced in 1.35.0 and 1.36.0. PR-URL: https://github.com/nodejs/node/pull/32866 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
cjihrig authored
Notable changes: - gyp support has been removed. - recvmmsg messages are returned in the correct order. - IBMi cmake support has been added. - uv_fs_lutime() has been added. - uv_fs_statfs() on Windows properly handles file paths. PR-URL: https://github.com/nodejs/node/pull/32866 Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/nodejs.org/pull/3106#issuecomment-614258785 PR-URL: https://github.com/nodejs/node/pull/32903 Reviewed-By:
-
Juan José Arboleda authored
Based on https://github.com/nodejs/help/issues/2600#issuecomment-612857153 the condition (amount < 0) won't be possible. PR-URL: https://github.com/nodejs/node/pull/32818 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
Jesus Hernandez authored
PR-URL: https://github.com/nodejs/node/pull/32662 Reviewed-By:
-
David Daza authored
The if statement inside the _writeHostObject function returns an expression which makes the else block unnecessary. PR-URL: https://github.com/nodejs/node/pull/32644 Reviewed-By:
-
Vadzim Zieńka authored
Call iterator.return() if not all of its values are consumed. Fixes: https://github.com/nodejs/node/issues/32842 PR-URL: https://github.com/nodejs/node/pull/32844 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32886 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32832 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Nimit authored
Convert callback functions that are anonymous to arrow functions for better readability. Also adjusted the `this` object in places where that was required. PR-URL: https://github.com/nodejs/node/pull/32875 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Nimit authored
elevate v8 namespaces. Leverage `using` semantics for repeated usage of v8 artifacts. PR-URL: https://github.com/nodejs/node/pull/32872 Reviewed-By:
-
Anna Henningsen authored
This fixes the following crash on Windows for me. I don't know why this I only started to see this now, but anyway, the new timeout value is still longer than a week and a half. File "tools/test.py", line 1725, in <module> sys.exit(Main()) File "tools/test.py", line 1701, in Main if RunTestCases(cases_to_run, options.progress, \ options.j, options.flaky_tests): File "tools/test.py", line 923, in RunTestCases return progress.Run(tasks) File "tools/test.py", line 145, in Run thread.join(timeout=10000000) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1015, in join self._wait_for_tstate_lock(timeout=max(timeout, 0)) File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \ lib\threading.py", line 1027, in _wait_for_tstate_lock elif lock.acquire(block, timeout): OverflowError: timeout value is too large PR-URL: https://github.com/nodejs/node/pull/32868 Reviewed-By:Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32854 Reviewed-By:
-
Michael Dawson authored
We missed adding version 6 to the compatibility table when we defined version 6. Add it along with the versions that we know will include version 6. PR-URL: https://github.com/nodejs/node/pull/32829 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32906 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/31974 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
-
William Bonawentura authored
PR-URL: https://github.com/nodejs/node/pull/32657 Reviewed-By:
-
Qinhui Chen authored
Delete useless module in parent module: parent.children array when error occurs, so that it can be garbage collected. Fixes: https://github.com/nodejs/node/issues/32836 PR-URL: https://github.com/nodejs/node/pull/32837 Reviewed-By:
-
Daniel Bevenius authored
This commit removes unused using declarations in src/node_worker.cc. PR-URL: https://github.com/nodejs/node/pull/32840 Reviewed-By:
-
Michael Dawson authored
- add backticks around use of NULL - convert from null to NULL where we mean NULL Signed-off-by:
Christopher Hiller <boneskull@boneskull.com>
-
Richard Lau authored
When running `make test-v8` V8's `gclient sync` converts folders under `deps/v8/third_party` into git repositories. Unfortunately the files that were checked in under `deps/v8/third_party/zlib` have been modified from the upstream Chromium repository (some files have been deleted and there are whitespace differences in some of the files that were kept) so whenever the Node.js source tree is hard reset/checked out `gclient sync` notices there are unstaged changes as the files in the Node.js source tree do not match those of the upstream Chromium third party zlib commit. Signed-off-by:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
daemon1024 authored
PR-URL: https://github.com/nodejs/node/pull/32692 Fixes: https://github.com/nodejs/node/issues/32678 Reviewed-By:
-
Xu Meng authored
To skip some tests on IBMi PASE, we use uname to detect the true os name, but on Windows machines there is no uname available. PR-URL: https://github.com/nodejs/node/pull/32833 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
-
Robert Nagy authored
Refer back to streams docs for further and more accurate description of behavior details. Refs: https://github.com/nodejs/node/issues/31916 PR-URL: https://github.com/nodejs/node/pull/32811 Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Robert Nagy authored
destroy w/ is undocumented API which also will cause a race if the stream is already destroying and potentially invoking the callback too early and withou error. PR-URL: https://github.com/nodejs/node/pull/32809 Reviewed-By:
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/27611#issuecomment-613100468 PR-URL: https://github.com/nodejs/node/pull/32828 Reviewed-By:
-
Robert Nagy authored
Remove nesting in favor of early returns. PR-URL: https://github.com/nodejs/node/pull/32801 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/32797#discussion_r407222290 PR-URL: https://github.com/nodejs/node/pull/32798 Reviewed-By:
-
Anna Henningsen authored
Suggest using `--trace-warnings` or `--trace-deprecation` the first time a warning is emitted without a stack trace, similar to how we suggest `--trace-uncaught` when printing uncaught exceptions without a stack trace. PR-URL: https://github.com/nodejs/node/pull/32797 Reviewed-By:
-
Jesus Hernandez authored
PR-URL: https://github.com/nodejs/node/pull/32727 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/26401#issuecomment-613095719 PR-URL: https://github.com/nodejs/node/pull/32826 Reviewed-By:
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/29802 Refs: https://github.com/nodejs/node/pull/32595 PR-URL: https://github.com/nodejs/node/pull/32825 Reviewed-By:
-
Reşat SABIQ authored
PR-URL: https://github.com/nodejs/node/pull/32591 Fixes: https://github.com/nodejs/node/issues/32559 Reviewed-By:
-
Julian Duque authored
PR-URL: https://github.com/nodejs/node/pull/32751 Reviewed-By:
Adrian Estrada <edsadr@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
Currently, the following warnings are emitted during compilation: In file included from ../src/string_bytes.h:29, from ../src/string_bytes.cc:22: ../deps/v8/include/v8.h: In instantiation of ‘void v8::PersistentBase<T>::SetWeak( P*,typename v8::WeakCallbackInfo<P>::Callback, v8::WeakCallbackType) [with P = node::BaseObject; T = v8::Object; typename v8::WeakCallbackInfo<P>::Callback = void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)]’: ../src/base_object-inl.h:135:42: required from here ../deps/v8/include/v8.h:10732:16: warning: cast between incompatible function types from ‘v8::WeakCallbackInfo<node::BaseObject>::Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<node::BaseObject>&)’} to ‘Callback’ {aka ‘void (*)(const v8::WeakCallbackInfo<void>&)’} [-Wcast-function-type] 10732 | reinterpret_cast<Callback>(callback), type); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ And the... -
Yash Ladha authored
check for callback function is moved to a separate function. This piece of code is being shared by other entities as well. PR-URL: https://github.com/nodejs/node/pull/32665 Reviewed-By:
-
