- Oct 15, 2018
-
-
Long Nguyen authored
This change removes a variable that is not being used in the file. PR-URL: https://github.com/nodejs/node/pull/23497 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Jenna Zeigen authored
PR-URL: https://github.com/nodejs/node/pull/23498 Reviewed-By:
-
@CAYdenberg authored
PR-URL: https://github.com/nodejs/node/pull/23499 Reviewed-By:
-
chrisforrette authored
PR-URL: https://github.com/nodejs/node/pull/23500 Reviewed-By:
-
Felix Schlenkrich authored
The information on how to run single tests was missing in BUILDING.md. PR-URL: https://github.com/nodejs/node/pull/23490 Fixes: https://github.com/nodejs/node/issues/23491 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Felix Schlenkrich authored
PR-URL: https://github.com/nodejs/node/pull/23490 Reviewed-By:
-
Kayla Altepeter authored
PR-URL: https://github.com/nodejs/node/pull/23488 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
-
Carl Richmond authored
PR-URL: https://github.com/nodejs/node/pull/23489 Reviewed-By:
-
Steven Scott authored
Switch the cjs loader to use internalBinding instead of process.binding for reading command line options. PR-URL: https://github.com/nodejs/node/pull/23492 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Carolina Pinzon authored
PR-URL: https://github.com/nodejs/node/pull/23549 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Artur Hayrapetyan authored
PR-URL: https://github.com/nodejs/node/pull/23551 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Artur Hayrapetyan authored
PR-URL: https://github.com/nodejs/node/pull/23551 Reviewed-By:
-
Chris Nguyen authored
PR-URL: https://github.com/nodejs/node/pull/23533 Reviewed-By:
-
Сковорода Никита Андреевич authored
Fixes one WHATWG URL example to match the actual behavior. PR-URL: https://github.com/nodejs/node/pull/23359 Fixes: https://github.com/nodejs/node/issues/22653 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Сковорода Никита Андреевич authored
Changes non-reserved domains to reserved ones in url.md. PR-URL: https://github.com/nodejs/node/pull/23359 Refs: https://www.iana.org/domains/reserved Reviewed-By:
-
Сковорода Никита Андреевич authored
Now it points to the actual pr, not to /compare/. PR-URL: https://github.com/nodejs/node/pull/23359 Reviewed-By:
-
Сковорода Никита Андреевич authored
This fixes links that were broken due to inclusion of the trailing dot. Also simplifies a pair of occurances of [](). PR-URL: https://github.com/nodejs/node/pull/23359 Reviewed-By:
-
Diana Holland authored
PR-URL: https://github.com/nodejs/node/pull/23610 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
cjihrig authored
Update ESLint to 5.7.0. PR-URL: https://github.com/nodejs/node/pull/23629 Reviewed-By:
-
Anna Zhao authored
PR-URL: https://github.com/nodejs/node/pull/23483 Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
David Corona authored
Moving the default assignment of async_id from the constructor in async_wrap.cc to class definition in async_wrap.h PR-URL: https://github.com/nodejs/node/pull/23495 Reviewed-By:
-
Michal Hynek authored
Removed an unused variable in test-buffer-failed-alloc-typed-arrays.js. PR-URL: https://github.com/nodejs/node/pull/23481 Reviewed-By:
-
Claire Liu authored
PR-URL: https://github.com/nodejs/node/pull/23482 Reviewed-By:
-
Matt Jiles authored
try catch syntax allows elimination of function arguments so removed unused err argument PR-URL: https://github.com/nodejs/node/pull/23484 Reviewed-By:
-
Stacey authored
PR-URL: https://github.com/nodejs/node/pull/23485 Reviewed-By:
-
Rock Hu authored
PR-URL: https://github.com/nodejs/node/pull/23480 Reviewed-By:
-
Ian Sutherland authored
Change ConstructorBehavior from kAllow to kThrow. Co-authored-by:
Bruce A. MacNaughton <bmacnaughton@gmail.com> Refs: https://github.com/nodejs/node/pull/23453 PR-URL: https://github.com/nodejs/node/pull/23447 Reviewed-By:
-
Bruce A. MacNaughton authored
Throw an error if verify_error_getter_templ or verify_error_getter_templ2 are used as constructors. PR-URL: https://github.com/nodejs/node/pull/23582 Reviewed-By:
-
Quinn Langille authored
PR-URL: https://github.com/nodejs/node/pull/23467 Reviewed-By:
-
Muzafar Umarov authored
Wrote a sequential benchmark test for worker. This is to make sure the benchmark for work runs properly. PR-URL: https://github.com/nodejs/node/pull/23475 Reviewed-By:
-
Stephen Heitman authored
PR-URL: https://github.com/nodejs/node/pull/23476 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Paige Kato authored
PR-URL: https://github.com/nodejs/node/pull/23477 Reviewed-By:
-
ashleysimpson authored
PR-URL: https://github.com/nodejs/node/pull/23479 Reviewed-By:
-
cjihrig authored
Recently, process.binding() was replaced with internalBinding(). However, internalBinding() is not available on older builds of Node, which are often used for benchmarking purposes. This commit adds a common.binding() to the benchmarks to work around the issue. Hopefully, this can be removed in the not too distant future. PR-URL: https://github.com/nodejs/node/pull/23460 Fixes: https://github.com/nodejs/node/issues/23436 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Rich Trott authored
I should have done this a few days ago so it could land in time for Code & Learn, but oh well. Here are some revisions to BUILDING.md to try to make it easier to read. PR-URL: https://github.com/nodejs/node/pull/23435 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
George Adams <george.adams@uk.ibm.com>
-
- Oct 14, 2018
-
-
Dylson Valente Neto authored
Documentation for assertions rule actual values should be passed first followed by the expected value. This commit update the assertions the changed file contains to comply to that rule. Changes also label the assertions. PR-URL: https://github.com/nodejs/node/pull/23580 Reviewed-By:
-
Lian Li authored
PR-URL: https://github.com/nodejs/node/pull/23472 Reviewed-By:
-
Tim Cheung authored
Assertion arguments should have the first value be the actual value, while the second value be the expected value. PR-URL: https://github.com/nodejs/node/pull/23470 Reviewed-By:
-
Yitong authored
PR-URL: https://github.com/nodejs/node/pull/23474 Reviewed-By:
-
Yitong authored
'test/parallel/test-fs-write.js' contains assertions where the first argument provided is the expected value and the second value is the actual value. This is backward from the documentation for assertions like 'assert.strictEqual()' where the first value should be the actual value being tested and the second value is the expected value. PR-URL: https://github.com/nodejs/node/pull/23474 Reviewed-By:
-
