- Aug 19, 2019
-
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/28918 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cjihrig authored
The following metadata has changed: - v8dbg_class_ConsString__first__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ConsString__first_offset__int - Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9 - v8dbg_class_ConsString__second__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ConsString__second_offset__int - Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9 - v8dbg_class_SlicedString__offset__SMI - Class is now generated via torque. - Postmortem tools should use v8dbg_class_SlicedString__offset_offset__int - Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9 - v8dbg_class_ThinString__actual__String - Class is now generated via torque. - Postmortem tools should use v8dbg_class_ThinString__actual_offset__int - Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9 PR-URL: https://github.com/nodejs/node/pull/28918 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/28918 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michaël Zasso authored
Co-authored-by:
Ujjwal Sharma <usharma1998@gmail.com> PR-URL: https://github.com/nodejs/node/pull/28918 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cclauss authored
Original commit message: [build] update gen-postmortem-metadata for Python 3 This change makes the code compatible with both Python 2 and Python 3. Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63207} Refs: https://github.com/v8/v8/commit/e3d7f8a58887d25919641757a91345c56dda2a52 PR-URL: https://github.com/nodejs/node/pull/29105 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/28016 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/27375 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Refael Ackermann authored
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html PR-URL: https://github.com/nodejs/node/pull/28016 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Refael Ackermann authored
`std::atomic_init<size_t>` is not implemented on all platforms. PR-URL: https://github.com/nodejs/node/pull/27375 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Refael Ackermann authored
This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/27375 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Refael Ackermann authored
Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/27375 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
cjihrig authored
Update postmortem metadata constants for V8 7.7 in Node.js. PR-URL: https://github.com/nodejs/node/pull/28918 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Refael Ackermann authored
Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/28016 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 7.7. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/28918 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/28918 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/28918 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
There is no longer a need to skip sequential/test-benchmark-napi because it no longer resides in sequential. Benchmark tests are now in their own directory. PR-URL: https://github.com/nodejs/node/pull/29173 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
David Guttman authored
Changes example command to refer to the full test directory: `./test/parallel/` instead of `./parallel/` PR-URL: https://github.com/nodejs/node/pull/29171 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Robert Nagy authored
Do not emit 'prefinish' or 'finish' event after an error. PR-URL: https://github.com/nodejs/node/pull/28708 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Anna Henningsen authored
As the comment in `node_revert.h` indicates, the master branch should not provide security revert flags. Refs: https://github.com/nodejs/node/pull/29122 PR-URL: https://github.com/nodejs/node/pull/29141 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
MattIPv4 authored
PR-URL: https://github.com/nodejs/node/pull/29170 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
- Aug 18, 2019
-
-
Anna Henningsen authored
This option is not useful in practice, as mentioned in comments and the documentation, because the overhead of calling into JS makes it unreasonably expensive. PR-URL: https://github.com/nodejs/node/pull/29144 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Sam Roberts authored
It was called --security-revert prior to 12.x, but changed in https://github.com/nodejs/node/pull/22490. See: https://github.com/nodejs/nodejs.org/pull/2412#issuecomment-521739752 PR-URL: https://github.com/nodejs/node/pull/29153 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
cjihrig authored
This commit adds support for closing a readline interface on Control+D when the terminal is dumb. PR-URL: https://github.com/nodejs/node/pull/29149 Fixes: https://github.com/nodejs/node/issues/29111 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
cjihrig authored
This commit adds support for closing a readline interface on Control+C when the terminal is dumb. PR-URL: https://github.com/nodejs/node/pull/29149 Fixes: https://github.com/nodejs/node/issues/29111 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
- Aug 17, 2019
-
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/29145 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/29015 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Robert Nagy authored
This is work towards resolving the response.finished confusion and future deprecation. Note that implementation-wise, streams have both an ending and ended state. However, in this case (in order to avoid confusion in user space) writableEnded is equal to writable.ending. The ending vs ended situation is internal state required for internal stream logic. PR-URL: https://github.com/nodejs/node/pull/28934 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Anas Aboureada authored
fs with writev allow many buffers to be pushed to underlying OS APIs in one batch, so this should improve write speed to files. Refs: https://github.com/nodejs/node/issues/2298 PR-URL: https://github.com/nodejs/node/pull/25925 Fixes: https://github.com/nodejs/node/issues/2298 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Zach Bjornson authored
Ref https://github.com/nodejs/node/issues/26563 PR-URL: https://github.com/nodejs/node/pull/26572 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Zach Bjornson authored
PR-URL: https://github.com/nodejs/node/pull/26572 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Zach Bjornson authored
Since v10.10.0, 'buf' can be any DataView, meaning the largest byteLength can be Float64Array.BYTES_PER_ELEMENT * kMaxLength = 17,179,869,176. 'offset' can now be up to 2**53 - 1. This makes it possible to tile reads into a large buffer. Breaking: now throws if read offset is not a safe int, is null or is undefined. Fixes https://github.com/nodejs/node/issues/26563 PR-URL: https://github.com/nodejs/node/pull/26572 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Zach Bjornson authored
PR-URL: https://github.com/nodejs/node/pull/26572 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Luigi Pinca authored
Make `tls.connect()` support an `allowHalfOpen` option which specifies whether or not to allow the connection to be half-opened when the `socket` option is not specified. PR-URL: https://github.com/nodejs/node/pull/27836 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ouyang Yadong <oyydoibh@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Gerhard Stoebich authored
Parameter y in cursorTo() is optional and this is also verified by tests but docs don't state this. Besides that if the newly added parameter callback is used with no y, it's quite unhandy. This PR allows to simply omit y. PR-URL: https://github.com/nodejs/node/pull/29128 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Robert Nagy authored
Ensure errorEmitted is always set. Only emit 'error' once. PR-URL: https://github.com/nodejs/node/pull/29058 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Daniel Bevenius authored
This commit adds a target named testclean to allow for cleaning the temporary files generated during a test run without having to use the clean target. PR-URL: https://github.com/nodejs/node/pull/29094 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/29095 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-