- Jul 25, 2021
-
-
Luigi Pinca authored
Make `EventTarget.prototype.addEventListener()` accept `null` as a valid value for the `options` argument. PR-URL: https://github.com/nodejs/node/pull/39486 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com>
-
Lance Ball authored
I have not contributed to Node.js in a couple of years. While I would love to continue doing so, there's not a high likelihood of this happening in the near future. This commit moves my status from collaborator to emeritus. It's been fun! Signed-off-by:
Lance Ball <lball@redhat.com> PR-URL: https://github.com/nodejs/node/pull/39501 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39488 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Rich Trott authored
This change was discussed at the TSC meeting today. PR-URL: https://github.com/nodejs/node/pull/39487 Reviewed-By:
-
Rich Trott authored
I exchanged email with Gerhard to make sure that this was the rendering of his name that was correct. PR-URL: https://github.com/nodejs/node/pull/39489 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
- Jul 24, 2021
-
-
Rich Trott authored
Modify .mailmap so Myles has the same email address in AUTHORS as he does in README. PR-URL: https://github.com/nodejs/node/pull/39503 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Rich Trott authored
Update entry in .mailmap to reflect the same entry in README for an existing collaborator. PR-URL: https://github.com/nodejs/node/pull/39457 Reviewed-By:
-
Rich Trott authored
The file is mostly sorted in lexical order but there are exceptins, a few of them significant. This puts everything in lexical order. PR-URL: https://github.com/nodejs/node/pull/39434 Reviewed-By:
-
- Jul 23, 2021
-
-
Rich Trott authored
Use the most recent and presumably preferred email for a collaborator whose .mailmap and README entries differ. PR-URL: https://github.com/nodejs/node/pull/39478 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39477 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/w3c/webcrypto/issues/255 Fixes: https://github.com/nodejs/node/issues/39442 PR-URL: https://github.com/nodejs/node/pull/39443 Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Antoine du Hamel authored
The checks made by this are now integrated to `remark-preset-lint-node`, there are no reason to keep it around anymore. PR-URL: https://github.com/nodejs/node/pull/39206 Reviewed-By:
-
legendecas authored
To help core contributors identify which file is missing from the build. PR-URL: https://github.com/nodejs/node/pull/39460 Refs: https://github.com/nodejs/node/issues/39408 Reviewed-By:
-
Stephen Belanger authored
Promise handling is special-cased for domains and trace_events. Domains must not add the `domain` property to promises in other contexts, and trace_events must be emitted from JavaScript as promises no longer have an AsyncWrap type attached to them. PR-URL: https://github.com/nodejs/node/pull/39135 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/39135 Reviewed-By:
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/39135 Reviewed-By:
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/39135 Reviewed-By:
-
Rich Trott authored
All three `destroy()` functions defined in adapter.js contain a `done()` function that takes no arguments. In one instance, however, an argument is nonetheless passed. Remove it for consistency. PR-URL: https://github.com/nodejs/node/pull/39475 Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39461 Reviewed-By:
-
- Jul 22, 2021
-
-
Anna Henningsen authored
When all strong `BaseObjectPtr`s to a `HandleWrap` are gone, we should not delete the `HandleWrap` outright, but instead close it and then delete it only once the libuv close callback has been called. Based on the valgrind output from the issue below, this has a good chance of fixing it. Fixes: https://github.com/nodejs/node/issues/39036 PR-URL: https://github.com/nodejs/node/pull/39441 Reviewed-By:
-
Matteo Collina authored
Release tag: https://github.com/HdrHistogram/HdrHistogram_c/releases/tag/0.11.2 Fixes: https://github.com/nodejs/node/issues/39450 PR-URL: https://github.com/nodejs/node/pull/39462 Reviewed-By:
-
James M Snell authored
Fix possible flaky failure. Keep uv_fs_close from being called twice on the same fd. Signed-off-by:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Benjamin Mayr authored
Improves the documentation for building Node.js with openssl-3.0.0+quic with enabled FIPS support. Adds missing but necesary steps to the documentation and makes it complete. Co-authored-by:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
- Jul 21, 2021
-
-
Daniel Bevenius authored
This commit updates error messages that have changed while these tests were disabled. PR-URL: https://github.com/nodejs/node/pull/39437 Reviewed-By:
-
Daniel Bevenius authored
This reverts commit 2ff93c89. PR-URL: https://github.com/nodejs/node/pull/39437 Reviewed-By:
-
Robert Nagy authored
Enables async function support for stream.compose. PR-URL: https://github.com/nodejs/node/pull/39435 Reviewed-By:
-
Rich Trott authored
Julien Gilli appears twice with two email addresses in the current AUTHORS file. Use .mailmap to map one to the other (keeping the most recent one). Also update email in the README from a (I believe invalid, since it is not listed in the email repo aliases.json file) nodejs.org email to the email they more recently committed with. Finally, re-run `update-authors.js` so they only have one entry in AUTHORS. PR-URL: https://github.com/nodejs/node/pull/39433 Reviewed-By:
-
Rich Trott authored
The current version of find-inactive-collaborators can generate a false positive if the mailmap entry for a collaborator does not match the entry in the README. (We should probably lint or otherwise check for that sort of mismatch but regardless, it is relatively easy to avoid having find-inactive-collaborators tripped up by it, so let's fix that too, which is this commit.) PR-URL: https://github.com/nodejs/node/pull/39432 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39430 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39430 Reviewed-By:
-
npm team authored
PR-URL: https://github.com/nodejs/node/pull/39403 Reviewed-By:
Ruy Adorno <ruyadorno@github.com> Reviewed-By:
-
- Jul 20, 2021
-
-
Rich Trott authored
The internal link checker was missing some broken links because it was being too restrictive about the characters it accepted as part of a link hash. Accept anything that isn't a terminating quotation mark. Refs: https://github.com/nodejs/node/pull/39426 Refs: https://github.com/nodejs/node/pull/39425 PR-URL: https://github.com/nodejs/node/pull/39429 Reviewed-By:
-
Michaël Zasso authored
gtest_prod.h is not enough to build V8's cctests. PR-URL: https://github.com/nodejs/node/pull/38990 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Michaël Zasso authored
Original commit message: [mips][wasm][liftoff] Fix compile failed Port 2b77ca200c56667c68895e49c96c10ff77834f09 Bug: v8:11809 Change-Id: Idbbbc10d1339d6c8463686b6e701fb601a217cab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931557 Reviewed-by:Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/master@{#74934} Refs: https://github.com/v8/v8/commit/5c76da8ddcf89297a8dc2606b68da97d7a5329cb PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [riscv64] Fix build failed Port 2b77ca200c56667c68895e49c96c10ff77834f09 Change-Id: Ie953a1d54f5529423ae35d1b1cd3ca25e8101c6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931577 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Reviewed-by:Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/master@{#74937} Refs: https://github.com/v8/v8/commit/359d44df4cdd9cdb40cb683b47c2bea6bb7609f6 PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: PPC/s390: [wasm][liftoff] Always zero-extend 32 bit offsets Port 2b77ca200c56667c68895e49c96c10ff77834f09 Original Commit Message: The upper 32 bits of the 64 bit offset register are not guaranteed to be cleared, so a zero-extension is needed. We already do the zero-extension in the case of explicit bounds checking, but this should also be done if the trap handler is enabled. R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ife3ae4f93b85fe1b2c76fe4b98fa408b5b51ed71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929661 Reviewed-by:Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74886} Refs: https://github.com/v8/v8/commit/3805a698f7b6803dd6ee002cfdda71296c71b30b PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [wasm][arm64] Always zero-extend 32 bit offsets, for realz We've already been zero-extending 32-bit offset registers since https://chromium-review.googlesource.com/c/v8/v8/+/2917612, but that patch only covered the case where offset_imm == 0. When there is a non-zero offset, we need the same fix. Bug: chromium:1224882,v8:11809 Change-Id: I1908f735929798f411346807fc4f3c79d8e04362 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2998582 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75500} Refs: https://github.com/v8/v8/commit/56fe020eec0c35e9816590114b1d80836a504156 Fixes: https://github.com/nodejs/node/issues/39327 PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [wasm][liftoff] Always zero-extend 32 bit offsets The upper 32 bits of the 64 bit offset register are not guaranteed to be cleared, so a zero-extension is needed. We already do the zero-extension in the case of explicit bounds checking, but this should also be done if the trap handler is enabled. R=clemensb@chromium.org CC=jkummerow@chromium.org Bug: v8:11809 Change-Id: I21e2535c701041d11fa06c176fa683d82db0a3f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2917612 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: -
Michaël Zasso authored
Original commit message: [liftoff] Handle constant memory indexes specially This adds detection for constant memory indexes which can statically be proven to be in-bounds (because the effective offset is within the minimum memory size). In these cases, we can skip the bounds check and the out-of-line code for the trap-handler. This often saves 1-2% of code size. R=ahaas@chromium.org Bug: v8:11802 Change-Id: I0ee094e6f1f5d132af1d6a8a7c539a4af6c3cb5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919827 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74825} Refs: https://github.com/v8/v8/commit/53784bdb8f01a6ff76fc3acd3aec4d605cb3bfcc PR-URL: https://github.com/nodejs/node/pull/39337 Reviewed-By:
-
Michaël Zasso authored
Original commit message: Move DCHECK() in JSCallOrConstructNode ctor into a helper function. As is, the DCHECK() has a #if inside, and MSVC has trouble pre-processing that. Fix this by moving the conditional inside the DCHECK() into a separate helper function. Bug: v8:11760 Change-Id: Ib4ae0fe263029bb426da378afa5b6881557ce652 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919421 Reviewed-by:Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
