- Dec 05, 2018
-
-
cjihrig authored
dns.promises is lazy loaded. Instead of using a seaparate Boolean flag to track whether or not it has been loaded, just inspect the state of the lazy loaded module itself. PR-URL: https://github.com/nodejs/node/pull/24788 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
cjihrig authored
fs.promises is lazy loaded. Instead of using a seaparate Boolean flag to track whether or not it has been loaded, just inspect the state of the lazy loaded module itself. PR-URL: https://github.com/nodejs/node/pull/24788 Reviewed-By:
-
Anna Henningsen authored
The argument to `common.mustNotCall()` is a message, not a function. PR-URL: https://github.com/nodejs/node/pull/24750 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Gireesh Punathil authored
Explain usage context and scope of AliasedBuffer API and its function in the C++ style guide. Provide an example code. Fixes: https://github.com/nodejs/node/issues/22977 PR-URL: https://github.com/nodejs/node/pull/24724 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
- Dec 04, 2018
-
-
jy95 authored
Update test-fs-open-flags to take advantage of destructuring and default values. Update test-fs-open-mode-mask to use a ternary to make use of a constant possible. PR-URL: https://github.com/nodejs/node/pull/23031 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ruben Bridgewater authored
This activates a eslint rule to verify that the `assert.strictEqual()` arguments are in the correct order. PR-URL: https://github.com/nodejs/node/pull/24752 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/24770 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Sam Roberts authored
Registration initialization functions are expected to have a 4th argument, a void*, so add them where necessary to fix the warnings. PR-URL: https://github.com/nodejs/node/pull/24737 Reviewed-By:
-
Gireesh Punathil authored
fs.writeFileSync takes flag param to define the file opening semantics. Add a scenario that covers flags as well. PR-URL: https://github.com/nodejs/node/pull/24766 Reviewed-By:
-
Joyee Cheung authored
This patch moves the computation of version metadata from node.cc into node_metadata{.h, .cc}, and creates a macro that can be used to iterate over the available version keys (v8, uv, .etc). This makes the code clearer as now we no longer need to add all the headers in node.cc just to compute the versions, and makes it easier to reuse the version definitions. PR-URL: https://github.com/nodejs/node/pull/24774 Reviewed-By: -
Joyee Cheung authored
Move these macros to util.h so they can be shared among different C++ files. Also, renames `READONLY_BOOLEAN_PROPERTY` to `READONLY_TRUE_PROPERTY` (since it sets the property to true), and use `ToV8Value` in `READONLY_STRING_PROPERTY`. PR-URL: https://github.com/nodejs/node/pull/24774 Reviewed-By:
-
Luigi Pinca authored
Destroy the socket if the `'clientError'` event is emitted and there is no listener for it. Fixes: https://github.com/nodejs/node/issues/24586 PR-URL: https://github.com/nodejs/node/pull/24757 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Gireesh Punathil authored
The examples show `process.stdout.fd` as a means to use synchronous writes in async_hooks context. However this is an undocumented field, so showcase a file write example instead. Fixes: https://github.com/nodejs/node/issues/22873 PR-URL: https://github.com/nodejs/node/pull/24741 Reviewed-By:
-
Joyee Cheung authored
This patch moves all the bootstrapper compilation to use NativeModuleLoader::CompileAndCall(). With this we no longer need to mess with the error decoration and handling any more - there is no point in handling the JS error occurred during bootstrapping by ourselves, we should just crash or let the VM handle it. PR-URL: https://github.com/nodejs/node/pull/24775 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/24812 Reviewed-By:
-
Rich Trott authored
Editing a sentence I missed simplifying in the last pass on that section. PR-URL: https://github.com/nodejs/node/pull/24807 Reviewed-By:
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/24783 Reviewed-By:
-
Sam Roberts authored
Fill in correct pr-url: value in the YAML changelog that was missing from f512f5ea. The stanza was also sorted in the wrong order, most recent is supposed to be in the beginning of the changes, not the end. PR-URL: https://github.com/nodejs/node/pull/24759 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/24751 Reviewed-By:
-
- Dec 03, 2018
-
-
Rod Vagg authored
Notable Changes: This is a patch release to address a bad backport of the fix for "Slowloris HTTP Denial of Service" (CVE-2018-12122). Node.js 6.15.0 misapplies the headers timeout to an entire keep-alive HTTP session, resulting in prematurely disconnected sockets. PR-URL: https://github.com/nodejs/node/pull/24803 Refs: https://github.com/nodejs/node/pull/24796 Refs: https://github.com/nodejs/node/issues/24760 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/24749 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Ruben Bridgewater authored
Comparing sparse arrays did not work properly. That is fixed and tests were added to verify that everything works as expected. This had an impact on `util.isDeepStrictEqual()` and `assert.deepStrictEqual()` and their counterpart `assert.notDeepStrictEqual()`. PR-URL: https://github.com/nodejs/node/pull/24749 Reviewed-By:
-
Ruben Bridgewater authored
Loose map comparison had an logic error. It will now be properly compared. PR-URL: https://github.com/nodejs/node/pull/24749 Reviewed-By:
-
Ruben Bridgewater authored
The `util.format()` behavior changed recently. Add the changes entry to document the new BigInt behavior. PR-URL: https://github.com/nodejs/node/pull/24758 Reviewed-By:
-
Ruben Bridgewater authored
IDEs like vscode use older Node.js versions that do not yet support the new try catch syntax. This makes sure eslint continues to work in these IDEs as before. PR-URL: https://github.com/nodejs/node/pull/24753 Reviewed-By:
-
Ruben Bridgewater authored
The current internal isError function checked the toString value instead of using the more precise `util.types.isNativeError()` check. The `instanceof` check is not removed due to possible errors that are not native but still an instance of Error. PR-URL: https://github.com/nodejs/node/pull/24746 Reviewed-By:
-
Ruben Bridgewater authored
The `console` functions rely on the `util.format()` behavior. It did not follow the whatwg spec when it comes to symbols in combination with the %d, %i and %f format specifiers. Using a symbol argument in combination with one of these specifiers resulted in an error instead of returning `'NaN'`. This is now fixed by this patch. PR-URL: https://github.com/nodejs/node/pull/23708 Refs: https://console.spec.whatwg.org/#formatter Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
timothy searcy authored
This commit adds a test for the validateArguments function in TextDecoder. PR-URL: https://github.com/nodejs/node/pull/24736 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/24745 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Sam Roberts authored
Add an error code property to invalid `secureProtocol` method exceptions. PR-URL: https://github.com/nodejs/node/pull/24729 Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/24719 Refs: https://github.com/nodejs/node/issues/24645 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/24748 Refs: https://github.com/nodejs/node/pull/24486 Reviewed-By:
-
Ruben Bridgewater authored
While running the test suite the progress bar shows former line endings if the new line is shorter than the former line. The length was calculated without the line ending. It is now an empty string to prevent the off by one error instead of using extra whitespace. PR-URL: https://github.com/nodejs/node/pull/24748 Refs: https://github.com/nodejs/node/pull/24486 Reviewed-By:
-
Matteo Collina authored
Fixes: https://github.com/nodejs/node/issues/24470 PR-URL: https://github.com/nodejs/node/pull/24723 Reviewed-By:
-
Fedor Indutny authored
`http_parser_execute(..., nullptr, 0)` returns either `0` or `1`. The expectation is that no error must be returned if it is `0`, and if it is `1` - a `Error` object must be returned back to user. The introduction of `llhttp` and the refactor that happened during it accidentally removed the error-returning code. This commit reverts it back to its original state. Fix: #24585 PR-URL: https://github.com/nodejs/node/pull/24738 Reviewed-By:
-
- Dec 02, 2018
-
-
Joyee Cheung authored
To help debugging the flake with the log from the CI. PR-URL: https://github.com/nodejs/node/pull/24720 Refs: https://github.com/nodejs/node/issues/24403 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Gerhard Stoebich authored
document that incoming cookie headers are joined using '; '. PR-URL: https://github.com/nodejs/node/pull/24740 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Joyee Cheung authored
Move the wrapping of the inspector console in a separate file for clarity. In addition, save the original console from the VM explicitly via an exported property `require('internal/console/inspector').consoleFromVM` that `require('inspector').console` can alias to it later, instead of hanging the original console onto `per_thread.js` during bootstrap and counting on that `per_thread.js` only gets evaluated once and gets cached. PR-URL: https://github.com/nodejs/node/pull/24709 Reviewed-By: -
Joyee Cheung authored
Since we do not actually use the Console constructor to instantiate the global console, move the two piece of code into two different JS files for clarity, and make console.js a mere re-export of the global console. The hope is to make the global console, a namespace, more web-compatible while keeping the Console constructor available for backwards compatibility. PR-URL: https://github.com/nodejs/node/pull/24709 Reviewed-By:
-
Joyee Cheung authored
This is a broken commit: it's here so that git interpret this as a file move and preserve most of the history of the Console constructor. PR-URL: https://github.com/nodejs/node/pull/24709 Reviewed-By:
-
