- Nov 18, 2019
-
-
Richard Lau authored
Building Node.js without a ccache cache takes longer than the 50 minute Travis time limit for jobs for public repositories. To mitigate this we added a job to compile V8 on the basis that in the worst case it would complete within 50 minutes and provide a cache that could be used by a restarted `Compile Node.js` job. Recent PRs have exceeded the 50 minute time limit for the `Compile V8` job. When Travis times out a build the cache is not stored. This commit drops the `Compile V8` job and adds a manual timeout to the `Compile Node.js` job which will allow the cache to be stored and used in restarts of the job. PR-URL: https://github.com/nodejs/node/pull/30469 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
- Nov 17, 2019
-
-
Artem Maksimov authored
If there is a file 'path' in the root dir, the test will fail with the 'ENOTDIR' instead of 'ENOENT'. Change path to something more unlikely. PR-URL: https://github.com/nodejs/node/pull/30280 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Nikolay Krashnikov authored
PR-URL: https://github.com/nodejs/node/pull/30314 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
nathias authored
PR-URL: https://github.com/nodejs/node/pull/30444 Reviewed-By:
-
Kerry Mahne authored
Changed outdated var to const in the test file repl-unexpected-token-recoverable.js PR-URL: https://github.com/nodejs/node/pull/30434 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
SoulMonk authored
PR-URL: https://github.com/nodejs/node/pull/30433 Reviewed-By:
-
Duncan Healy authored
PR-URL: https://github.com/nodejs/node/pull/30446 Reviewed-By:
-
Xavier Redondo authored
PR-URL: https://github.com/nodejs/node/pull/30445 Reviewed-By:
-
dnlup authored
PR-URL: https://github.com/nodejs/node/pull/30450 Reviewed-By:
-
Susana Ferreira authored
PR-URL: https://github.com/nodejs/node/pull/30439 Reviewed-By:
-
Kenza Houmani authored
PR-URL: https://github.com/nodejs/node/pull/30440 Reviewed-By:
-
Geoffrey Booth authored
PR-URL: https://github.com/nodejs/node/pull/30512 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/30501 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
-
Geoffrey Booth authored
Co-Authored-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: https://github.com/nodejs/node/pull/30345 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
garygsc authored
PR-URL: https://github.com/nodejs/node/pull/30481 Refs: https://github.com/nodejs/node/pull/22879 Reviewed-By:
-
xefimx authored
PR-URL: https://github.com/nodejs/node/pull/30281 Reviewed-By:
-
Geoffrey Booth authored
PR-URL: https://github.com/nodejs/node/pull/30495 Reviewed-By:
-
- Nov 16, 2019
-
-
mkdorff authored
PR-URL: https://github.com/nodejs/node/pull/30393 Reviewed-By:
-
- Nov 15, 2019
-
-
Luigi Pinca authored
On some platforms the `'end'` event might not be emitted because the socket could be destroyed by the other peer while the client is still sending the data triggering an error. Use the `'close'` event instead. PR-URL: https://github.com/nodejs/node/pull/30360 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Luigi Pinca authored
Document that returned `pathname` is now `/` when the URL to parse has no path and the protocol scheme is`ws:` or `wss:`. PR-URL: https://github.com/nodejs/node/pull/30348 Fixes: https://github.com/nodejs/node/issues/30154 Refs: https://github.com/nodejs/node/pull/26941 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Kenza Houmani authored
PR-URL: https://github.com/nodejs/node/pull/30448 Reviewed-By:
-
Rich Trott authored
Mostly, this replaces "It is recommended to do X" with "Do X." PR-URL: https://github.com/nodejs/node/pull/30458 Reviewed-By:
-
Rich Trott authored
The statement that tests for tier 1 platforms are run on multiple variants is not true. We usually only run on one variant of macOS. Remove "multiple", which simplifies and clarifies the statements anyway. PR-URL: https://github.com/nodejs/node/pull/30366 Reviewed-By:
-
- Nov 14, 2019
-
-
Rich Trott authored
The "maintenance is supported by" stuff in BUILDING.md is unclear. It seems unnecessary so I propose removing it. I don't understand what it means to, in this context, support maintenance. Does it mean that you simply do the maintenance? Does that mean it really just means "maintain"? Do we really mean that we mantain support, rather than support maintenance? That information does not seem necessary to include. I'm not sure it's meaningful. With (for example) Windows, is it accurate to say that the Node.js core team maintains support for it? Or is it accurate to say that support is maintaned by smaller groups or individuals within the Node.js core team? Both could be considered accurate. So is the difference meaningful? I think the more important elements of determinig tier support are the other listed elements. PR-URL: https://github.com/nodejs/node/pull/30365 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/30249 Fixes: https://github.com/nodejs/node/issues/30237 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/29053 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/29053 Reviewed-By:
-
- Nov 13, 2019
-
-
Albert Wang authored
Fixes: https://github.com/nodejs/node/issues/30211 PR-URL: https://github.com/nodejs/node/pull/30356 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
-
Luigi Pinca authored
Add documentation for the `lookup` option. PR-URL: https://github.com/nodejs/node/pull/30353 Fixes: https://github.com/nodejs/node/issues/30171 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Simon Schick authored
PR-URL: https://github.com/nodejs/node/pull/30346 Reviewed-By:
-
Grigoriy Levanov authored
Replaces Object.assign with spread where object is simply cloned PR-URL: https://github.com/nodejs/node/pull/30306 Reviewed-By:
-
Michael Dawson authored
* Add missing N-API version info * Fix N-API version info for napi_extended_error_info PR-URL: https://github.com/nodejs/node/pull/30254 Reviewed-By:
-
Vse Mozhet Byt authored
* Fix formatting. * Fix list numbering. * Unify abbreviation casing. * Use an uppercased constructor in a hypothetic code example. * Fix typos. * Fix sorting in sections and references. PR-URL: https://github.com/nodejs/node/pull/30341 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/29866 Reviewed-By:
-
- Nov 12, 2019
-
-
Daniil Pletnev authored
PR-URL: https://github.com/nodejs/node/pull/30308 Reviewed-By:
-
Vadim Gorbachev authored
PR-URL: https://github.com/nodejs/node/pull/30305 Reviewed-By:
-
telenord authored
PR-URL: https://github.com/nodejs/node/pull/30288 Reviewed-By:
-
alexahdp authored
PR-URL: https://github.com/nodejs/node/pull/30287 Reviewed-By:
-
telenord authored
PR-URL: https://github.com/nodejs/node/pull/30285 Reviewed-By:
-
Anna Henningsen authored
V8 deprecates `GetContents()` in favour of `GetBackingStore()`. Update our code to reflect that. V8 also deprecates `Externalize()` and `IsExternal()`; we should be able to remove all usage of this once V8 8.0 is there. PR-URL: https://github.com/nodejs/node/pull/30339 Refs: https://github.com/v8/v8/commit/bfe3d6bce734e596e312465e207bcfd55a59fe34 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
