- May 08, 2020
-
-
szTheory authored
PR-URL: https://github.com/nodejs/node/pull/33211 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
osher authored
Ran into #30189, solved by this comment: https://github.com/nodejs/node/issues/30189#issuecomment-548250793 Refs: https://github.com/nodejs/node/issues/30189 PR-URL: https://github.com/nodejs/node/pull/33174 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Christian Clauss <cclauss@me.com>
-
Karol Walasek authored
PR-URL: https://github.com/nodejs/node/pull/33179 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
Nikolai Vavilov authored
It returns zero-filled memory since v8.0.0. PR-URL: https://github.com/nodejs/node/pull/33198 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
himself65 authored
This enables loading this module during early bootstrapping. PR-URL: https://github.com/nodejs/node/pull/33212 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Pranshu Srivastava authored
PR-URL: https://github.com/nodejs/node/pull/33217 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/33224 Reviewed-By:
-
Simen Bekkhus authored
PR-URL: https://github.com/nodejs/node/pull/33230 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/33235 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/33248 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Andrey Pechkurov authored
AsyncWrap is a private API and should not be mentioned in the documentation. PR-URL: https://github.com/nodejs/node/pull/33249 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
James M Snell authored
Signed-off-by:
Mathias Buus <mathiasbuus@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
- May 07, 2020
-
-
Gabriel Schulhof authored
Adds a test to ensure that napi_get_value_uint32 returns 0xffffffff for -1. Re: https://github.com/nodejs/node/issues/33117 Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com>
-
Robert Nagy authored
Currently from will eagerly buffer up items which means that errors are also eagerly encountered and items which are buffer when an error occurs will be discarded, which is inconsistent with how generators work. Fixes: https://github.com/nodejs/node/issues/29428 PR-URL: https://github.com/nodejs/node/pull/33201 Reviewed-By:
-
Michael Dawson authored
Fixes: https://github.com/nodejs/node/issues/33153 Change documentation to make async_resource required as opposed to optional in napi-async_init. Changes over time mean this parameter is required for proper operation of async hooks (which are still experimental). This changes the documentation to document what callers should do. We are doing this only in the doc in order to avoid a breaking change in N-API. We could create a new version of the method for which the parametrer is enforced as mandatory but we should only do that once async hooks is no longer experimental. In that case we could deprecate (but not remove this version of the method). Signed-off-by:
Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33181 Reviewed-By:
-
James M Snell authored
The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
- May 06, 2020
-
-
James M Snell authored
Allow the AsyncWrap to be properly detached. Extracted from the [QUIC PR](https://github.com/nodejs/node/pull/32379 ). Signed-off-by:
-
Richard Lau authored
This reverts commit e08ac095. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Richard Lau authored
This reverts commit babeb58c. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Joyee Cheung authored
Instead of passing them through the data bound to function templates, store references to them in a list embedded inside the context. This makes the function templates more context-independent, and makes it possible to embed binding data in non-main contexts. Co-authored-by:
-
Michaël Zasso authored
Notable changes: * Track function calls with `assert.CallTracker` (experimental). https://github.com/nodejs/node/pull/31982 * Added a `groupIndentation` option to the `Console` constructor. https://github.com/nodejs/node/pull/32964 PR-URL: https://github.com/nodejs/node/pull/33232
-
Myles Borins authored
If package authors don't explicitly include all previously supported entry points introducing package.exports will be a Semver-Major change. Add a warning about this behavior and offer two potential solutions for module authors. Refs: https://github.com/then/is-promise/issues/20 PR-URL: https://github.com/nodejs/node/pull/33074 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
-
- May 05, 2020
-
-
John Leidegren authored
Fixes: https://github.com/nodejs/node/issues/29394 Refs: https://github.com/nodejs/node/pull/33167#issuecomment-622102450 PR-URL: https://github.com/nodejs/node/pull/33190 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/33194 Reviewed-By:
-
Julian Duque authored
PR-URL: https://github.com/nodejs/node/pull/33185 Reviewed-By:
Adrian Estrada <edsadr@gmail.com> Reviewed-By:
-
- May 04, 2020
-
-
Ruben Bridgewater authored
Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by:
-
Robert Nagy authored
If socket creation failed then an error would be emitted on the client request object, but not 'close' nor would destroyed be set to true. PR-URL: https://github.com/nodejs/node/pull/33178 Reviewed-By:
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/33151 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/33203 Reviewed-By:
-
Daniele Belardi authored
Run CommonJS resolver only if `error.code` is ERR_MODULE_NOT_FOUND. Avoid using absolute paths in hint by: * using a parent-relative path if the specifier is a relative path * using a `pkg/x.js` format if the specifier is bare (e.g. `pkg/x`) PR-URL: https://github.com/nodejs/node/pull/31906 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Robert Nagy authored
unshifting into an empty array is the same as creating a new array. PR-URL: https://github.com/nodejs/node/pull/33200 Reviewed-By:
-
- May 03, 2020
-
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/33187 Reviewed-By:
-
Adrian Estrada authored
PR-URL: https://github.com/nodejs/node/pull/33180 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
- May 02, 2020
-
-
Rich Trott authored
New version of remark-preset-lint-node includes prohibited string entry accidentally removed in the last version. PR-URL: https://github.com/nodejs/node/pull/33157 Reviewed-By:
-
Kevin Locke authored
This function was added by nodejs/node#15663, but was never documented. This commit documents it. PR-URL: https://github.com/nodejs/node/pull/33092 Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com>
-
Juan José Arboleda authored
Collaborators won't need to run CI on documentation-only changes. PR-URL: https://github.com/nodejs/node/pull/33101 Reviewed-By:
-
- May 01, 2020
-
-
白一梓 authored
Change `64kb` to `64KB` in `stream.md` PR-URL: https://github.com/nodejs/node/pull/31561 Reviewed-By:
-
Owen Smith authored
Previous location of setting the timeout would override behaviour of custom HttpAgents' keepSocketAlive. Moving it into the default keepSocketAlive allows it to interoperate with custom agents. Fixes: https://github.com/nodejs/node/issues/33111 PR-URL: https://github.com/nodejs/node/pull/33127 Reviewed-By:
-
Anna Henningsen authored
Running tests with an ASAN build leads to increased memory usage, rendering the memory usage assumptions in the test invalid. Refs: https://github.com/nodejs/node/pull/32776#issuecomment-620407014 PR-URL: https://github.com/nodejs/node/pull/33129 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Anna Henningsen authored
Original commit message: [arraybuffer] Clean up BackingStore even if it pointer to nullptr For a zero-length BackingStore allocation, it is valid for the underlying memory to be a null pointer. However, some cleanup is still necessary, since the BackingStore may hold a reference to the allocator itself, which needs to be released when destroying the `BackingStore` instance. Change-Id: I1f168079d39e4592d2fde31fbe5f705586690e85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169646 Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67420} Refs: https://github.com/v8/v8/commit/e29c62b7485462c1ce8f4129b26e7f7a4d4b193c PR-URL: https://github.com/nodejs/node/pull/33125 Reviewed-By:
-
