- Sep 20, 2019
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/29492 Reviewed-By:
Jan Krems <jan.krems@gmail.com>
-
- Sep 19, 2019
-
-
Lucas Holmquist authored
Refs: https://github.com/nodejs/node/pull/29535 This PR replaces the instances of var with let/const. PR-URL: https://github.com/nodejs/node/pull/29575 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Sam Roberts authored
Original commit message: Make code generator python3.7 compatible (async keyword). Change-Id: Ifcd8b8cb1de60a007c7bbd4564d7869e83cb7109 Fixes: https://github.com/nodejs/node/issues/29548 Refs: - https://github.com/nodejs/node/issues/29548#issuecomment-531717985 - https://github.com/nodejs/node/pull/29520 - https://github.com/nodejs/node/pull/29340 - https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351 - https://chromium.googlesource.com/deps/inspector_protocol/+/35c6d4d0d80b42d81bd00bcb1eb2b1093c80ed0a PR-URL: https://github.com/nodejs/node/pull/29585 Refs: https://github.com/nodejs/node/pull/29520 Reviewed-By:Christian Clauss <cclauss@me.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Anna Henningsen authored
This allows us to remove OS-dependent code. confidence improvement accuracy (*) (**) (***) process/bench-env.js operation='delete' n=1000000 3.57 % ±10.86% ±14.46% ±18.85% process/bench-env.js operation='enumerate' n=1000000 *** -14.06 % ±7.46% ±9.94% ±12.96% process/bench-env.js operation='get' n=1000000 -7.97 % ±11.80% ±15.70% ±20.45% process/bench-env.js operation='query' n=1000000 -1.32 % ±8.38% ±11.17% ±14.58% process/bench-env.js operation='set' n=1000000 -0.98 % ±9.63% ±12.81% ±16.68% The drop in enumeration performance is likely due to the large number of extra allocations that libuv performs. However, enumerating process.env should generally not be a hot path in most applications. PR-URL: https://github.com/nodejs/node/pull/29188 Reviewed-By: -
Anna Henningsen authored
Benchmark different types of operations and make results comparable by normalizing process.env for enumeartion. PR-URL: https://github.com/nodejs/node/pull/29188 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/29586 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
- Sep 18, 2019
-
-
Vse Mozhet Byt authored
* Add missing types. * Fix function signatures. * Fix typos. * Unify comment style. * Fix ASCII sorting of bottom references. PR-URL: https://github.com/nodejs/node/pull/29577 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Jeremiah Senkpiel authored
Due to how bootstrap/loaders.js itself is loaded and invoked, stacktraces from it are munged and no longer point back to the error source. That resulted in the following unhelpful error if an internal module was missing or misnamed: ``` internal/bootstrap/loaders.js:190 return mod.compile(); ^ TypeError: Cannot read property 'compile' of undefined ``` This changes that to at least print the id that was attempted to be loaded: ``` internal/bootstrap/loaders.js:189 if (!mod) throw new TypeError(`Missing internal module '${id}'`); ^ TypeError: Missing internal module 'internal/a' ``` PR-URL: https://github.com/nodejs/node/pull/29593 Reviewed-By:Gus Caplan <me@gus.host> Reviewed-By:
-
gcr authored
my legal name changed, so i'm removing lingering references to my old name from the Internet. PR-URL: https://github.com/nodejs/node/pull/29597 Reviewed-By:
-
Giorgos Ntemiris authored
If the 'host' agent header is an array or other non-string value, throw. PR-URL: https://github.com/nodejs/node/pull/29568 Fixes: https://github.com/nodejs/node/issues/29408 Reviewed-By:
-
Rich Trott authored
A new version of remark-preset-lint-node adds linting for unordered list style. PR-URL: https://github.com/nodejs/node/pull/29594 Reviewed-By:
-
Rich Trott authored
To confirm with upcoming markdown lint rule, use `*` for unordered lists. PR-URL: https://github.com/nodejs/node/pull/29594 Reviewed-By:
-
Javier Ledezma authored
PR-URL: https://github.com/nodejs/node/pull/29571 Fixes: https://github.com/nodejs/node/issues/28622 Reviewed-By:
-
zhangyongsheng authored
PR-URL: https://github.com/nodejs/node/pull/29555 Fixes: https://github.com/nodejs/node/issues/29424 Reviewed-By:
-
Guy Bedford authored
This reintroduces the dot main in exports as discussed in the previous Node.js modules meeting. The implementation includes both CommonJS and ES module resolution with the associated documentation and resolver specification changes. In addition to the dot main, "exports" as a string or direct fallback array is supported as well. Co-Authored-By:
Geoffrey Booth <GeoffreyBooth@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/29494 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
claudiahdz authored
PR-URL: https://github.com/nodejs/node/pull/29430 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/29566 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Levhita authored
napi_create_date and napi_get_date_value ignore leap seconds as per ECMAScript spec that follows POSIX spec for time, comments added to the documentation where added fo clarify it. PR-URL: https://github.com/nodejs/node/pull/29569 Fixes: https://github.com/nodejs/node/issues/29439 Reviewed-By:
-
Geoffrey Booth authored
* organize sections more hierarchically * recommend always including "type" field, per 2019-06-19 meeting Refs: https://github.com/nodejs/modules/issues/342#issuecomment-503733187 * expand discussion of publishing cjs/esm packages PR-URL: https://github.com/nodejs/node/pull/29497 Reviewed-By:
-
Anna Henningsen authored
Using `console.log()` likely interferes with the functionality of the test, which also checks the interaction between inspector and `console.log()` as part of the test. Using `process._rawDebug()` solves that issue. Refs: https://github.com/nodejs/node/pull/28870 Refs: https://github.com/nodejs/node/pull/29582 PR-URL: https://github.com/nodejs/node/pull/29588 Reviewed-By:
-
Denis Zavershinskiy authored
It fix 2 issues in provided Loader hooks examples: 1. Original ``new URL(`${process.cwd()}/`, 'file://');`` is not cross-platform, it gives wrong URL on windows 2. Based on `CHECK` in ModuleWrap::Resolve (node 12.9.1, https://github.com/nodejs/node/blob/v12.9.1/src/module_wrap.cc#L1132) the 2nd parameter should be a `string`, not an `URL` object PR-URL: https://github.com/nodejs/node/pull/29373 Reviewed-By:
-
- Sep 17, 2019
-
-
Nick Schonning authored
Convert to asterisks when there are mixed styles in document. Addresses Markdownlint MD004 rule PR-URL: https://github.com/nodejs/node/pull/29516 Reviewed-By:
-
Eugene Ostroukhov authored
This API is designed to enable worker threads use Inspector protocol on main thread (and other workers through NodeWorker domain). Note that worker can cause dead lock by suspending itself. I will work on a new API that will allow workers to be hidden from the inspector. Fixes: https://github.com/nodejs/node/issues/28828 PR-URL: https://github.com/nodejs/node/pull/28870 Reviewed-By:
Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
- Sep 16, 2019
-
-
Aditya authored
PR-URL: https://github.com/nodejs/node/pull/27843 Reviewed-By:
-
Robert Nagy authored
This tries to simplify the code and make it easier to understand. Took me a while to get my head around the previous implementation. Also minor perf improvement. PR-URL: https://github.com/nodejs/node/pull/28700 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
antsmartian authored
PR-URL: https://github.com/nodejs/node/pull/29400 Reviewed-By:
-
zhangyongsheng authored
PR-URL: https://github.com/nodejs/node/pull/29553 Refs: https://github.com/eslint/eslint/releases/tag/v6.4.0 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com>
-
Anna Henningsen authored
Previously, leaving the exception lying around would leave the JS engine in an invalid state, as it was not expecting exceptions to be thrown from the C++ `PromiseRejectCallback`, and lead to hard crashes under some conditions (e.g. with coverage enabled). PR-URL: https://github.com/nodejs/node/pull/29513 Reviewed-By:
-
- Sep 15, 2019
-
-
Kamil Rytarowski authored
Detected on NetBSD/amd64. Fixes: https://github.com/nodejs/node/issues/29536 PR-URL: https://github.com/nodejs/node/pull/29541 Reviewed-By:
-
- Sep 14, 2019
-
-
Lucas Holmquist authored
* Adds `let` to a variable declaration in a for loop that wasn't using anything. * Declare the for initial expression in the for loop. * Remove hoisted variables for loops. PR-URL: https://github.com/nodejs/node/pull/29535 Reviewed-By:
-
Chetan Karande authored
PR-URL: https://github.com/nodejs/node/pull/29502 Refs: https://github.com/nodejs/node/issues/445 Reviewed-By:
-
Kirill Fomichev authored
Some of the milestones was removed in PR #21247 but entries not removed from function for inspect PerformanceNodeTiming. PR-URL: https://github.com/nodejs/node/pull/29528 Reviewed-By:
-
Anna Henningsen authored
Add function encodeInto to TextEncoder, and add MessageChannel to the encodeInto.any.js test. Fixes: https://github.com/nodejs/node/issues/28851 Fixes: https://github.com/nodejs/node/issues/26904 Refs: https://github.com/nodejs/node/pull/28862 Co-authored-by:
AtticusYang <yyongtai@163.com> PR-URL: https://github.com/nodejs/node/pull/29524 Reviewed-By:
-
- Sep 13, 2019
-
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/29489 Reviewed-By:
-
Tobias Nießen authored
The label acts as the "L" input to the RSA-OAEP algorithm. PR-URL: https://github.com/nodejs/node/pull/29489 Reviewed-By:
-
Michael Dawson authored
Refs: https://github.com/nodejs/TSC/issues/718 PR-URL: https://github.com/nodejs/node/pull/29546 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Michael Dawson authored
refs: https://github.com/nodejs/TSC/issues/746 PR-URL: https://github.com/nodejs/node/pull/29545 Refs: https://github.com/nodejs/TSC/issues/746 Reviewed-By:
-
Steven R. Loomis authored
The ICU alias table format changed in https://unicode-org.atlassian.net/browse/ICU-20627 Because of this, iculslocs.cc needs to handle URES_TABLE format contents in the res_index.txt file. PR-URL: https://github.com/nodejs/node/pull/29523 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
Anna Henningsen authored
The example states this already, but I would have expected this to be part of the description, too. PR-URL: https://github.com/nodejs/node/pull/29482 Reviewed-By:
-
Devendra Satram authored
Modified RealEnvStore::Get, Set, Query and Delete methods to use libuv methods environment variables operations instead of using os specific logic and switches. Fixes: https://github.com/nodejs/node/issues/27211 Refs: http://docs.libuv.org/en/v1.x/misc.html PR-URL: https://github.com/nodejs/node/pull/27310 Reviewed-By:
-
