Commit e095e645 authored by Anna Henningsen's avatar Anna Henningsen Committed by Daniel Bevenius
Browse files

src: print exceptions from PromiseRejectCallback

Previously, leaving the exception lying around would leave the JS
engine in an invalid state, as it was not expecting exceptions to
be thrown from the C++ `PromiseRejectCallback`, and lead to hard
crashes under some conditions (e.g. with coverage enabled).

PR-URL: https://github.com/nodejs/node/pull/29513


Reviewed-By: default avatarGus Caplan <me@gus.host>
Reviewed-By: default avatarBenjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
parent 233cdb64
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment