- Mar 01, 2021
-
-
Rich Trott authored
Avoid abbreviations and jargon. PR -> pull request, repo -> repository, etc. PR-URL: https://github.com/nodejs/node/pull/37524 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
- Feb 28, 2021
-
-
Rich Trott authored
Create a utils module for isIterable(), isReadable(), and isStream(). PR-URL: https://github.com/nodejs/node/pull/37508 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Michael Dawson authored
Change the top level docs to use HEAD in links Signed-off-by:
Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/37494 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37506 Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37507 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Anna Henningsen authored
When a Worker is terminated, its own handle and the public `MessagePort` are `.ref()`’ed, so that all relevant events, including the `'exit'` events, end up being received. However, this is problematic if messages end up being queued from the Worker between the beginning of the `.terminate()` call and its completion, and there are no `'message'` event handlers present at that time. In that situation, currently the messages would not end up being processed, and since the MessagePort is still `.ref()`’ed, it would keep the event loop alive indefinitely. To fix this: - Make sure that all messages end up being received by `drainMessagePort()`, including cases in which the port had been stopped (i.e. there are no `'message'` listeners) and cases in which we exceed the limit for messages being processed in one batch. - Unref the Worker’s internal ports manually after the Worker has exited. Either of these solutions should be solving this on its own, but I think it makes sense to make sure that both of them happen during cleanup. PR-URL: https://github.com/nodejs/node/pull/37319 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
- Feb 27, 2021
-
-
Nitzan Uziely authored
Fix AbortSignal in Spawn which doesn't actually abort the process, and fork can emit an AbortError even if the process was already exited. Add documentation For killSignal. Fixes: https://github.com/nodejs/node/issues/37273 PR-URL: https://github.com/nodejs/node/pull/37325 Reviewed-By:
-
James M Snell authored
Signed-off-by:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
- Feb 26, 2021
-
-
Antoine du Hamel authored
Fixes: https://github.com/nodejs/node/issues/37492 PR-URL: https://github.com/nodejs/node/pull/37501 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37433 Reviewed-By:
-
Nitzan Uziely authored
Fix an issue where the writeFile does not close the file when the signal is aborted. PR-URL: https://github.com/nodejs/node/pull/37402 Reviewed-By:
-
Nitzan Uziely authored
Fix an issue in writeFile where a file is opened, and not closed if the abort signal is aborted after the file was opened but before writing began. PR-URL: https://github.com/nodejs/node/pull/37393 Reviewed-By:
-
marsonya authored
PR-URL: https://github.com/nodejs/node/pull/37497 Reviewed-By:
-
Nitzan Uziely authored
PR-URL: https://github.com/nodejs/node/pull/37354 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/37308 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Mary Marchini <oss@mmarchini.me> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Filip Skokan authored
PR-URL: https://github.com/nodejs/node/pull/37305 Reviewed-By:
-
Antoine du Hamel authored
Using `push` and `unshift` methods is more performant than reassigning a new array created with `concat`. PR-URL: https://github.com/nodejs/node/pull/37239 Reviewed-By:
-
Vít Ondruch authored
There is no reason to hide FIPS functionality behind build flags. OpenSSL always provide the information about FIPS availability via `FIPS_mode()` function. This makes the user experience more consistent, because the OpenSSL library is always queried and the `crypto.getFips()` always returns OpenSSL settings. Fixes #34903 PR-URL: https://github.com/nodejs/node/pull/36341 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
James M Snell authored
`fs.ftruncate`, `fsPromises.truncate`, and `fsPromises.ftruncate` all adjust negative lengths to 0 before invoking the system call. `fs.truncate()` was the one outlier. This "fixes" https://github.com/nodejs/node/issues/35632 but in the opposite direction than discussed in the issue -- specifically by removing an EINVAL error from one function rather than adding it to another. Signed-off-by:
-
James M Snell authored
We likely cannot ever deprecate process.nextTick, but we can start steering people towards queueMicrotask for most cases. Signed-off-by:
Gus Caplan <me@gus.host> Reviewed-By:
-
- Feb 25, 2021
-
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/37496 Reviewed-By:
-
Richard Lau authored
Original commit message: [torque] Don't replace unmodified empty files To improve incremental builds. Bug: v8:7793 Change-Id: I6990a97e058d22d34acd1f609167cd30ca7518ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596789 Reviewed-by:Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#72053} Refs: https://github.com/v8/v8/commit/373f4ae739eeae0e4d2224b15002be35f1470312 PR-URL: https://github.com/nodejs/node/pull/37505 Fixes: https://github.com/nodejs/node/issues/37368 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
ttzztztz authored
PR-URL: https://github.com/nodejs/node/pull/37425 Fixes: https://github.com/nodejs/node/issues/37395 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37330 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/commit/1e69cdd95bad505ec5de1ddca9e58eee8cd9383f PR-URL: https://github.com/nodejs/node/pull/37330 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37330 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [aarm64] Fix GetSharedLibraryAddresses This patch fixes a segmentation fault which occurs when using `--prof` flag on a Darwin ARM64 architecture. See https://github.com/nodejs/node/issues/36656 Change-Id: Idc3ce6c8fd8a24f76f1b356f629e37340045b51e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609413 Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#72886} Refs: https://github.com/v8/v8/commit/8957d4677aa794c230577f234071af0dadb88f7b PR-URL: https://github.com/nodejs/node/pull/37330 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [cppgc]: Fix build on msvc Fixes compilation with msvc 2019 toolchain. See: https://github.com/nodejs/node/pull/37330#issuecomment-783000812 Change-Id: I3b658d9ef49889c0a0467a1146e8d16b50fca65d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2711152 Reviewed-by: -
Matin Zadehdolatabad authored
Original commit message: [mac][wasm] Work around MacOS 11.2 code page decommit failures MacOS 11.2 refuses to set "no access" permissions on memory that we previously used for JIT-compiled code. It is still unclear whether this is WAI on the part of the kernel. In the meantime, as a workaround, we use madvise(..., MADV_FREE_REUSABLE) instead of mprotect(..., NONE) when discarding code pages. This is inspired by what Chromium's gin platform does. Fixed: v8:11389 Change-Id: I866586932573b4253002436ae5eee4e0411c45fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2679688 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Ash Cripps <acripps@redhat.com>
-
Benjamin Coe authored
Original commit message: [coverage] optional chaining coverage Implement coverage tracking for optional chains. Bug: v8:10060 Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013 Reviewed-by:Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Gus Caplan <snek@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Benjamin Coe <bencoe@google.com> Cr-Commit-Position: refs/heads/master@{#72075} Refs: https://github.com/v8/v8/commit/fe191e8d05ccfa740432f56d34b1ff2d32265a8d PR-URL: https://github.com/nodejs/node/pull/36956 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [heap] Add proper rebind support to StrongRootBlockAllocator MSVC's STL in debug mode rebinds the allocator passed to vectors to allocate helper structures, so we need StrongRootBlockAllocator to have proper rebind support rather than assuming it always rebinds to Address. Bug: v8:11241 Change-Id: I15688e43fe2c71ec4ff0c287a03e36ca57427417 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622915 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Michaël Zasso authored
Original commit message: [heap] Fix DCHECK in TransitionArrayNeedsCompaction The dead target check in TransitionArrayNeedsCompaction, confirming that Smi (uninitialized) targets imply that no other target is dead, has to additionally support Smi entries. Bug: v8:11305 Change-Id: I6f3fa9e7420b1bd0a64a25dae670f439e3f41162 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622914 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: -
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/37330 Reviewed-By:
-
cjihrig authored
std::stod() on SmartOS does not currently handle hex strings. This commit provides a workaround based on strtol() until proper stod() support is available. PR-URL: https://github.com/nodejs/node/pull/37330 Reviewed-By:
-
Jiawen Geng authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Matheus Marchini authored
Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Joao Reis authored
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Ujjwal Sharma authored
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
