- Feb 17, 2017
-
-
Roman Reiss authored
Try and find a suitable python2 binary and suggest it to the user in case they start the configure script with a incompatible version. PR-URL: https://github.com/nodejs/node/pull/11375 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Jackson Tian authored
Move the anonymous class out of setupChannel to clarify code. PR-URL: https://github.com/nodejs/node/pull/11147 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Rich Trott authored
Add documentation for `common.expectsError()` to `test/README.md`. PR-URL: https://github.com/nodejs/node/pull/11382 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
* match full error message in assert.throws() * wrapped function -> .bind() PR-URL: https://github.com/nodejs/node/pull/11388 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Rich Trott authored
test-net-connect-local-error can fail with messages that report `AssertionError: undefined === 12346`. Unfortunately, this doesn't provide sufficient information to identify what went wrong with the test. Increase information provided. PR-URL: https://github.com/nodejs/node/pull/11393 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/11236 Ref: https://github.com/whatwg/url/pull/229 Reviewed-By:
Timothy Gu <timothygu99@gmail.com>
-
cjihrig authored
This commit tests the scenario where a dgram socket closes during a call to Socket#bind(). PR-URL: https://github.com/nodejs/node/pull/11383 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Sam Roberts authored
Fix: https://github.com/nodejs/node/pull/11334 PR-URL: https://github.com/nodejs/node/pull/11350 Reviewed-By:
-
Vse Mozhet Byt authored
This commit adds a guard against an out of bounds access of arguments, and replaces another use of arguments with a named function parameter. Refs: https://github.com/nodejs/node/issues/10323 PR-URL: https://github.com/nodejs/node/pull/11242 Reviewed-By:
-
Sam Roberts authored
process.stdout, process.stderr, and console.log() and console.error() which use the process streams, are usually synchronous. Warn about this, and clearly describe the conditions under which they are synchronous. Fix: https://github.com/nodejs/node/issues/10617 PR-URL: https://github.com/nodejs/node/pull/10884 Reviewed-By:
-
- Feb 16, 2017
-
-
Nikolai Vavilov authored
This makes write[U]Int* operations on Buffer with `noAssert=false` about 3 times faster. PR-URL: https://github.com/nodejs/node/pull/11324 Refs: https://github.com/nodejs/node/issues/11245 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Timothy Gu authored
Also remove executable bit from doc/api/url.md's mode. PR-URL: https://github.com/nodejs/node/pull/11330 Fixes: 4757ddcc "doc: add basic documentation for WHATWG URL API" Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/11330 Reviewed-By:
-
Rich Trott authored
When splitting PEM string into separate certs, use non-capturing regexp to avoid having to put the split string back with .map(). As a bonus, this splits the PEM into two certs, rather than 2 certs and a third crufty whitespace-only string. PR-URL: https://github.com/nodejs/node/pull/11367 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/11314 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/831 Fixes: https://github.com/nodejs/node/issues/947 Ref: https://github.com/nodejs/node/pull/9470 PR-URL: https://github.com/nodejs/node/pull/9744 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Rich Trott authored
Before: `Missing expected exception..` Afer: `Missing expected exception.` PR-URL: https://github.com/nodejs/node/pull/11254 Reviewed-By:
-
James M Snell authored
Since slowToString only has one callsite, refactor to eliminate the use of call. PR-URL: https://github.com/nodejs/node/pull/11358 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
James M Snell authored
Avoid use of arguments in Buffer.prototype.toString() PR-URL: https://github.com/nodejs/node/pull/11358 Reviewed-By:
-
Rich Trott authored
Change the Stability Index on `assert` from Locked to Stable. PR-URL: https://github.com/nodejs/node/pull/11304 Ref: https://github.com/nodejs/node/issues/11200 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
cjihrig authored
env was unused since the ref'd commit Ref: https://github.com/nodejs/node/commit/e34ee1d2c978d46f8aee3fedda0f32bc2a04d7d4 PR-URL: https://github.com/nodejs/node/pull/11361 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
James M Snell authored
Replace use of arguments with `...args` ``` tls/tls-connect.js dur=5 concurrency=1 -9.43 % 0.172136744 tls/tls-connect.js dur=5 concurrency=10 29.05 % ** 0.001108115 ``` PR-URL: https://github.com/nodejs/node/pull/11357 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/11359 Reviewed-By:
-
Ben Noordhuis authored
Upstream V8 is removing SIMD support. Be proactive and follow suit. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4124 PR-URL: https://github.com/nodejs/node/pull/11346 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/11346 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/11264 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/11264 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/11264 Reviewed-By:
-
Akito Ito authored
* call Certificate function directly * check exception when sign option is undefined PR-URL: https://github.com/nodejs/node/pull/11280 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
- Feb 15, 2017
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/11206 Reviewed-By:
-
John Barboza authored
PR-URL: https://github.com/nodejs/node/pull/10522 Fixes: https://github.com/nodejs/node/issues/1271 Reviewed-By:
-
Vse Mozhet Byt authored
* var -> const * string concatenation -> template strings PR-URL: https://github.com/nodejs/node/pull/11110 Reviewed-By:
-
Timothy Gu authored
Also factor out common parts in querystring and url. PR-URL: https://github.com/nodejs/node/pull/11161 Reviewed-By:
-
Ben Noordhuis authored
Seems to have been overlooked in commit dd93c53c ("Make node::DLOpen use uv_dlopen") from 2011. PR-URL: https://github.com/nodejs/node/pull/11322 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
-
cjihrig authored
When a non-exclusive dgram socket is bound from a cluster worker, it attempts to get a handle from the cluster module. This commit adds coverage for the case where the socket is closed while querying the cluster module for a handle. PR-URL: https://github.com/nodejs/node/pull/11292 Reviewed-By:
-
cjihrig authored
This commit sets the spawnSync() exit code to null when the child is killed via signal. This brings the behavior more in sync with spawn(). Fixes: https://github.com/nodejs/node/issues/11284 PR-URL: https://github.com/nodejs/node/pull/11288 Reviewed-By:
-
- Feb 14, 2017
-
-
Ben Noordhuis authored
Remove the explicit dependency on $(NODE_EXE), it always triggers a rebuild due to it being a .PHONY rule. Add-ons in test/addons/ have the same implicit dependency so it isn't completely without precedent. PR-URL: https://github.com/nodejs/node/pull/11311 Reviewed-By:
-
Franziska Hinkelmann authored
V8 moved the Embeder's guide to GitHub. PR-URL: https://github.com/nodejs/node/pull/11336 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/11098 Fixes: https://github.com/nodejs/node/issues/10760 Ref: https://github.com/whatwg/url/issues/26 Ref: https://github.com/whatwg/url/pull/199 Ref: https://github.com/w3c/web-platform-tests/pull/4531 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/11098 Fixes: https://github.com/nodejs/node/issues/10760 Ref: https://github.com/whatwg/url/issues/26 Ref: https://github.com/whatwg/url/pull/199 Ref: https://github.com/w3c/web-platform-tests/pull/4531 Reviewed-By:
-
