- Jun 07, 2020
-
-
cjihrig authored
The WASM memory interfacing logic was wrong (particularly around the size of __wasi_subscription_t). This commit fixes the logic. PR-URL: https://github.com/nodejs/node/pull/33250 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Gabriel Schulhof authored
* Initialize structure members. * Factor out common `Debug()` prefix. * Remove unused `text_region` field. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/33255 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Jonathan Buhacoff authored
Calling `decipher.setAuthTag` after `decipher.update` will result in an error like `Unsupported state or unable to authenticate data`. The example code in [CCM mode](https://nodejs.org/docs/latest-v14.x/api/crypto.html#crypto_ccm_mode) is correct, but to demonstrate the mistake in the documentation you can take the same example and move the `setAuthTag` call to in between `update` and `final` you will see the error.
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/33100 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Adam Majer authored
Add capabilities to common test module to detect and skip tests on dumb terminals. In some of our build environments, like s390x, the terminal is a dumb terminal meaning it has very rudimentary capabilities. These in turn prevent some of the tests from completing with errors as below. not ok 1777 parallel/test-readline-tab-complete --- duration_ms: 0.365 severity: fail exitcode: 1 stack: |- assert.js:103 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: '\t' !== '' at /home/abuild/rpmbuild/BUILD/node-git.8698dd98/test/parallel/test-readline-tab-complete.js:63:14 at Array.forEach (<anonymous>) at /home/abuild/rpmbuild/BUILD/node-git.8698dd98/test/parallel/test-readline-tab-complete.js:18:17 at Array.forEach (<anonymous>) at Object.<anonymous> (/home/abuild/rpmbuild/BUILD/node-git.8698dd98/test/parallel/test-readline-tab-complete.js:17:3) at Module._compile (internal/modules/cjs/loader.js:1176:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10) at Module.load (internal/modules/cjs/loader.js:1040:32) at Function.Module._load (internal/modules/cjs/loader.js:929:14) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) { generatedMessage: true, code: 'ERR_ASSERTION', actual: '\t', expected: '', operator: 'strictEqual' } ... PR-URL: https://github.com/nodejs/node/pull/33165 Reviewed-By:Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
szTheory authored
PR-URL: https://github.com/nodejs/node/pull/33211 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
osher authored
Ran into #30189, solved by this comment: https://github.com/nodejs/node/issues/30189#issuecomment-548250793 Refs: https://github.com/nodejs/node/issues/30189 PR-URL: https://github.com/nodejs/node/pull/33174 Reviewed-By:
Christian Clauss <cclauss@me.com>
-
Karol Walasek authored
PR-URL: https://github.com/nodejs/node/pull/33179 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
Nikolai Vavilov authored
It returns zero-filled memory since v8.0.0. PR-URL: https://github.com/nodejs/node/pull/33198 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Pranshu Srivastava authored
PR-URL: https://github.com/nodejs/node/pull/33217 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Simen Bekkhus authored
PR-URL: https://github.com/nodejs/node/pull/33230 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/33235 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/33248 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Andrey Pechkurov authored
AsyncWrap is a private API and should not be mentioned in the documentation. PR-URL: https://github.com/nodejs/node/pull/33249 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
James M Snell authored
Signed-off-by:
Mathias Buus <mathiasbuus@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Gabriel Schulhof authored
Adds a test to ensure that napi_get_value_uint32 returns 0xffffffff for -1. Re: https://github.com/nodejs/node/issues/33117 Signed-off-by:
Zeyu Yang <himself65@outlook.com>
-
Robert Nagy authored
Currently from will eagerly buffer up items which means that errors are also eagerly encountered and items which are buffer when an error occurs will be discarded, which is inconsistent with how generators work. Fixes: https://github.com/nodejs/node/issues/29428 PR-URL: https://github.com/nodejs/node/pull/33201 Reviewed-By:
-
Michael Dawson authored
Fixes: https://github.com/nodejs/node/issues/33153 Change documentation to make async_resource required as opposed to optional in napi-async_init. Changes over time mean this parameter is required for proper operation of async hooks (which are still experimental). This changes the documentation to document what callers should do. We are doing this only in the doc in order to avoid a breaking change in N-API. We could create a new version of the method for which the parametrer is enforced as mandatory but we should only do that once async hooks is no longer experimental. In that case we could deprecate (but not remove this version of the method). Signed-off-by:
Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33181 Reviewed-By:
-
James M Snell authored
The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Richard Lau authored
This reverts commit e08ac095. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Richard Lau authored
This reverts commit babeb58c. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Myles Borins authored
If package authors don't explicitly include all previously supported entry points introducing package.exports will be a Semver-Major change. Add a warning about this behavior and offer two potential solutions for module authors. Refs: https://github.com/then/is-promise/issues/20 PR-URL: https://github.com/nodejs/node/pull/33074 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/33194 Reviewed-By:
-
Julian Duque authored
PR-URL: https://github.com/nodejs/node/pull/33185 Reviewed-By:
Adrian Estrada <edsadr@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/32797#discussion_r407222290 PR-URL: https://github.com/nodejs/node/pull/32798 Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Matteo Collina authored
This changes makes all stream in a pipeline emit 'error' in case of an abnormal termination of the pipeline. If the last stream is currently being async iterated, this change will make the iteration reject accordingly. See: https://github.com/nodejs/node/pull/30861 Fixes: https://github.com/nodejs/node/issues/28194 PR-URL: https://github.com/nodejs/node/pull/30869 Reviewed-By:
-
- Jun 03, 2020
-
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs-private/node-private/pull/213
-
- Jun 02, 2020
-
-
Michaël Zasso authored
This is a security release. Notable changes: Vulnerabilities fixed: CVE-2020-8172: TLS session reuse can lead to host certificate verification bypass (High). CVE-2020-11080: HTTP/2 Large Settings Frame DoS (Low). CVE-2020-8174: `napi_get_value_string_*()` allows various kinds of memory corruption (High). PR-URL: https://github.com/nodejs-private/node-private/pull/213
-
Fedor Indutny authored
Prior to this patch `session` event was emitted after `secure` event on TLSSocket, but before `secureConnect` event. This is problematic for `https.Agent` because it must cache session only after verifying the remote peer's certificate. Connecting to a server that presents an invalid certificate resulted in the session being cached after the handshake with the server and evicted right after a certifiate validation error and socket's destruction. A request initiated during this narrow window would pick the faulty session, send it to the malicious server and skip the verification of the server's certificate. Fixes: https://hackerone.com/reports/811502 CVE-ID: CVE-2020-8172 PR-URL: https://github.com/nodejs-private/node-private/pull/200 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
James M Snell authored
Adds the maxSettings option to limit the number of settings entries allowed per SETTINGS frame. Default 32 Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
Tobias Nießen authored
Fixes: https://hackerone.com/reports/784186 CVE-ID: CVE-2020-8174 PR-URL: https://github.com/nodejs-private/node-private/pull/195 Reviewed-By:
-
AshCripps authored
Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: Entrust Root Certification Authority - G4 Certificates removed: PR-URL: https://github.com/nodejs/node/pull/33682 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
AshCripps authored
This is the certdata.txt[0] from NSS 3.53, released on 2020-05-29. This is the version of NSS that will ship in Firefox 78 on 2020-06-30. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_53_RTM/lib/ckfw/builtins/certdata.txt PR-URL: https://github.com/nodejs/node/pull/33682 Reviewed-By:
-
- May 26, 2020
-
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/33197
-
- May 25, 2020
-
-
Michaël Zasso authored
Notable changes: * ECMAScript Modules - `--experimental-modules` flag removal * AsyncLocalStorage API (experimental) * REPL previews * REPL reverse-i-search * REPL substring-based search * Error monitoring * Monitoring `error` events * Monitoring uncaught exceptions * File system APIs * New function: `fs.readv` * Optional parameters in `fs.read` * Console `groupIndentation` option * `maxStringLength` option for `util.inspect()` * Stable N-API release 6 * Stable diagnostic reports * Increase of the default server headers timeout * New `--trace-sigint` CLI flag * Various crypto APIs now support Diffie-Hellman secrets * Added support for the `dns.ALL` flag in `dns.lookup()` * Added a new experimental API to interact with Source Map V3 data * Added support for passing a `transferList` along with `workerData` to the `Worker` constructor PR-URL: https://github.com/nodejs/node/pull/33197
-
Paolo Insogna authored
PR-URL: https://github.com/nodejs/node/pull/33307 Reviewed-By:
-
- May 23, 2020
-
-
Steven R. Loomis authored
- Backport of https://github.com/unicode-org/icu/commit/715d254a02b0b22681cb6f861b0921ae668fa7d6 - ICU bug: https://unicode-org.atlassian.net/browse/ICU-21081 PR-URL: https://github.com/nodejs/node/pull/33337 Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com>
-
Michaël Zasso authored
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1 PR-URL: https://github.com/nodejs/node/pull/33337 Reviewed-By:
-
- May 13, 2020
-
-
Daniele Belardi authored
Run CommonJS resolver only if `error.code` is ERR_MODULE_NOT_FOUND. Avoid using absolute paths in hint by: * using a parent-relative path if the specifier is a relative path * using a `pkg/x.js` format if the specifier is bare (e.g. `pkg/x`) PR-URL: https://github.com/nodejs/node/pull/31906 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
