- Aug 04, 2015
-
-
James M Snell authored
per https://github.com/joyent/node/pull/25591#discussion_r34824389 Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25591
-
James M Snell authored
Per https://github.com/joyent/node/pull/25635#discussion_r33973696 Additional refinement to the clarification on the `readable` event Reviewed-By:
-
James M Snell authored
per https://github.com/joyent/node/issues/14597 Indicate that `'readable'` indicates only that data can be read from the stream, not that there is actually data to be consumed. `readable.read([size])` can still return null. Includes an example that illustrates the point. Reviewed-By:
-
James M Snell authored
Per https://github.com/joyent/node/issues/14604 , Document that performing an `unshift` during a read can have unexpected results. Following the `unshift` with a `push('')` resets the reading state appropriately. Also indicate that doing an `unshift` during a read is not optimal and should be avoided. Reviewed-By:
-
Daniel Rentz authored
Fix for https://github.com/joyent/node/issues/25559 (Typo in example of util.deprecate() documentation) Reviewed-By:
-
fresheneesz authored
Minor clarifications around Readable._read and Readable.push to make their implementation/usage easier to understand. https://github.com/joyent/node/issues/14124#issuecomment-115392674 Reviewed-By:
-
James M Snell authored
per: https://github.com/joyent/node/issues/14596 1. document that a runtime error will occur if you attempt to unshift after the end event 2. document that calling read after the end event will return null and will not trigger a runtime error Reviewed-By:
-
Benjamin Steephenson authored
Clarifies that emitter.listener() returns a copy, not a reference Resolves issue #9022 Reviewed-By:
-
Philippe Laferriere authored
Made explicitely clear that when size bytes are not available, it will return null, unless we've ended, in which case the data remaining in the buffer will be returned. Fixes #7273 Reviewed-By:
-
Jared Fox authored
'the' to 'then' Reviewed-By:
-
Michele Caini authored
Reviewed-By:
-
Ville Skyttä authored
Reviewed-By:
-
Ville Skyttä authored
Reviewed-By:
-
James M Snell authored
Original: https://github.com/joyent/node/pull/8682 Slightly modified version of the original PR (#8682) to add appropriate line wrapping and fix a couple of grammar nits. Reviewed-By:
-
James M Snell authored
Fix the line wrapping in buffer.markdown Reviewed-By:
-
Sarath authored
fixes #7230 Reviewed-By:
-
Chris Neave authored
The documentation for createWriteStream() references an 'encoding' property that has a default value of null. However, this property is never referenced by createWriteStream() or WritableState(). Instead a 'defaultEncoding' property is referenced in WritableState() with a default of 'utf8' if no value is supplied. This fix updates the documentation to rename the 'encoding' property to 'defaultEncoding' and indicate its default value of 'utf8'. Reviewed-By:
-
James M Snell authored
Per: https://github.com/joyent/node/issues/8017 Reviewed-By:
-
James M Snell authored
per: https://github.com/joyent/node/issues/6847 Reviewed-By:
-
James M Snell authored
Per #4409, the documentation on http.abort is a bit lacking. This provides a slight improvement. Reviewed-By:
-
- Jul 24, 2015
-
-
Alexis Campailla authored
This test just failed on Ubuntu in Jenkins, for a change that is 100% Windows-specific. Reviewed-By:
Joao Reis <reis@janeasystems.com> PR-URL: https://github.com/joyent/node/pull/25750
-
- Jul 23, 2015
-
-
João Reis authored
This change is a backport of 2b4b6006 from io.js. Original commit message: This test was failing because the spawned process was terminated before anything could be done, by calling child.stdin.end. With this change, the child's stdin is no longer closed. When the stdin is not a tty, io.js waits for the whole input before starting, so the child must be run with --interactive to process the command sent by the parent. The child is killed explicitly by the parent before it exits. This test was failing silently because the asserts were not called if nothing was received from the child. This fix moves assertOutputLines to always run on exit. Fixes: https://github.com/nodejs/io.js/issues/2177 Refs: https://github.com/nodejs/io.js/issues/2094 PR-URL: https://github.com/nodejs/io.js/pull/2186 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
-
- Jul 22, 2015
-
-
João Reis authored
Since install is per machine only, installation path should be stored in local machine instead of current user. The registry stores HKLM in different places for 32 and 64 bit applications, so the installer will not suggest the old path when upgrading from 32 to 64 bit version. Fixes #5592 Fixes #25087 PR-URL: https://github.com/joyent/node/pull/25640 Reviewed-By:
Bert Belder <bertbelder@gmail.com>
-
João Reis authored
The MSI install scope was set to the WiX default, which is per-user. However, with UAC, it could not be installed by a standard user because InstallPrivileges is elevated by default, hence the install scope should be set to per-machine. Furthermore, the default install path is a per-machine location and setting the system path requires administrator privileges. By changing the InstallScope to perMachine, Start Menu shortcuts are placed in ProgramData and not the installing user's AppData folder, making the shortcuts available to other users. This also fixes the installation when AppData is a network folder. The custom action is necessary to allow upgrades. Since a per-machine MSI cannot upgrade an application installed per-user, the custom action checks if there is going to be an upgrade to a previous version installed per-user and sets the installation as per-user to allow upgrading. Hence, the advantages of installing per-machine will only apply in fresh installations. Fixes #5849 Fixes #7629 PR-URL: https://github.com/joyent/node/pull/25640 Reviewed-By:
-
- Jul 21, 2015
-
-
Fedor Indutny authored
Reviewed-By:
Fedor Indutny <fedor@indutny.com> PR-URL: https://github.com/joyent/node/pull/25739
-
Fedor Indutny authored
See: https://github.com/joyent/node/issues/25736 Reviewed-By:
-
Fedor Indutny authored
When listening for client hello parser events (like OCSP requests), do not hang if `newSession` event handler is not present. Fix: https://github.com/joyent/node/issues/8660 Fix: https://github.com/joyent/node/issues/25735 Reviewed-By:
-
- Jul 18, 2015
-
-
Julien Gilli authored
Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR-URL: https://github.com/joyent/node/pull/25707
-
cgalibern authored
Add a configuration flag that prevents mdb_v8.so from being built. The default behavior is still the same and mdb_v8.so is built by default on Solaris based platforms such as SmartOS. Using --without-mdb fixes build issues on Solaris based platforms where libproc.h is not available or not compatible with the one shipped by SmartOS. Fixes #6439. Reviewed-By:
-
- Jul 16, 2015
-
-
João Reis authored
- `test-crypto-domains` was fixed by joyent/node@2afa3d8a03f1f0798d83dc57abc252bb78b7e591 - All tests under linux appear to be fixed and have not failed recently on Jenkins - `test-http-dns-fail` was fixed by the DNS configuration change mentioned in joyent/node#8056 Fixes #25656 Fixes #25673 Reviewed-By:
-
- Jul 11, 2015
-
-
Alexis Campailla authored
Adding a single rule to be called from Jenkins. Reviewed-By:
-
Alexis Campailla authored
Make the test runner return a 0 exit code when only flaky tests fail and --flaky-tests=dontcare is specified. Reviewed-By:
-
Alexis Campailla authored
Adding support for specifying flaky test mode to the test runner: - via an environment variable FLAKY_TESTS for Makefile - via an argument ignore-flaky for vcbuild.bat Conflicts: Makefile Reviewed-By:
-
Alexis Campailla authored
Reviewed-By:
-
Johan Bergström authored
On a few of our installations (namely CentOS), passing 'INFO' resulted in a silent loglevel. Use a logging constant instead. Cherry-picked from https://github.com/nodejs/io.js/commit/8606793999979829df002c2ab69235a05605fc4d Original commit metadata follows: Fixes: https://github.com/nodejs/build/issues/104 PR-URL: https://github.com/nodejs/io.js/pull/1842 Reviewed-By:
-
Alexis Campailla authored
This is a minimal effort to support test output written both to stdout and file in order to get our buildbots understanding test output. Cherry picked from https://github.com/jbergstroem/io.js/commit/31940738e2d256e91c1c694c5219b8f840c629ff Original commit message follows: PR-URL: https://github.com/iojs/io.js/pull/934 Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Conflicts: tools/test.py Reviewed-By:
-
- Jul 10, 2015
-
-
Julien Gilli authored
-
Julien Gilli authored
-
Julien Gilli authored
* openssl: upgrade to 1.0.1p (CVE-2015-1793) * npm: upgrade to 2.11.3 * V8: cherry-pick JitCodeEvent patch from upstream (Ben Noordhuis) * win,msi: create npm folder in AppData directory (Steven Rockarts)
-
Julien Gilli authored
Conflicts: AUTHORS ChangeLog deps/v8/src/log.cc src/node_version.h
-
