- Oct 09, 2018
-
-
Brandon Smith authored
PR-URL: https://github.com/nodejs/node/pull/23302 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
The internal assert module exposed an errorCache property solely for testing. It is no longer necessary. Remove it. PR-URL: https://github.com/nodejs/node/pull/23304 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Rich Trott authored
The internal `assert` modules `errorCache` property is exposed only for testing. The one test that used it is rewritten here to not use it. This has the following advantages: * The test now makes sure that there is an empty cache in a more robust way. Instead of relying on the internal implementation of `errorCache`, it simply spawns a separate process. * One less test using the `--expose-internals` flag. PR-URL: https://github.com/nodejs/node/pull/23304 Reviewed-By:
-
Gabriel Schulhof authored
Provides a link from the N-API reference to the guide discussing ABI stability in greater depth. Re: https://github.com/nodejs/abi-stable-node/issues/332 PR-URL: https://github.com/nodejs/node/pull/23287/ Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23297 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23297 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23297 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23297 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23297 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23297 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23297 Reviewed-By:
-
cjihrig authored
With the removal of test-buffer-bindingobj-no-zerofill.js, internalBinding can be used unconditionally to assign isAnyArrayBuffer(). PR-URL: https://github.com/nodejs/node/pull/23234 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23234 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/23234 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
-
Rich Trott authored
It appears that a `to` was left out in one sentence of the streams.md doc. Add it. PR-URL: https://github.com/nodejs/node/pull/23306 Reviewed-By:
-
Rich Trott authored
Refer to Node.js versions without a prepended `v`. This was standardized on previously to avoid confusion between Node.js 8 and the V8 JavaScript engine. (`Node.js 8` is clear. `v8` or even `Node.js v8`, not so much.) PR-URL: https://github.com/nodejs/node/pull/23306 Reviewed-By:
-
Gus Caplan authored
Closes: https://github.com/nodejs/node/issues/23041 - Rewrite `ReadableAsyncIterator` class into `ReadableStreamAsyncIteratorPrototype` which contains no constructor and inherits from `%AsyncIteratorPrototype%`. - Rewrite `AsyncIteratorRecord` into dumb function. PR-URL: https://github.com/nodejs/node/pull/23042 Fixes: https://github.com/nodejs/node/issues/23041 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Previously, flushing on zlib streams was implemented through stream 'drain' handlers. This has a number of downsides; in particular, it is complex, and could lead to unpredictable behaviour, since it meant that in a sequence like ```js compressor.write('abc'); compressor.flush(); waitForMoreDataAsynchronously(() => { compressor.write('def'); }); ``` it was not fully deterministic whether the flush happens after the second chunk is written or the first one. This commit replaces this mechanism by one that piggy-backs along the stream’s write queue, using a “special” `Buffer` instance that signals that a flush is currently due. PR-URL: https://github.com/nodejs/node/pull/23186 Reviewed-By: -
Rich Trott authored
Fixture files are not linted. Remove `eslint-disable` comments from fixture files. PR-URL: https://github.com/nodejs/node/pull/23345 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/23298 Reviewed-By:
-
Ben Noordhuis authored
An upcoming change in libuv will remove the artificial EISDIR error. Update the test to reflect that. Refs: https://github.com/libuv/libuv/pull/2025 PR-URL: https://github.com/nodejs/node/pull/23330 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
siddhant authored
PR-URL: https://github.com/nodejs/node/pull/23216 Fixes: https://github.com/nodejs/node/issues/23205 Reviewed-By:
-
Rich Trott authored
Simplifying some BUILDING.md and related text since a lot of people will be reading it soon for Code & Learn. I'd prefer to delete much of this text, but that risks controversy. These simplifications should be (I hope) uncontroversial. PR-URL: https://github.com/nodejs/node/pull/23335 Reviewed-By:
-
- Oct 08, 2018
-
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/23284 Reviewed-By:
-
James M Snell authored
Key new feature: RFC 8441 `:protocol` support PR-URL: https://github.com/nodejs/node/pull/23284 Reviewed-By:
-
Yang Guo authored
This serves as mitigation for the so-called HashWick vulnerability. Original commit messages: commit 3833fef57368c53c6170559ffa524c8c69f16ee5 Author: Yang Guo <yangguo@chromium.org> Date: Thu Sep 20 11:43:13 2018 Refactor integer hashing function names We now clearly differentiate between: - unseeded hash for 32-bit integers - unseeded hash for 64-bit integers - seeded hash for 32-bit integers - seeded hash for strings R=bmeurer@chromium.org Bug: chromium:680662 Change-Id: I7459958c4158ee3501c962943dff8f33258bb5ce Reviewed-on: https://chromium-review.googlesource.com/1235973 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#56068} commit 95a979e02d7154e45b293261a6998c99d71fc238 Author: Yang Guo <yangguo@chromium.org> Date: Thu Sep 20 14:34:48 2018 Call into C++ to compute seeded integer hash R=bmeurer@chromium.org Bug: chromium:680662 Change-Id: I8dace89d576dfcc5833fd539ce698a9ade1cb5a0 Reviewed-on: https://chromium-review.googlesource.com/1235928 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#56271} Refs: https://github.com/nodejs/node/issues/23259 PR-URL: https://github.com/nodejs/node/pull/23264 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Beni von Cheni authored
In tls module, accept ArrayBuffer/DataView in place of isUint8Array in the source code & related test code in "test-tls-basic-validations.js", per the "tls" item in the checklist of the comment in #1826. PR-URL: https://github.com/nodejs/node/pull/23210 Refs: https://github.com/nodejs/node/issues/1826 Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/23225 Reviewed-By:
-
Daniel Bevenius authored
This commit removes the goto statements in SSL_CTX_use_certificate_chain by using a unique_ptr. PR-URL: https://github.com/nodejs/node/pull/23113 Reviewed-By:
-
Tom White authored
test for unusual error cases: verify that module require() falls back to index if package.json names a missing file and throws an error if package.json is unparseable. PR-URL: https://github.com/nodejs/node/pull/23285 Reviewed-By:
-
Rich Trott authored
Remove two eslint-disable comments by replacing string concatenation with template literals. These changes are in catch blocks that are not part of the actual code being benchmarked. PR-URL: https://github.com/nodejs/node/pull/23305 Reviewed-By:
-
Rich Trott authored
vsemozhetbyt noted that there were two mentions of the now-defunct 72-hour-rule in pull-requests.md. This change updates the text to reflect current wait-time rules. PR-URL: https://github.com/nodejs/node/pull/23309 Reviewed-By:
-
Anna Henningsen authored
Use the same symbol that other `AsyncWrap` instances also use for accessing the JS wrapper. PR-URL: https://github.com/nodejs/node/pull/23189 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Aleksey Chemakin authored
Correct parameter name for `napi_is_error` description. PR-URL: https://github.com/nodejs/node/pull/23310 Reviewed-By:
-
Gabriel Schulhof authored
Move it to the nodejs.org repo. PR-URL: https://github.com/nodejs/node/pull/23303 Reviewed-By:
-
- Oct 07, 2018
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/23249 Refs: https://github.com/nodejs/node/pull/22255 Reviewed-By:
-
Rich Trott authored
Use fast-tracking on PRs where new Collaborators are adding themselves to the README. PR-URL: https://github.com/nodejs/node/pull/23300 Reviewed-By:
-
Rich Trott authored
Use backticks around `SHASUM256.txt` etc. in README.md. PR-URL: https://github.com/nodejs/node/pull/23299 Reviewed-By:
-
Rich Trott authored
Unreliability for test-trace-events-fs-sync is believed to have been fixed. Remove flaky designation. Ref: https://github.com/nodejs/node/pull/22812 Ref: https://github.com/nodejs/node/issues/21038#issuecomment-421199960 PR-URL: https://github.com/nodejs/node/pull/22856 Refs: https://github.com/nodejs/node/pull/22812 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
-
Rich Trott authored
Clarify and implify the API Documentation download information in the README. This also fixes a spelling error. PR-URL: https://github.com/nodejs/node/pull/23268 Reviewed-By:
-
