1. Apr 19, 2013
    • isaacs's avatar
      Merge remote-tracking branch 'ry/v0.10' · 0bccb341
      isaacs authored
      0bccb341
    • Ryan Doenges's avatar
      assert: put info in err.message, not err.name · 6101eb18
      Ryan Doenges authored
      4716dc66 made assert.equal() and related functions work better by
      generating a better toString() from the expected, actual, and operator
      values passed to fail(). Unfortunately, this was accomplished by putting
      the generated message into the error's `name` property. When you passed
      in a custom error message, the error would put the custom error into
      `name` *and* `message`, resulting in helpful string representations like
      "AssertionError: Oh no: Oh no".
      
      This commit resolves that issue by storing the generated message in the
      `message` property while leaving the error's name alone and adding
      a regression test so that this doesn't pop back up later.
      
      Closes #5292.
      6101eb18
    • Ben Noordhuis's avatar
      a835a2fc
  2. Apr 18, 2013
  3. Apr 17, 2013
  4. Apr 16, 2013
  5. Apr 13, 2013
  6. Apr 12, 2013
    • Fedor Indutny's avatar
      uv: Upgrade to v0.11.1 · 061151c5
      Fedor Indutny authored
      061151c5
    • Fedor Indutny's avatar
      Merge branch 'v0.10' · 259839fe
      Fedor Indutny authored
      Conflicts:
      	ChangeLog
      	deps/uv/src/version.c
      	src/node.h
      	src/node_crypto.cc
      	src/node_crypto_bio.cc
      	src/node_crypto_bio.h
      	src/node_object_wrap.h
      	src/node_version.h
      259839fe
    • isaacs's avatar
      build: Typo in tools/msvs/msi/product.wxs · 8ee43006
      isaacs authored
      8ee43006
    • isaacs's avatar
      stream: Fix unshift() race conditions · b0de1e4a
      isaacs authored
      Fix #5272
      
      The consumption of a readable stream is a dance with 3 partners.
      
      1. The specific stream Author (A)
      2. The Stream Base class (B), and
      3. The Consumer of the stream (C)
      
      When B calls the _read() method that A implements, it sets a 'reading'
      flag, so that parallel calls to _read() can be avoided.  When A calls
      stream.push(), B knows that it's safe to start calling _read() again.
      
      If the consumer C is some kind of parser that wants in some cases to
      pass the source stream off to some other party, but not before "putting
      back" some bit of previously consumed data (as in the case of Node's
      websocket http upgrade implementation).  So, stream.unshift() will
      generally *never* be called by A, but *only* called by C.
      
      Prior to this patch, stream.unshift() *also* unset the state.reading
      flag, meaning that C could indicate the end of a read, and B would
      dutifully fire off another _read() call to A.  This is inappropriate.
      In the case of fs streams, and other variably-laggy streams that don't
      tolerate overlapped _read() calls, this causes big problems.
      
      Also, calling stream.shift() after the 'end' event did not raise any
      kind of error, but would cause very strange behavior indeed.  Calling it
      after the EOF chunk was seen, but before the 'end' event was fired would
      also cause weird behavior, and could lead to data being lost, since it
      would not emit another 'readable' event.
      
      This change makes it so that:
      
      1. stream.unshift() does *not* set state.reading = false
      2. stream.unshift() is allowed up until the 'end' event.
      3. unshifting onto a EOF-encountered and zero-length (but not yet
      end-emitted) stream will defer the 'end' event until the new data is
      consumed.
      4. pushing onto a EOF-encountered stream is now an error.
      
      So, if you read(), you have that single tick to safely unshift() data
      back into the stream, even if the null chunk was pushed, and the length
      was 0.
      b0de1e4a
    • isaacs's avatar
      Now working on v0.10.5 · 440bc060
      isaacs authored
      440bc060
    • isaacs's avatar
      Merge branch 'v0.10.4-release' into v0.10 · bf8ed118
      isaacs authored
      bf8ed118
    • isaacs's avatar
      lint · 22c7d134
      isaacs authored
      22c7d134
    • isaacs's avatar
      blog: Fix title for v0.8.23 release · 50be3979
      isaacs authored
      50be3979
    • isaacs's avatar
      2013.04.11, Version 0.10.4 (Stable) · 9712aa9f
      isaacs authored
      * uv: Upgrade to 0.10.4
      
      * npm: Upgrade to 1.2.18
      
      * v8: Avoid excessive memory growth in JSON.parse (Fedor Indutny)
      
      * child_process, cluster: fix O(n*m) scan of cmd string (Ben Noordhuis)
      
      * net: fix socket.bytesWritten Buffers support (Fedor Indutny)
      
      * buffer: fix offset checks (Łukasz Walukiewicz)
      
      * stream: call write cb before finish event (isaacs)
      
      * http: Support write(data, 'hex') (isaacs)
      
      * crypto: dh secret should be left-padded (Fedor Indutny)
      
      * process: expose NODE_MODULE_VERSION in process.versions (Rod Vagg)
      
      * crypto: fix constructor call in crypto streams (Andreas Madsen)
      
      * net: account for encoding in .byteLength (Fedor Indutny)
      
      * net: fix buffer iteration in bytesWritten (Fedor Indutny)
      
      * crypto: zero is not an error if writing 0 bytes (Fedor Indutny)
      
      * tls: Re-enable check of CN-ID in cert verification (Tobias Müllerleile)
      9712aa9f
    • isaacs's avatar
      npm: Upgrade to 1.2.18 · 1ccae9cb
      isaacs authored
      1ccae9cb
    • isaacs's avatar
      uv: Upgrade to v0.10.4 · e5fdc4d6
      isaacs authored
      e5fdc4d6