- Apr 23, 2013
-
-
Miroslav Bajtoš authored
-
isaacs authored
-
isaacs authored
Fixes #3740 In the case of pipelined requests, you can have a situation where the socket gets destroyed via one req/res object, but then trying to destroy *another* req/res on the same socket will cause it to call undefined.destroy(), since it was already removed from that message. Add a guard to OutgoingMessage.destroy and IncomingMessage.destroy to prevent this error.
-
- Apr 22, 2013
-
-
isaacs authored
Allow the IPv4-mapped-as-IPv6 style address.
-
- Apr 21, 2013
-
-
isaacs authored
It needs to apply the Transform class when the _readableState, _writableState, or _transformState properties are accessed, otherwise things like setEncoding and on('data') don't work properly. Also, the methods wrappers are no longer needed, since they're only problematic because they access the undefined properties. -
mscdex authored
-
mscdex authored
-
- Apr 20, 2013
- Apr 19, 2013
-
-
Sean Silva authored
Fixes #5326.
-
Ryan Doenges authored
4716dc66 made assert.equal() and related functions work better by generating a better toString() from the expected, actual, and operator values passed to fail(). Unfortunately, this was accomplished by putting the generated message into the error's `name` property. When you passed in a custom error message, the error would put the custom error into `name` *and* `message`, resulting in helpful string representations like "AssertionError: Oh no: Oh no". This commit resolves that issue by storing the generated message in the `message` property while leaving the error's name alone and adding a regression test so that this doesn't pop back up later. Closes #5292.
-
Ben Noordhuis authored
-
- Apr 18, 2013
-
-
Trevor Norris authored
A new String was being created and returned, but was not sent through the scope.Close(), which caused it to be cleaned up before being returned.
-
Ben Noordhuis authored
I broke dgram.Socket#bind(port, cb) almost a year ago in 332fea5a but it wasn't until today that someone complained and none of the tests caught it because they all either specify the address or omit the callback. Anyway, now it works again and does what you expect: it binds the socket to the "any" address ("0.0.0.0" for IPv4 and "::" for IPv6.)
-
Ben Noordhuis authored
process.stdout isn't fully initialized yet by the time the test starts when invoked with `python tools/test.py`. Use process.stdin instead and force initialization with process.stdin.resume().
-
- Apr 17, 2013
-
-
Kelly Gerber authored
The current example shows the behavior of v0.8. In v0.10 arguments to path.join() must be strings; otherwise, an exception is thrown.
-
Ryan Graham authored
-
Ben Noordhuis authored
Fix a NULL pointer dereference in src/handle_wrap.cc which is really a use-after-close bug. The test checks that unref() after close() works on process.stdout but this bug affects everything that derives from HandleWrap. I discovered it because child processes would sometimes quit for no reason (that is, no reason until I turned on core dumps.)
-
- Apr 16, 2013
-
-
Stanislav Ochotnicky authored
When LD_LIBRARY_PATH is overriden for custom builds we need to preserve it for child processes. To be sure we preserve whole environment of parent process and just add TEST_INIT variable to it.
-
Stanislav Ochotnicky authored
When LD_LIBRARY_PATH is overriden for custom builds we need to preserve it for forked process. There are possibly other environment variables that could cause test failures so we preserve whole environment of parent process.
-
Ben Noordhuis authored
Windows doesn't have MAXHOSTNAMELEN. Introduced in afbaddec.
-
Ben Noordhuis authored
Fix a (rather academic) buffer overflow. MAXHOSTNAMELEN is 256 on most platforms, which means the buffer wasn't big enough to hold the trailing nul byte on a system with a maximum length hostname.
-
Ben Noordhuis authored
* Fix a buffer overflow that happens iff strlen(info.sysname) > 255. * Check the return value of uname().
-
- Apr 12, 2013
-
-
isaacs authored
-
isaacs authored
Fix #5272 The consumption of a readable stream is a dance with 3 partners. 1. The specific stream Author (A) 2. The Stream Base class (B), and 3. The Consumer of the stream (C) When B calls the _read() method that A implements, it sets a 'reading' flag, so that parallel calls to _read() can be avoided. When A calls stream.push(), B knows that it's safe to start calling _read() again. If the consumer C is some kind of parser that wants in some cases to pass the source stream off to some other party, but not before "putting back" some bit of previously consumed data (as in the case of Node's websocket http upgrade implementation). So, stream.unshift() will generally *never* be called by A, but *only* called by C. Prior to this patch, stream.unshift() *also* unset the state.reading flag, meaning that C could indicate the end of a read, and B would dutifully fire off another _read() call to A. This is inappropriate. In the case of fs streams, and other variably-laggy streams that don't tolerate overlapped _read() calls, this causes big problems. Also, calling stream.shift() after the 'end' event did not raise any kind of error, but would cause very strange behavior indeed. Calling it after the EOF chunk was seen, but before the 'end' event was fired would also cause weird behavior, and could lead to data being lost, since it would not emit another 'readable' event. This change makes it so that: 1. stream.unshift() does *not* set state.reading = false 2. stream.unshift() is allowed up until the 'end' event. 3. unshifting onto a EOF-encountered and zero-length (but not yet end-emitted) stream will defer the 'end' event until the new data is consumed. 4. pushing onto a EOF-encountered stream is now an error. So, if you read(), you have that single tick to safely unshift() data back into the stream, even if the null chunk was pushed, and the length was 0.
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
* uv: Upgrade to 0.10.4 * npm: Upgrade to 1.2.18 * v8: Avoid excessive memory growth in JSON.parse (Fedor Indutny) * child_process, cluster: fix O(n*m) scan of cmd string (Ben Noordhuis) * net: fix socket.bytesWritten Buffers support (Fedor Indutny) * buffer: fix offset checks (Łukasz Walukiewicz) * stream: call write cb before finish event (isaacs) * http: Support write(data, 'hex') (isaacs) * crypto: dh secret should be left-padded (Fedor Indutny) * process: expose NODE_MODULE_VERSION in process.versions (Rod Vagg) * crypto: fix constructor call in crypto streams (Andreas Madsen) * net: account for encoding in .byteLength (Fedor Indutny) * net: fix buffer iteration in bytesWritten (Fedor Indutny) * crypto: zero is not an error if writing 0 bytes (Fedor Indutny) * tls: Re-enable check of CN-ID in cert verification (Tobias Müllerleile)
-
isaacs authored
-
isaacs authored
-
- Apr 11, 2013
-
-
Ben Noordhuis authored
Don't scan the whole string for a "NODE_" substring, just check that the string starts with the expected prefix. This is a reprise of dbbfbe74 but this time for the child_process module.
-
Ben Noordhuis authored
Don't scan the whole string for a "NODE_CLUSTER_" substring, just check that the string starts with the expected prefix. The linear scan was causing a noticeable (but unsurprising) slowdown on messages with a large .cmd string property.
-
- Apr 10, 2013
-
-
Ben Noordhuis authored
Call SetPointerInInternalField(0, NULL) rather than SetInternalField(0, Undefined()). Fixes the following spurious NULL pointer dereference in debug builds: #0 0x03ad2821 in v8::internal::FixedArrayBase::length () #1 0x03ad1dfc in v8::internal::FixedArray::get () #2 0x03ae05dd in v8::internal::Context::global_object () #3 0x03b6b87d in v8::internal::Context::builtins () #4 0x03ae1871 in v8::internal::Isolate::js_builtins_object () #5 0x03ab4fab in v8::CallV8HeapFunction () #6 0x03ab4d4a in v8::Value::Equals () #7 0x03b4f38b in CheckEqualsHelper () #8 0x03ac0f4b in v8::Object::SetInternalField () #9 0x06a99ddd in node::ObjectWrap::~ObjectWrap () #10 0x06a8b051 in node::Buffer::~Buffer () #11 0x06a8afbb in node::Buffer::~Buffer () #12 0x06a8af5e in node::Buffer::~Buffer () #13 0x06a9e569 in node::ObjectWrap::WeakCallback ()
-
Ben Noordhuis authored
This change shouldn't have landed in the stable branch. It's a feature, not a bug fix. This reverts commit 58f93ffc. This reverts commit 8c8ebe49. This reverts commit ba0f7b80. This reverts commit 21f3c5c3.
-
Fedor Indutny authored
Buffer.byteLength() works only for string inputs. Thus, when connection has pending Buffer to write, it should just use it's length instead of throwing exception.
-
Ben Noordhuis authored
-