- Oct 16, 2017
-
-
twk-b authored
PR-URL: https://github.com/nodejs/node/pull/16048 Reviewed-By:
James Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
- Oct 15, 2017
-
-
silverwind authored
Fix a line-height issue introduced in #15660 where paragraphs containing <code> blocks would have unequal line heights. Fixes: https://github.com/nodejs/nodejs.org/issues/1399 PR-URL: https://github.com/nodejs/node/pull/16200 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This breaks a few tests when Node is built in debug mode, because V8 is built with `-D_GLIBCXX_DEBUG=1` and Node is built without, which makes e.g. `std::vector` ABI-incompatible between the two. PR-URL: https://github.com/nodejs/node/pull/16159 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/16160 Reviewed-By:
-
Ben Noordhuis authored
Move the logic for building the benchmark/misc/function_call to the top-level Makefile and use our local copy of node-gyp. PR-URL: https://github.com/nodejs/node/pull/16160 Fixes: https://github.com/nodejs/node/issues/16154 Reviewed-By:
-
matzavinos authored
Covert lib/net.js over to using lib/internal/errors.js - Replace thrown errors in lib/net.js with errors from lib/internal/errors. The ERR_INVALID_OPT_VALUE error have been used in the Server.prototype.listen() method - Update tests according to the above modifications PR-URL: https://github.com/nodejs/node/pull/14782 Refs: https://github.com/nodejs/node/issues/11273 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Ben Hallion authored
Replace common.fixturesDir with fixtures module usage in test/parallel/test-tls-fast-writing.js. PR-URL: https://github.com/nodejs/node/pull/15808 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Orta authored
PR-URL: https://github.com/nodejs/node/pull/16205 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Jean-Baptiste Brossard authored
- use mustCall instead of counters - include totalWorkers and settings in the error messages PR-URL: https://github.com/nodejs/node/pull/16065 Reviewed-By:
-
Ruxandra Fediuc authored
PR-URL: https://github.com/nodejs/node/pull/16107 Reviewed-By:
-
Jon Moss authored
Adds comma after natural pause in sentence. PR-URL: https://github.com/nodejs/node/pull/16204 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/16202 Reviewed-By:
-
Randal Hanford authored
Modified pipePrefix to use relative path on windows, previously tests failed when the full path was 120+ characters PR-URL: https://github.com/nodejs/node/pull/15988 Reviewed-By:
-
Vladimir Ilic authored
PR-URL: https://github.com/nodejs/node/pull/16114 Reviewed-By:
-
Kim Gentes authored
PR-URL: https://github.com/nodejs/node/pull/15981 Reviewed-By:
-
JamesNimlos authored
clean up code by using fixtures helper module instead of fixturesDir directly. PR-URL: https://github.com/nodejs/node/pull/15847 Reviewed-By:
-
Shaun Sweet authored
PR-URL: https://github.com/nodejs/node/pull/15992 Reviewed-By:
-
- Oct 14, 2017
-
-
NiveditN authored
Explains the expected behavior of previousStat in fs.watchFile() when a watched file disappears and reappears. PR-URL: https://github.com/nodejs/node/pull/16099 Fixes: https://github.com/nodejs/node/issues/15364 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
-
Bear Trickey authored
PR-URL: https://github.com/nodejs/node/pull/15994 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Tyler Seabrook authored
Import fixturesDir path from common/fixturesDir module rather than from common. PR-URL: https://github.com/nodejs/node/pull/15887 Reviewed-By:
-
Komivi Agbakpem authored
PR-URL: https://github.com/nodejs/node/pull/15967 Reviewed-By:
-
Jon Moss authored
Currently is rendered as "see the [UV_THREADPOOL_SIZE][] documentation", since there was no link definition in the file. PR-URL: https://github.com/nodejs/node/pull/16193 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/16192 Refs: https://github.com/nodejs/node/pull/15984 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/16125 Reviewed-By:
-
243083df authored
PR-URL: https://github.com/nodejs/node/pull/16125 Reviewed-By:
-
WeiPlanet authored
PR-URL: https://github.com/nodejs/node/pull/16027 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/16128 Reviewed-By:
Bradley Meck <bradley.meck@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Daniel Kostro authored
Includes problematic key and iv values into the assertion message PR-URL: https://github.com/nodejs/node/pull/16007 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Mike Fleming authored
This commit updates the common.fixturesDir method in the https-timeout test. PR-URL: https://github.com/nodejs/node/pull/15835 Reviewed-By:
-
Anna Henningsen authored
Ideally, most of these things would be enforced via linter rules. This is a first step into having a style guide that goes beyond what the linter currently enforces. PR-URL: https://github.com/nodejs/node/pull/16090 Fixes: https://github.com/nodejs/node/issues/12636 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Ali Groening authored
Remove test messages for assert.strictEqual, as the default messages are a better option. PR-URL: https://github.com/nodejs/node/pull/15995 Reviewed-By:
-
Justin Beckwith authored
PR-URL: https://github.com/nodejs/node/pull/15987 Reviewed-By:
-
Teddy Katz authored
This adds tests for the custom eslint rules in this repository, using the `RuleTester` test utility bundled with eslint. PR-URL: https://github.com/nodejs/node/pull/16138 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Alessandro Vergani authored
socket.getRecvBufferSize() and socket.getSendBufferSize() do not take any parameter PR-URL: https://github.com/nodejs/node/pull/16183 Reviewed-By:
-
Christina Chan authored
Remove redundant error messages for assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/16043 Reviewed-By:
-
Fadi Asfour authored
PR-URL: https://github.com/nodejs/node/pull/16022 Reviewed-By:
-
Michael Pal authored
PR-URL: https://github.com/nodejs/node/pull/15980 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/15623 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Tim Chon authored
PR-URL: https://github.com/nodejs/node/pull/15846 Reviewed-By:
-
Cheyenne Arrowsmith authored
PR-URL: https://github.com/nodejs/node/pull/15844 Reviewed-By:
-
