- Jul 23, 2022
-
-
Thomas Raoux authored
Improve doc based on post commit review from https://reviews.llvm.org/D123703 Add more details on the op semantic, explicitly mention what part are parallel and what parts are serial. Differential Revision: https://reviews.llvm.org/D125227
-
Greg Clayton authored
[NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute. The FileSpect APIs allow users to modify instance variables directly by getting a non const reference to the directory and filename instance variables. This makes it impossibly to control all of the times the FileSpec object is modified so we can clear the cache. This patch modifies the APIs of FileSpec so no one can modify the directory or filename directly by adding set accessors and by removing the get accessors that are non const. Many clients were using FileSpec::GetCString(...) which returned a unique C string from a ConstString'ified version of the result of GetPath() which returned a std::string. This caused many locations to use this convenient function incorrectly and could cause many strings to be added to the constant string pool that didn't need to. Most clients were converted to using FileSpec::GetPath().c_str() when possible. Other clients were modified to use the newly renamed version of this function which returns an actualy ConstString: ConstString FileSpec::GetPathAsConstString(bool denormalize = true) const; This avoids the issue where people were getting an already uniqued "const char *" that came from a ConstString only to put the "const char *" back into a "ConstString" object. By returning the ConstString instead of a "const char *" clients can be more efficient with the result. The patch: - Removes the non const GetDirectory() and GetFilename() get accessors - Adds set accessors to replace the above functions: SetDirectory() and SetFilename(). - Adds ClearDirectory() and ClearFilename() to replace usage of the FileSpec::GetDirectory().Clear()/FileSpec::GetFilename().Clear() call sites - Fixed all incorrect usage of FileSpec::GetCString() to use FileSpec::GetPath().c_str() where appropriate, and updated other call sites that wanted a ConstString to use the newly returned ConstString appropriately and efficiently. Differential Revision: https://reviews.llvm.org/D130309 -
Thomas Raoux authored
Folding of transfer_write into transfer_read is already supported but this requires the read and write to have the same permuation map. After linalg vectorization it is common to have different ppermuation map for write followed by read even though the cases could be propagated. This canonicalization handle cases where the permuation maps are different but the data read and written match and replace the transfer ops with broadcast and permuation Differential Revision: https://reviews.llvm.org/D130135
-
Alex Brachet authored
The llvm-driver build is not enabled on any bots so this wasn't caught earlier.
-
Dylan Fleming authored
This patch aims to create a webpage to document Flang's command line options on https://flang.llvm.org/docs/ in a similar way to Clang's https://clang.llvm.org/docs/ClangCommandLineReference.html This is done by using clang_tablegen to generate an .rst file from Options.td (which is current shared with Clang) For this to work, ClangOptionDocEmitter.cpp was updated to allow specific Flang flags to be included, rather than bulk excluding clang flags. Note: Some headings in the generated documentation will incorrectly contain references to Clang, e.g. "Flags controlling the behaviour of Clang during compilation" This is because Options.td (Which is shared between both Clang and Flang) contains hard-coded DocBrief sections. I couldn't find a non-intrusive way to make this target-dependant, as such I've left this as is, and it will need revisiting later. Reviewed By: awarzynski Differential Revision: https://reviews.llvm.org/D129864
-
Alex Brachet authored
The standard says two equal pointers must compare equal so there is no need to call the user comparator function in this case. Differential Revision: https://reviews.llvm.org/D130310
-
https://lab.llvm.org/buildbot/#/builders/207/builds/8752zhijian authored
which caused by https://reviews.llvm.org/D127864
-
Konstantin Varlamov authored
Differential Revision: https://reviews.llvm.org/D130321
-
tlattner authored
Remove references to old mailing lists that have moved to discourse. Replace with links to discourse. Reviewed By: #libc_abi, ldionne Differential Revision: https://reviews.llvm.org/D129675
-
Jacques Pienaar authored
Follow up from dialect flip, just flipping accessors. Both forms still generated.
-
Stefan Pintilie authored
This patch modifies only test cases. Converted the MMA test cases to use opaque pointers. Reviewed By: lei, amyk Differential Revision: https://reviews.llvm.org/D130090
-
Simon Pilgrim authored
As noticed on D129765 and reported on Issue #56531 - aarch64 targets can use the neon ctpop + add-reduce instructions to speed up scalar ctpop instructions, but we fail to do this for parity calculations. I'm not sure where the cutoff should be for specific CPUs, but i64 (+ i128 special case) shows a definite reduction in instruction count. i32 is about the same (but scalar <-> neon transfers are probably more costly?), and sub-i32 promotion looks to be a definite regression compared to parity expansion optimized for those widths. Differential Revision: https://reviews.llvm.org/D130246
-
Simon Pilgrim authored
-
Mircea Trofin authored
The name `getEntrySamples` was misleading for 2 reasons. One, it's close in name to `Function::getEntryCount`, but the equivalent here is `getHeadSamples`; second, as opposed to the other get* APIs in `FunctionSamples`, it performs an estimate/heuristic rather than just retrieving raw data (or a non-heuristic derivate off that data, like `getMaxCountInside`) The new name should more clearly communicate its intent; and, being close (in name) to `getHeadSamples`, it should allow the reader discover the relation between them. Also updated the doc comments for both `getHeadSamples[Estimate]` so a reader may better understand the relation between them. Differential Revision: https://reviews.llvm.org/D130281
-
Slava Zakharin authored
This commit changes how math intrinsics are lowered: we, first, try to lower them into MLIR operations or libm calls via mathOperations table and only then fallback to pgmath runtime calls. The pgmath fallback is needed, because mathOperations does not support all intrinsics that pgmath supports. The main purpose of this change is to get rid of llvmIntrinsics table so that we do not have to update both llvmIntrinsics and mathOperations when adding new intrinsic support. mathOperations lowering should phase out pgmath lowering, when more operations are available (e.g. power operations being added in D129809 and D129811; complex type operations from Complex dialect). Differential Revision: https://reviews.llvm.org/D130129
-
- Jul 22, 2022
-
-
Slava Zakharin authored
This commit addresses concerns raised in D129497. Differential Revision: https://reviews.llvm.org/D130300
-
Shilei Tian authored
Revert "[OpenMP][DeviceRTL] Fix the issue that multiple calls to `omp_get_wtime` is optimized out by mistake" This reverts commit ad34f1db.
-
Benjamin Kramer authored
-
Shilei Tian authored
[OpenMP][DeviceRTL] Fix the issue that multiple calls to `omp_get_wtime` is optimized out by mistake Multiple calls to `omp_get_wtime` could be optimized out due to the function is mistakenly marked as `readnone`. This patch fixes the issue, and also add the support to run optimization on `libomptarget` tests. Reviewed By: jdoerfert Differential Revision: https://reviews.llvm.org/D130179
-
Craig Topper authored
We were looking for loads or any_extend+load. reduceLoadWidth hasn't known how to look through such an any_extend to find the load since D40667 almost 5 years ago. Reviewed By: RKSimon Differential Revision: https://reviews.llvm.org/D130333
-
Philip Reames authored
Reorganize the code to make it clear what is and isn't handle, and why. Restructure bailout to remove (false and confusing) dependence on CM_Scalarize; just return invalid cost and propagate, that's what it is for.
-
Jeff Niu authored
This warning was added because using attribute or type assembly formats with `skipDefaultBuilders` set could cause compilation errors, since the required builder prototype may not necessarily be generated and would need to be checked by hand. This patch removes the warning because a warning that the generated C++ "might" not compile is not particularly useful. Attempting to address the TODO (i.e. detect whether a builder of the correct prototype is provided) would be fragile since it would not be possible to account for implicit conversions, etc. In general, ODS should not be emitting warnings in cases like these. Reviewed By: rriddle, wrengr Differential Revision: https://reviews.llvm.org/D130102
-
VitalyR authored
Reviewed by: Yaxun Liu Differential Revision: https://reviews.llvm.org/D130168 Change-Id: Ia00c3dfa9ea20e61235817fd4bb61d33c7c98a60
-
Sam Estep authored
Depends On D130304 This patch pulls the `ApplyBuiltinTransfer` from the `TypeErasedDataflowAnalysis` class into a new `DataflowAnalysisOptions` struct, to allow us to add additional options later without breaking existing code. Reviewed By: gribozavr2, sgatev Differential Revision: https://reviews.llvm.org/D130305
-
Maksim Panchenko authored
The latest perf tool can return non-empty buffer when executing buildid-list command, even when perf.data was recorded with -B flag. Some binaries will be listed without the ID, while others may have a recorded ID. Allow invalid entires on the input, while checking the valid ones for the match. Reviewed By: Amir Differential Revision: https://reviews.llvm.org/D130223
-
Malhar Jajoo authored
This patch adds a command line flag to be able to test the type based cost-model analysis for Intrinsics. Differential Revision: https://reviews.llvm.org/D129109
-
Tue Ly authored
With correctly rounded implementations, these functions will be tested for all rounding modes. Since fegetround and fesetround are not implemented for arm32, these tests will fail in all non-default rounding modes. We will re-enable these entrypoints and tests once fegetround and fesetround are implemented for arm32.
-
Shubham Narlawar authored
GEP's across basic blocks were not getting splitted due to EnableGEPOpt which was turned off by default. Hence, EarlyCSE missed the opportunity to eliminate common part of GEP's. This can be achieved by simply turning GEP pass on. - This patch moves SeparateConstOffsetFromGEPPass() just before LSR. - It enables EnableGEPOpt by default. Resolves - https://github.com/llvm/llvm-project/issues/50528 Added an unit test. Differential Revision: https://reviews.llvm.org/D128582
-
Jacques Pienaar authored
Scope ops file to ops. Used canonicalization as grouping for canonicalization patterns and folders (also considered OpTransforms but that felt too generic and the former two are used together). Reviewed By: silvas, rsuderman Differential Revision: https://reviews.llvm.org/D130297
-
Sam Estep authored
This patch moves `Analysis/FlowSensitive/NoopAnalysis.h` from `clang/unittests/` to `clang/include/clang/`, so that we can use it for doing context-sensitive analysis. Reviewed By: ymandel, gribozavr2, sgatev Differential Revision: https://reviews.llvm.org/D130304
-
Nikita Popov authored
Move this out of the switch, so that different branches can indicate an error by breaking out of the switch. This becomes important if there are more than the two current error cases.
-
Tue Ly authored
Implement sinf function that is correctly rounded to all rounding modes. - We use a simple range reduction for `pi/16 < |x|` : Let `k = round(x / pi)` and `y = (x/pi) - k`. So `k` is an integer and `-0.5 <= y <= 0.5`. Then ``` sin(x) = sin(y*pi + k*pi) = (-1)^(k & 1) * sin(y*pi) ~ (-1)^(k & 1) * y * P(y^2) ``` where `y*P(y^2)` is a degree-15 minimax polynomial generated by Sollya with: ``` > P = fpminimax(sin(x*pi)/x, [|0, 2, 4, 6, 8, 10, 12, 14|], [|D...|], [0, 0.5]); ``` - Performance benchmark using perf tool from CORE-MATH project (https://gitlab.inria.fr/core-math/core-math/-/tree/master) on Ryzen 1700: Before this patch (not correctly rounded): ``` $ CORE_MATH_PERF_MODE="rdtsc" ./perf.sh sinf CORE-MATH reciprocal throughput : 17.892 System LIBC reciprocal throughput : 25.559 LIBC reciprocal throughput : 29.381 ``` After this patch (correctly rounded): ``` $ CORE_MATH_PERF_MODE="... -
zhijian authored
Summary: 1. Added a new option object mode -X for llvm-ar. In AIX OS , there is a object mode option -X for ar command. please see the "-X mode" part of https://www.ibm.com/docs/ko/aix/7.1?topic=ar-command Specifies the type of object file ar should examine. The mode must be one of the following: 32 Processes only 32-bit object files 64 Processes only 64-bit object files 32_64 Processes both 32-bit and 64-bit object files any Processes all of the supported object files. The default is to process 32-bit object files (ignore 64-bit objects). The mode can also be set with the OBJECT_MODE environment variable. For example, OBJECT_MODE=64 causes ar to process any 64-bit objects and ignore 32-bit objects. The -X flag overrides the OBJECT_MODE variable. 2. Before adding the new option -X, the default behaviors of llvm-ar like -Xany, but after the adding the new option -X, the default behaviors of llvm-ar change to -X32 ,in order to let some test cases which has 32bit and 64bit object file in the same llvm-ar command, we need to add the "export OBJECT_MODE=any" into test case to change the default behaviors of llvm-ar's object mode. Reviewers: James Henderson, Owen Reynolds, Fangrui Song Differential Revision: https://reviews.llvm.org/D127864
-
Joseph Huber authored
Previously we made `libomptarget` link as an LLVM library so we have access to the LLVM core libraries. After the initial patch stuck we can now apply the same changes to the plugins. This will allow us to use LLVM in all of `libomptarget` when we have uses for them. In the future this should allow us to remove the dependencies on `libelf`, `libffi`, and `dl`. Reviewed By: JonChesterfield Differential Revision: https://reviews.llvm.org/D130262
-
Egor Zhdan authored
This is the same change as https://reviews.llvm.org/D126289, but applied for OpenBSD & FreeBSD. Differential Revision: https://reviews.llvm.org/D129654
-
Tue Ly authored
Add float type and flag for nearest integer to automatically test with and without SSE4.2 flag. Reviewed By: sivachandra Differential Revision: https://reviews.llvm.org/D129916
-
Kiran Chandramohan authored
Add a constraint to ensure that the operand and result of the threadprivate operation are the same. Reviewed By: peixin Differential Revision: https://reviews.llvm.org/D128609
-
Kiran Chandramohan authored
The Conversion pattern enables conversion of Critical Op with block arguments. Fixes https://github.com/llvm/llvm-project/issues/56629 Reviewed By: shraiysh Differential Revision: https://reviews.llvm.org/D130343
-
Nikita Popov authored
Opaque pointers support is complete and default. Specify ptr as the normal pointer type and i8* as something supported under non-default options. A larger update of examples in LangRef is still needed.
-
Kadir Cetinkaya authored
This could crash when our heuristic picks the wrong function. Make sure there is enough parameters in the candidate to prevent those crashes. Also special case copy/move constructors to make the heuristic work in presence of those. Fixes https://github.com/llvm/llvm-project/issues/56620 Differential Revision: https://reviews.llvm.org/D130260
-