1. Apr 17, 2020
    • Jonas Devlieghere's avatar
      [lldb/Reproducers] Simplify LLDB_RECORD macros · a3237f86
      Jonas Devlieghere authored
      Redefine the LLDB_RECORD macros in terms of a common uber-macro to
      reduce code duplication across them.
      
      Differential revision: https://reviews.llvm.org/D78141
      a3237f86
    • Roman Lebedev's avatar
      [OpenMPOpt] deduplicateRuntimeCalls(): avoid traditional map lookup pitfall · b1fbf438
      Roman Lebedev authored
      Summary:
      This roughly halves time spent in that pass,
      while unsurprisingly significantly reducing total memory usage.
      
      This makes sense because most functions won't use any openmp functions..
      
      old
      ```
         0.2329 (  0.5%)   0.0409 (  0.9%)   0.2738 (  0.5%)   0.2736 (  0.5%)  OpenMP specific optimizations
      ```
      ```
      total runtime: 63.32s.
      bytes allocated in total (ignoring deallocations): 8.34GB (131.70MB/s)
      calls to allocation functions: 14526259 (229410/s)
      temporary memory allocations: 3335760 (52680/s)
      peak heap memory consumption: 324.36MB
      peak RSS (including heaptrack overhead): 5.39GB
      total memory leaked: 289.93MB
      ```
      
      new
      ```
         0.1457 (  0.3%)   0.0276 (  0.6%)   0.1732 (  0.3%)   0.1731 (  0.3%)  OpenMP specific optimizations
      ```
      ```
      total runtime: 55.01s.
      bytes allocated in total (ignoring deallocations): 6.70GB (121.89MB/s)
      calls to allocation functions: 14268205 (259398/s)
      temporary memory allocations: 3225355 (58637/s)
      peak heap memory consumption: 324.09MB
      peak RSS (including heaptrack overhead): 5.39GB
      total memory leaked: 289.87MB
      ```
      
      diff
      ```
      total runtime: -8.31s.
      bytes allocated in total (ignoring deallocations): -1.63GB (196.58MB/s)
      calls to allocation functions: -258054 (31034/s)
      temporary memory allocations: -110405 (13277/s)
      peak heap memory consumption: -262.36KB
      peak RSS (including heaptrack overhead): 0B
      total memory leaked: -61.45KB
      ```
      
      Reviewers: jdoerfert, hfinkel
      
      Reviewed By: jdoerfert
      
      Subscribers: yaxunl, hiraditya, guansong, llvm-commits
      
      Tags: #llvm
      
      Differential Revision: https://reviews.llvm.org/D78299
      b1fbf438
    • Louis Dionne's avatar
      [libc++] Simplify conditional in __config for _LIBCPP_NO_RTTI · 8079f8a7
      Louis Dionne authored
      We don't support GCC's older than 5.x anymore.
      8079f8a7
    • Kang Zhang's avatar
      [PowerPC] Ignore implicit register operands for MCInst · 513976df
      Kang Zhang authored
      Summary:
      When doing the conversion: MachineInst -> MCInst, we should ignore the
      implicit operands, it will expose more opportunity for InstiAlias.
      
      Reviewed By: steven.zhang
      
      Differential Revision: https://reviews.llvm.org/D77118
      513976df
    • Simon Pilgrim's avatar
    • Simon Pilgrim's avatar
      MCInstrDesc.h - move MCSubtargetInfo forward declaration down to MCInstrInfo.h. NFC. · e7fc3566
      Simon Pilgrim authored
      Remove unused FeatureBitset forward declaration
      e7fc3566
    • Simon Pilgrim's avatar
      e1dc1ae0
    • Simon Pilgrim's avatar
      MCAsmBackend.h - cleanup includes and forward declarations. NFC. · 56e70fe8
      Simon Pilgrim authored
      Replace StringRef.h include to forward declaration
      Remove MCFragment/MCRelaxableFragment forward declarations - these are included in MCFragment.h
      56e70fe8
    • Dmitry Polukhin's avatar
      Revert "[clang][AST] Support AST files larger than 512M" · a8f85da9
      Dmitry Polukhin authored
      Bitcode file alignment is only 32-bit so 64-bit offsets need
      special handling.
      /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:6327:28: runtime error: load of misaligned address 0x7fca2bcfe54c for type 'const uint64_t' (aka 'const unsigned long'), which requires 8 byte alignment
      0x7fca2bcfe54c: note: pointer points here
        00 00 00 00 5a a6 01 00  00 00 00 00 19 a7 01 00  00 00 00 00 48 a7 01 00  00 00 00 00 7d a7 01 00
                    ^
          #0 0x3be2fe4 in clang::ASTReader::TypeCursorForIndex(unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:6327:28
          #1 0x3be30a0 in clang::ASTReader::readTypeRecord(unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:6348:24
          #2 0x3bd3d4a in clang::ASTReader::GetType(unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:6985:26
          #3 0x3c5d9ae in clang::ASTDeclReader::Visit(clang::Decl*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReaderDecl.cpp:533:31
          #4 0x3c91cac in clang::ASTReader::ReadDeclRecord(unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReaderDecl.cpp:4045:10
          #5 0x3bd4fb1 in clang::ASTReader::GetDecl(unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:7352:5
          #6 0x3bce2f9 in clang::ASTReader::ReadASTBlock(clang::serialization::ModuleFile&, unsigned int) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:3625:22
          #7 0x3bd6d75 in clang::ASTReader::ReadAST(llvm::StringRef, clang::serialization::ModuleKind, clang::SourceLocation, unsigned int, llvm::SmallVectorImpl<clang::ASTReader::ImportedSubmodule>*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Serialization/ASTReader.cpp:4230:32
          #8 0x3a6b415 in clang::CompilerInstance::createPCHExternalASTSource(llvm::StringRef, llvm::StringRef, bool, bool, clang::Preprocessor&, clang::InMemoryModuleCache&, clang::ASTContext&, clang::PCHContainerReader const&, llvm::ArrayRef<std::shared_ptr<clang::ModuleFileExtension> >, llvm::ArrayRef<std::shared_ptr<clang::DependencyCollector> >, void*, bool, bool, bool) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Frontend/CompilerInstance.cpp:539:19
          #9 0x3a6b00e in clang::CompilerInstance::createPCHExternalASTSource(llvm::StringRef, bool, bool, void*, bool) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Frontend/CompilerInstance.cpp:501:18
          #10 0x3abac80 in clang::FrontendAction::BeginSourceFile(clang::CompilerInstance&, clang::FrontendInputFile const&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Frontend/FrontendAction.cpp:865:12
          #11 0x3a6e61c in clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/Frontend/CompilerInstance.cpp:972:13
          #12 0x3ba74bf in clang::ExecuteCompilerInvocation(clang::CompilerInstance*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:282:25
          #13 0xa3f753 in cc1_main(llvm::ArrayRef<char const*>, char const*, void*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/tools/driver/cc1_main.cpp:240:15
          #14 0xa3a68a in ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&) /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/tools/driver/driver.cpp:330:12
          #15 0xa37f31 in main /b/sanitizer-x86_64-linux-fast/build/llvm-project/clang/tools/driver/driver.cpp:407:12
          #16 0x7fca2a7032e0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
          #17 0xa21029 in _start (/b/sanitizer-x86_64-linux-fast/build/llvm_build_ubsan/bin/clang-11+0xa21029)
      
      This reverts commit 30d5946d.
      a8f85da9
    • Uday Bondhugula's avatar
      [MLIR] NFC use Operation::getParentWithTrait in alloca verifier · dfcc403b
      Uday Bondhugula authored
      Use recently added accessor Operation::getParentWithTrait in alloca
      verifier.
      
      Differential Revision: https://reviews.llvm.org/D78296
      dfcc403b
  2. Apr 16, 2020
    • Melanie Blower's avatar
    • Siva Chandra Reddy's avatar
      [libc] Move implementations of cosf, sinf, sincosf to src/math directory. · 5fedf7f4
      Siva Chandra Reddy authored
      NFC intended in the implementaton. Only mechanical changes to fit the LLVM
      libc implementation standard have been done.
      
      Math testing infrastructure has been added. This infrastructure compares the
      results produced by the libc with the high precision results from MPFR.
      Tests making use of this infrastructure have been added for cosf, sinf and
      sincosf.
      
      Reviewers: abrachet, phosek
      
      Differential Revision: https://reviews.llvm.org/D76825
      5fedf7f4
    • David Green's avatar
      [MachineSink] Fix for breaking phi edges with instructions with multiple defs · 44c4ba34
      David Green authored
      BreakPHIEdge would be set based on whether the instruction needs to
      insert a new critical edge to allow sinking into a block where the uses
      are PHI nodes. But for instructions with multiple defs it would be reset
      on the second def, allowing the instruciton to sink where it should not.
      
      Fixes PR44981
      
      Differential Revision: https://reviews.llvm.org/D78087
      44c4ba34
    • Uday Bondhugula's avatar
      [MLIR] Fix MLIR build - add missing CMake dependency · ea88dd82
      Uday Bondhugula authored
      This will fix a failure when using a linker sensitive to the order in
      which libraries are passed.
      
      Differential Revision: https://reviews.llvm.org/D78303
      ea88dd82
    • Mehdi Chinoune's avatar
      [flang] Use the Flang cmake-functions to add targets. · 2d6b9dbf
      Mehdi Chinoune authored
      Summary: It also removes the cycle-dependency between FortranSemantics and FortranEvaluate.
      
      Reviewers: #flang, jdoerfert, sscalpone
      
      Reviewed By: #flang, sscalpone
      
      Subscribers: DavidTruby, schweitz, tskeith, mgorny, aartbik, llvm-commits
      
      Tags: #flang, #llvm
      
      Differential Revision: https://reviews.llvm.org/D78215
      2d6b9dbf
    • Dmitry Polukhin's avatar
      [clang][AST] Support AST files larger than 512M · 30d5946d
      Dmitry Polukhin authored
      Summary:
      Clang uses 32-bit integers for storing bit offsets from the beginning of
      the file that results in 512M limit on AST file. This diff replaces
      absolute offsets with relative offsets from the beginning of
      corresponding data structure when it is possible. And uses 64-bit
      offsets for DeclOffests and TypeOffssts because these coder AST
      section may easily exceeds 512M alone.
      
      This diff breaks AST file format compatibility so VERSION_MAJOR bumped.
      
      Test Plan:
      Existing clang AST serialization tests
      Tested on clangd with ~700M and ~900M preamble files
      
      Reviewers: rsmith, dexonsmith
      
      Subscribers: ilya-biryukov, kadircet, usaxena95, cfe-commits
      
      Tags: #clang
      
      Differential Revision: https://reviews.llvm.org/D76594
      30d5946d
    • Simon Pilgrim's avatar
      MCValue.h - cleanup include and forward declaration. NFC. · f701d8fa
      Simon Pilgrim authored
      Remove MCSymbol.h include
      Remove unused MCAsmInfo forward declaration
      f701d8fa
    • Gabor Marton's avatar
      [ASTImporter] Fix bug introduced in 2ba4e3a4 · e033ec29
      Gabor Marton authored
      2ba4e3a4 (Move FPFeatures from BinaryOperator bitfields to Trailing
      storage, D76384) introduced an assertion failure during CTU analysis.
      The reason is that in ASTNodeImporter::VisitCompoundAssignOperator the
      LHSType and the ResultType have been imported twice.
      
      Details:
      clang: ../../git/llvm-project/clang/lib/Basic/SourceManager.cpp:918: clang::FileID clang::SourceManager::getFileIDLoaded(unsigned int) const: Assertion `0 && "Invalid SLocOffset or bad function choice"' failed.
      clang::SourceManager::getDecomposedExpansionLoc(clang::SourceLocation) const
      clang::SourceManager::getPresumedLoc(clang::SourceLocation, bool) const
      clang::ASTImporter::Import(clang::SourceLocation)
      llvm::Error clang::ASTImporter::importInto<clang::SourceLocation>(clang::SourceLocation&, clang::SourceLocation const&)
      clang::ASTNodeImporter::ImportDeclParts(clang::NamedDecl*, clang::DeclContext*&, clang::DeclContext*&, clang::DeclarationName&, clang::NamedDecl*&, clang::SourceLocation&)
      clang::ASTNodeImporter::VisitRecordDecl(clang::RecordDecl*)
      clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*)
      clang::ASTImporter::Import(clang::Decl*)
      clang::ASTNodeImporter::VisitRecordType(clang::RecordType const*)
      clang::TypeVisitor<clang::ASTNodeImporter, llvm::Expected<clang::QualType> >::Visit(clang::Type const*)
      clang::ASTImporter::Import(clang::QualType)
      clang::ASTNodeImporter::VisitElaboratedType(clang::ElaboratedType const*)
      clang::TypeVisitor<clang::ASTNodeImporter, llvm::Expected<clang::QualType> >::Visit(clang::Type const*)
      clang::ASTImporter::Import(clang::QualType)
      clang::ASTNodeImporter::VisitPointerType(clang::PointerType const*)
      clang::TypeVisitor<clang::ASTNodeImporter, llvm::Expected<clang::QualType> >::Visit(clang::Type const*)
      clang::ASTImporter::Import(clang::QualType)
      clang::QualType clang::ASTNodeImporter::importChecked<clang::QualType>(llvm::Error&, clang::QualType const&)
      clang::ASTNodeImporter::VisitCompoundAssignOperator(clang::CompoundAssignOperator*)
      e033ec29
    • Simon Pilgrim's avatar
    • Simon Pilgrim's avatar
      MCObjectWriter.h - remove unnecessary includes. NFC · 1cbd6a58
      Simon Pilgrim authored
      The EndianStream.h/raw_ostream.h headers should be removed as well but we have a lot of other files that are implicitly relying on them being present.
      1cbd6a58
    • Simon Pilgrim's avatar
      WasmEHFuncInfo.h - reduce BasicBlock.h/MachineBasicBlock.h includes to just... · d9e81aab
      Simon Pilgrim authored
      WasmEHFuncInfo.h - reduce BasicBlock.h/MachineBasicBlock.h includes to just forward declarations. NFC.
      d9e81aab
    • Louis Dionne's avatar
      [libc++] Support arbitrary .sh.X extensions in the new format · ebd90232
      Louis Dionne authored
      This allows writing all kinds of ShTests, for example .sh.py tests for
      testing Python code.
      ebd90232
    • Nicolas Vasilache's avatar
      [mlir][Linalg] Drop function attribute from generic ops. · f5431227
      Nicolas Vasilache authored
      The function attribute in generic ops is not paying for itself.
      A region is the more standardized way of specifying a custom computation.
      If needed this region can call a function directly.
      This is deemed more natural than managing a dedicated function attribute.
      
      This also simplifies named ops generation by trimming unnecessary complexity.
      
      Differential Revision: https://reviews.llvm.org/D78266
      f5431227
    • Aaron Ballman's avatar
      Disallow [[nodiscard]] on a function pointer declaration. · 2ec5520a
      Aaron Ballman authored
      This is not allowed by [dcl.attr.nodiscard]p1 for the standard attribute, but
      is still supported for the [[clang::warn_unused_result]] spelling.
      2ec5520a
    • Bjorn Pettersson's avatar
      [Float2Int] Stop passing around a reference to the class member Roots. NFC · fdf9bad5
      Bjorn Pettersson authored
      The Float2IntPass got a class member called Roots, but Roots
      was also passed around to member function as a reference. This
      patch simply remove those references.
      fdf9bad5
    • Jonathan Coe's avatar
      [clang-format] Do not interpret C# deconstruction in a foreach as a cast · 07c1978b
      Jonathan Coe authored
      Reviewers: krasimir
      
      Reviewed By: krasimir
      
      Subscribers: cfe-commits, MyDeveloperDay
      
      Tags: #clang-format, #clang
      
      Differential Revision: https://reviews.llvm.org/D78295
      07c1978b
    • Ulysse Beaugnon's avatar
      [MLIR] Add IndexAttr to primitive attributes kinds in tablegen. · 11f093fa
      Ulysse Beaugnon authored
      OpBase.td defined attributes kind for all integer types expect index. This
      commit fixes that by adding an IndexAttr attribute kind. Update the
      respective tests.
      
      Differential Revision: https://reviews.llvm.org/D78195
      11f093fa
    • Kazushi (Jam) Marukawa's avatar
      [VE] Update logical operation instructions · 48d64f56
      Kazushi (Jam) Marukawa authored
      Summary:
      Changing all mnemonic to match assembly instructions to simplify mnemonic
      naming rules. This time update all fixed-point arithmetic instructions.
      This also corrects bswp operand type.
      
      Reviewed By: simoll
      
      Differential Revision: https://reviews.llvm.org/D78177
      48d64f56
    • Benjamin Kramer's avatar
      Revert "[MLIR] Add IndexAttr to primitive attributes kinds in tablegen." · d9c7fc65
      Benjamin Kramer authored
      This reverts commit 997f33cf. Breaks check-mlir
      
      ******************** TEST 'MLIR :: IR/attribute.mlir' FAILED ********************
      Script:
      --
      : 'RUN: at line 1';   mlir-opt llvm-project/mlir/test/IR/attribute.mlir -split-input-file -verify-diagnostics | /FileCheck llvm-project/mlir/test/IR/attribute.mlir
      --
      Exit Code: 1
      
      Command Output (stderr):
      --
      llvm-project/mlir/test/IR/attribute.mlir split at line #1:19:3: error: unexpected error: 'test.int_attrs' op requires attribute 'index_attr'
        "test.int_attrs"() {
        ^
      llvm-project/mlir/test/IR/attribute.mlir split at line #120:6:3: error: unexpected error: 'test.int_attrs' op requires attribute 'index_attr'
        "test.int_attrs"() {
        ^
      llvm-project/mlir/test/IR/attribute.mlir split at line #120:5:6: error: expected error "'si32_attr' failed to satisfy constraint: 32-bit signed integer attribute" was not produced
        // expected-error @+1 {{'si32_attr' failed to satisfy constraint: 32-bit signed integer attribute}}
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      llvm-project/mlir/test/IR/attribute.mlir split at line #133:5:3: error: unexpected error: 'test.int_attrs' op requires attribute 'index_attr'
        "test.int_attrs"() {
        ^
      llvm-project/mlir/test/IR/attribute.mlir split at line #133:4:6: error: expected error "'ui32_attr' failed to satisfy constraint: 32-bit unsigned integer attribute" was not produced
        // expected-error @+1 {{'ui32_attr' failed to satisfy constraint: 32-bit unsigned integer attribute}}
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      llvm-project/mlir/test/IR/attribute.mlir:9:12: error: CHECK: expected string not found in input
       // CHECK: any_i32_attr = 5 : ui32
                 ^
      <stdin>:3:1: note: scanning from here
      module {
      ^
      <stdin>:21:28: note: possible intended match here
       "test.non_negative_int_attr"() {i32attr = 5 : i32, i64attr = 10 : i64} : () -> ()
      d9c7fc65
    • Stephan Herhut's avatar
      [MLIR] Allow for multiple gpu modules during translation. · 69040d5b
      Stephan Herhut authored
      This change makes the ModuleTranslation threadsafe by locking on the
      LLVMContext. Furthermore, we now clone the llvm module into a new
      context when compiling to PTX similar to what the OrcJit does.
      
      Differential Revision: https://reviews.llvm.org/D78207
      69040d5b
    • Simon Pilgrim's avatar
      yaml2obj.h - cleanup includes and forward declaration. NFC. · da207407
      Simon Pilgrim authored
      Reduce StringRef.h/Error.h includes to just the necessary STLExtras.h include and StringRef/Twine forward declarations
      Remove unused Expected<> forward declaration
      da207407
    • Simon Pilgrim's avatar
      Parser.h/cpp - cleanup includes and forward declaration. NFC. · b9a8e787
      Simon Pilgrim authored
      Parser.h - Reduce MemoryBuffer.h include to just the necessary StringRef.h include and MemoryBufferRef forward declaration
      Parser.cpp - Remove unused raw_ostream.h include
      b9a8e787
    • Simon Pilgrim's avatar
      Pass.h/cpp - cleanup includes and forward declaration. NFC. · ee66b5b0
      Simon Pilgrim authored
      Remove unused BasicBlock forward declaration from Pass.h and Attributes/BasicBlock includes from Pass.cpp
      Add BasicBlock forward declaration to UnifyFunctionExitNodes.h which was relying on Pass.h
      ee66b5b0
    • Matthias Gehre's avatar
      6d2f73f8
    • Henry Jen's avatar
      Expose AtomicType in the libclang C API. · 38ca7b11
      Henry Jen authored
      38ca7b11
    • Benjamin Kramer's avatar
      Revert "[LifetimeAnalysis] Add [[gsl::Pointer]] to llvm::StringRef" · bac85ab3
      Benjamin Kramer authored
      This reverts commit 83d5131d. Spams
      llvm/ADT/StringRef.h:57:11: warning: unknown attribute 'Pointer' ignored [-Wunknown-attributes]
      bac85ab3
    • Sergej Jaskiewicz's avatar
      5cef3107
    • Georgii Rymar's avatar
      [FileCheck] - Fix the false positive when -implicit-check-not is used with an... · 65a2de7e
      Georgii Rymar authored
      [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.
      
      Imagine we have the following invocation:
      
      `FileCheck -check-prefix=UNKNOWN-PREFIX -implicit-check-not=something`
      
      When the check prefix does not exist it does not fail.
      This patch fixes the issue.
      
      Differential revision: https://reviews.llvm.org/D78024
      65a2de7e
    • Kirill Bobyrev's avatar
      [clangd] Pull installed gRPC and introduce clangd-remote-(server|client) · cee80c04
      Kirill Bobyrev authored
      Summary:
      This patch allows using installed gRPC to build two simple tools which
      currently provide the functionality of looking up the symbol by name.
      remote-index-client is a simplified version of dexp which connects to
      remote-index-server passes lookup requests.
      
      I also significantly reduced the scope of this patch to prevent large changelist
      and more bugs. The next steps would be:
      
      * Extending Protocol for deep copies of Symbol and inherit RemoteIndex from
        Index to unify the interfaces
      * Make remote-index-server more generic and merge the remote index client with
        dexp
      * Modify Clangd to allow using remote index instead of the local one for all
        global index requests
      
      Reviewers: sammccall
      
      Reviewed By: sammccall
      
      Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits
      
      Tags: #clang
      
      Differential Revision: https://reviews.llvm.org/D77794
      cee80c04
    • Konstantin Schwarz's avatar
      [MIR] Add comments to INLINEASM immediate flag MachineOperands · 1a3e89aa
      Konstantin Schwarz authored
      Summary:
      The INLINEASM MIR instructions use immediate operands to encode the values of some operands.
      The MachineInstr pretty printer function already handles those operands and prints human readable annotations instead of the immediates. This patch adds similar annotations to the output of the MIRPrinter, however uses the new MIROperandComment feature.
      
      Reviewers: SjoerdMeijer, arsenm, efriedma
      
      Reviewed By: arsenm
      
      Subscribers: qcolombet, sdardis, jvesely, wdng, nhaehnle, hiraditya, jrtc27, atanasyan, kerbowa, llvm-commits
      
      Tags: #llvm
      
      Differential Revision: https://reviews.llvm.org/D78088
      1a3e89aa