- Jun 23, 2023
-
-
Nikita Popov authored
-
Ivan Kosarev authored
Now that we have proper support for optional operands, the standard LLVM machinery can take care of converting parsed instructions to MCInsts. There are likely more cases where the conversion can be done automatically, probably with some additional treatment. The plan is to address them separately. Part of <https://github.com/llvm/llvm-project/issues/62629>. Reviewed By: arsenm, foad Differential Revision: https://reviews.llvm.org/D153565
-
Ivan Kosarev authored
Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D152903
-
Nikita Popov authored
The DataLayout alloca address space is the address space that should be used when creating new allocas. However, not all allocas are required to be in this address space. The isKnownNonZero() check should work on the actual address space of the alloca, not the default alloca address space.
-
Aaron Ballman authored
When implicitly defining a function in C, we would try to find an appropriate declaration context for the function to be declared within. However, we did not account for GNU statement expressions, which masquerade as a compound statement and can be used in other contexts such as within structure member declarations. Fixes https://github.com/llvm/llvm-project/issues/48579
-
Michael Platings authored
A common user mistake is specifying a target of aarch64-none-eabi or arm-none-elf whereas the correct names are aarch64-none-elf & arm-none-eabi. Currently if a target of aarch64-none-eabi is specified then the Generic_ELF toolchain is used, unlike aarch64-none-elf which will use the BareMetal toolchain. This is unlikely to be intended by the user so issue a warning that the target is invalid. The target parser is liberal in what input it accepts so invalid triples may yield behaviour that's sufficiently close to what the user intended. Therefore invalid triples were used in many tests. This change updates those tests to use valid triples. One test (gnu-mcount.c) relies on the Generic_ELF toolchain behaviour so change it to explicitly specify aarch64-unknown-none-gnu as the target. Reviewed By: peter.smith, DavidSpickett Differential Revision: https://reviews.llvm.org/D153430
-
Luke Lau authored
The current instruction's pointer operand may be different from the one specified in the Operands argument. We should use the pointer operand from here instead in case the user has transformed it. This manifested itself somewhere down the line in https://reviews.llvm.org/D149889, but I haven't been able to create a test case on its own yet unfortunately. Reviewed By: nikic Differential Revision: https://reviews.llvm.org/D153574
-
Nikita Popov authored
The object size and alignment based restriction on the possible allocation range also applies to allocas, not just globals, so handle them as well. We shouldn't really need any type restriction here at all, but for now stay conservative.
-
Nikita Popov authored
-
David Green authored
Including some tests with mixed minnum/minimum reductions and removing the fast from fmin/fmax reductions as those should not be needed.
-
Serge Pavlov authored
GNU addr2line exits immediately if it cannot open the file specified as executable/relocatable. In contrast llvm-addr2line does not exit and, if addresses are not specified in command line, waits for input on stdin. This causes the test compiler-rt/test/asan/TestCases/Posix/asan-symbolize-bad-path.cc to block forever on Gentoo (see https://reviews.llvm.org/rG27c4777f41d2ab204c1cf84ff1cccd5ba41354da#1190273). To fix this issue the behavior llvm-addr2line now exits if executable/relocatable file cannot be found. It fixes https://github.com/llvm/llvm-project/issues/42099 (llvm-addr2line does not exit when passed a non-existent file). Differential Revision: https://reviews.llvm.org/D147652
-
Nikita Popov authored
These are pretty common in SCEV, so make sure we get a precise result by mapping to the sub() operation.
-
Igor Kirillov authored
Revert "Revert "[CodeGen] Extend reduction support in ComplexDeinterleaving pass to support predication"" Adds the capability to recognize SelectInst that appear in the IR. These instructions are generated during scalable vectorization for reduction and when the code contains conditions inside the loop body or when "-prefer-predicate-over-epilogue=predicate-dont-vectorize" is set. Differential Revision: https://reviews.llvm.org/D152558 This reverts commit ab096548. Reason: Reapplying after removing unnecessary default case in switch expression.
-
Ties Stuij authored
[ARM] generate armv6m eXecute Only (XO) code for immediates, globals Previously eXecute Only (XO) support was implemented for targets that support MOVW/MOVT (~armv7+). See: https://reviews.llvm.org/D27449 XO prevents the compiler from generating data accesses to code sections. This patch implements XO codegen for armv6-M, which does not support MOVW/MOVT, and must resort to the following general pattern to avoid loads: movs r3, :upper8_15:foo lsls r3, #8 adds r3, :upper0_7:foo lsls r3, #8 adds r3, :lower8_15:foo lsls r3, #8 adds r3, :lower0_7:foo ldr r3, [r3] This is equivalent to the code pattern generated by GCC. The above relocations are new to LLVM and have been implemented in a parent patch: https://reviews.llvm.org/D149443. This patch limits itself to implementing codegen for this pattern and enabling XO for armv6-M in the backend. Separate patches will follow for: - switch tables - replacing specific loads from constant islands which are spread out over the ARM backend codebase. Amongst others: FastISel, call lowering, stack frames. Reviewed By: john.brawn Differential Revision: https://reviews.llvm.org/D152795
-
pvanhout authored
It was overdue for a clang-format run, and it avoids unrelated formatting changes sneaking into diffs.
-
pvanhout authored
Accidentally copy-pasted them into the .cpp while refactoring the file in D151432 Those functions are currently only used in the .cpp so it didn't cause an issue, but it causes an undefined reference if another file attempts to use them.
-
Jolanta Jensen authored
This patch removes DAG combines that are no longer relevant because equivalent IR combines have been added. Differential Revision: https://reviews.llvm.org/D153445
-
Jeremy Furtek authored
This diff adds APFloat support for a semantic that matches the TF32 data type used by some accelerators (most notably GPUs from both NVIDIA and AMD). For more information on the TF32 data type, see https://blogs.nvidia.com/blog/2020/05/14/tensorfloat-32-precision-format/. Some intrinsics that support the TF32 data type were added in https://reviews.llvm.org/D122044. For some discussion on supporting common semantics in `APFloat`, see similar efforts for 8-bit formats at https://reviews.llvm.org/D146441, as well as https://discourse.llvm.org/t/rfc-adding-the-amd-graphcore-maybe-others-float8-formats-to-apfloat/67969. A subsequent diff will extend MLIR to use this data type. (Those changes are not part of this diff to simplify the review process.) Reviewed By: mehdi_amini Differential Revision: https://reviews.llvm.org/D151923
-
Kazu Hirata authored
Differential Revision: https://reviews.llvm.org/D153615
-
Kazu Hirata authored
The corresponding function definition was removed by: commit 773d663e Author: Arthur Eubanks <aeubanks@google.com> Date: Mon Feb 27 19:00:37 2023 -0800
-
Tamás Danyluk authored
If a value is already the last element of the worklist, then I think that we don't have to add it again, it is not needed to process it repeatedly. For some long Triton-generated LLVM IR, this can cause a ~100x speedup. Differential Revision: https://reviews.llvm.org/D153561
-
Alex Zinenko authored
Wrapping a warning into a silenceable failure will result in the warning being interpreted as an error, which it is not. Reviewed By: nicolasvasilache Differential Revision: https://reviews.llvm.org/D153546
-
Alex Zinenko authored
When exiting the scope of a region attached to a transform op, clean up the handle invalidation checks assocaited with handles defined in this region. Otherwise, these checks may trigger on the next entry to the region while there is no incorrect usage. Reviewed By: springerm Differential Revision: https://reviews.llvm.org/D153545
-
Balázs Kéri authored
Fix for issue #62770. Reviewed By: donat.nagy Differential Revision: https://reviews.llvm.org/D153424
-
Dhruv Chawla authored
When the sign of either of the operands is known, it is possible to determine what the saturating value will be without having to compute it using the sign bits. Differential Revision: https://reviews.llvm.org/D153575
-
Dhruv Chawla authored
-
Kazu Hirata authored
Differential Revision: https://reviews.llvm.org/D153610
-
Ulrich Weigand authored
This makes the bytecode reader/writer work on big-endian platforms. The only problem was related to encoding of multi-byte integers, where both reader and writer code make implicit assumptions about endianness of the host platform. This fixes the current test failures on s390x, and in addition allows to remove the UNSUPPORTED markers from all other bytecode-related test cases - they now also all pass on s390x. Also adding a GFAIL_SKIP to the MultiModuleWithResource unit test, as this still fails due to an unrelated endian bug regarding decoding of external resources. Differential Revision: https://reviews.llvm.org/D153567 Reviewed By: mehdi_amini, jpienaar, rriddle
-
Haojian Wu authored
Remove the existing `Rng` field. From the review comment: https://reviews.llvm.org/D147034 Reviewed By: kadircet Differential Revision: https://reviews.llvm.org/D153259
-
Jean Perier authored
Use hlfir::loadTrivialScalars to dereference pointer, allocatables, and load numerical and logical scalars. This has a small fallout on tests: - load is done on the HLFIR entity (#0 of hlfir.declare) and not the FIR one (#1). This makes no difference at the FIR level (#1 and #0 only differs to account for assumed and explicit shape lower bounds). - loadTrivialScalars get rids of allocatable fir.box for monomoprhic scalars (it is not needed). This exposed a bug in lowering of MERGE with a polymorphic and a monomorphic argument: when the monomorphic is not a fir.box, the polymorphic fir.class should not be reboxed but its address should be read. Reviewed By: tblah Differential Revision: https://reviews.llvm.org/D153252
-
Martin Braenne authored
- The AST of the function we're currently analyzing - The CFG - The CFG element we're currently processing Reviewed By: ymandel Differential Revision: https://reviews.llvm.org/D153549
-
Kazu Hirata authored
The declaration was added without a corresponding class definition by: commit 13bb8f49 Author: Stella Laurenzo <laurenzo@google.com> Date: Wed Apr 3 11:16:32 2019 -0700
-
Kazu Hirata authored
The declaration was added without a corresponding class definition by: commit a84064bc Author: Florian Hahn <flo@fhahn.com> Date: Wed Dec 21 22:02:31 2022 +0000 It is most likely a misspelling of PredicatedScalarEvolution.
-
Kazu Hirata authored
-
Jacques Pienaar authored
Allows for single op nested regions.
-
Kazu Hirata authored
The declaration was added without a corresponding function by: commit cc3bb855 Author: James Nagurne <j-nagurne@ti.com> Date: Fri Oct 22 17:08:16 2021 -0500
-
Jon Chesterfield authored
NFC. Simplifies process slightly, gives more options for testing it. Reviewed By: jhuber6 Differential Revision: https://reviews.llvm.org/D153604
-
Jon Chesterfield authored
Private member variable minimises scope of access to Process Reviewed By: jhuber6 Differential Revision: https://reviews.llvm.org/D153603
-
Oleksii Lozovskyi authored
Instead of dumping all sources into RTXray object library with a weird special case for x86, handle multiarch builds better. Build a separate object library for each arch with its arch-specific sources, then link in all those libraries. This fixes the build on platforms that produce fat binaries, such as new macOS which expects both x86_64 and aarch64 objects in the same library since Apple Silicon is a thing. This only enables building XRay support for Apple Silicon. It does not actually work yet on macOS, neither on Intel nor on Apple Silicon CPUs. Thus the tests are still disabled. Reviewed By: MaskRay, phosek Differential Revision: https://reviews.llvm.org/D153221
-
Jon Chesterfield authored
CMake plumbing cargo culted from other tests. Minor changes to Process to allow statically allocating a buffer. Reviewed By: jhuber6 Differential Revision: https://reviews.llvm.org/D153594
-