Skip to content
GitLab
  1. Nov 07, 2023
  3. Nov 06, 2023
  5. Nov 03, 2023
  7. Nov 02, 2023
  9. Nov 01, 2023
    • Marc Durdin's avatar
      fix(developer): restore selection in layout builder even with duplicate ids · bd2315db
      Marc Durdin authored 
      Fixes #7851.

Note that this fixes the selection pop issue with duplicate ids in some
scenarios but not all. For example, the undo stack doesn't have enough
detail at this point to be able to track this. This fix addresses the
most egregious issue relating to key size adjustment and similar.
      bd2315db
    • Marc Durdin's avatar
      fix(developer): warn if layer switch key is missing ID · 15523dfe
      Marc Durdin authored 
      Fixes #8000.

In earlier versions of KeymanWeb, it was assumed that layer switch keys
would not necessarily need an identifier, as they would not be
generating a standard KeymanWeb key event. However, this assumption does
not really hold, so we should be warning on missing identifiers for
layer switch keys.
      15523dfe
    • Marc Durdin's avatar
      chore(developer): rename messages.ts for clarity · 0ec76f07
      Marc Durdin authored 
      Renames two messages.ts to kmn-compiler-messages.ts and
kmw-compiler-messages.ts, as otherwise confusion reigns.

Also a minor cleanup of the error messages from touch layout processing,
to clarify message names and return appropriate message for missing
layout file.
      0ec76f07
    • Marc Durdin's avatar
      fix(developer): don't use osk-always-visible on touch devices · 4ce16a08
      Marc Durdin authored 
      Fixes #9845.

It seems that the logic for `osk-always-visible` is not quite right on
touch devices -- the OSK disappears on blur but remains touchable -- so
presses in the OSK region emit key events. For Keyman Developer Server,
the simple workaround is to only use `<body class="osk-always-visible">`
when on desktop devices.

We should review the logic for `osk-always-visible` in KeymanWeb, so
that this issue does not arise on touch devices. This patch addresses
the issue in Keyman Developer Server, and matches the behaviour we want
on touch devices in any case, as we don't really want the OSK visible
when blurred, unlike on desktop.
      4ce16a08
    • Marc Durdin's avatar
      fix(developer): layout builder - maintain presentation during undo · c759414e
      Marc Durdin authored 
      Fixes #7852.

When undo is run in the layout builder, it is better to keep the user's
selected presentation if possible. (The selected presentation is not
stored in the undo stack, but is a view property affected by the
currently selected platform.)
      c759414e