Skip to content
GitLab
  1. Jun 19, 2020
  3. Jun 13, 2020
  5. Jun 12, 2020
  7. Jun 11, 2020
  9. Jun 10, 2020
  11. Jun 05, 2020
  13. Jun 04, 2020
  15. Jun 03, 2020
  17. May 29, 2020
    • Albert Chen's avatar
      Implement InstanceTarget Behavior for Dedup + EliminateTargetPaths (#1539) · 0845fcdb
      Albert Chen authored 
      

- RenameMap Behavior
-- Prevent transitive renaming A -> B -> C (continueRenaming)
-- Prevent transitive renaming for self-renames

- Target
-- Override toString as serialize for CompleteTarget
-- Expansion of stripHierarchy to enable stripping InstanceTargets to become ModuleTargets
Annotations
-- Bugfix in extractComponents where Products were not iterated over
-- Converts renamed targets to local targets using Target.referringModule to preserve sticky behavior

- Eliminate Target Paths
-- Make DuplicationHelper use LinkedHashMap, as we iterate over its contents and convert to Seq in def makePathless
-- Add DupedResult to map original module to new module targets
-- Update renaming to record a map from all relative instance paths to original module, to new module target
-- Consumes DedupedResult to give better name to new duplicated module if it was originally deduplicated
-- Reorder modules in attempt to preserve original ordering, pre-deduplication
-- Move utility functions to object
-- Bugfix: add self-renames to prevent ofModule _ of target _ cannot be renamed to Vector(_, _, _, ...) errors

- Dedup
-- Changed NoDedupAnnotation to contain ModuleTarget, rather than ModuleName
-- Added DedupedResult to map original module to the duplicate module
-- Consumes DupedResult to pick better name, if it existed
-- Updates renaming to chain the following: instancify deduped modules, remap differently named internal signals, then remap AST modules
-- Move utility functions to object
-- Remove annotations as part of determination of dedup correctness
-- Bugfix: add instance renames so that deduped modules have their instances properly renamed

- Dead Code Elimination
-- Add deletion of ASTModules

- Tests
-- Morphism Spec to ensure Dedup -> EliminateTargetPaths and EliminateTargetPaths -> Dedup patterns work properly
-- Update existing tests to make sure they work properly
-- Add Dedup tests to demonstrate instance renaming bug, EliminateTargetPaths for ofModule rename bug, and update RenameMap tests

Co-authored-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
Co-authored-by: default avatarAdam Izraelevitz <adam.izraelevitz@sifive.com>
Co-authored-by: default avatarAdam Izraelevitz <azidar@gmail.com>
Co-authored-by: default avatarJack Koenig <koenig@sifive.com>
      0845fcdb
  19. May 27, 2020
    • Schuyler Eldridge's avatar
      Make WrappedTransform work with --class-log-level (#1640) · 01919d31
      Schuyler Eldridge authored 
      

Change WrappedTransforms to be sensitive to the --class-log-level of
their true underlying transform. In effect, information logged in a
wrapper (like timing information) will now print as expected.

Signed-off-by: default avatarSchuyler Eldridge <schuyler.eldridge@ibm.com>
      01919d31
    • Albert Magyar's avatar
      Cleanup unused imports (no-warning docs req from CI) · 2fba1d30
      Albert Magyar authored
      2fba1d30
    • Albert Magyar's avatar
      Remove trivially dead code from now-redundant WIR/IR match patterns · 5d486688
      Albert Magyar authored
      5d486688
    • Albert Magyar's avatar
      [API change] Absorb repetitive WIR nodes into IR · dddb53fa
      Albert Magyar authored 
      * Absorb WRef into Reference
* Absorb WSubField into SubField
* Absorb WSubIndex into SubIndex
* Absorb WSubAccess into SubAccess
* Absorb WDefInstance into DefInstance

------------------------- API CHANGE SEVERITY --------------------------
This is projected to not break source-level compatibility with any known
user code. However, it will break *binary* compatibility with all
existing user FIRRTL passes, as is generally allowed with major
releases of FIRRTL.

--------------------------- DESCRIPTION --------------------------------
Previously, there were several nodes in WIR.scala that had a one-to-one
correspondance with existing nodes in the standard firrtl.ir hierarchy.
These nodes would have a case class resembling the corresponding
standard IR node, but with the addition of one or more "analysis"
fields.

Since these fields (such as kind) represent helpful info that can be
invalidated or set to Unknown (e.g. UnknownKind for Kind), it does not
cause any issues to simply include these fields on any in-memory
representation of FIRRTL IR. Although other systems for tracking FIRRTL
analyses have evolved over time, the ubiquity of pattern-matching on
these fields has lead most core and custom transforms to be written
against WIR, rather than IR.

This PR unifies the IRs by adding the fields that would be in an
"augmented" WIR node directly into the corresponding IR node; i.e., the
"type" and "kind" fields from WRef are added directly to the definition
of the Reference case class, while these "repetitive" WIR case classes
are removed entirely.

-------------------- SOURCE-COMPATIBILITY ADAPTERS ---------------------

Several object methods are added to WIR.scala to maintain
source-compatiblity for passes that used WIR. These objects define
factory methods and unapply methods, so passes that relied on implicit
case class factories or pattern matching for the removed WIR types will
remain perfectly source-compatible. However, these do not guarantee
compatibility at the binary level.

The types of the removed WIR case classes are also added as type aliases
to the top-level firrtl package, which allows code that relies on
explicit constructor calls or reflection to retain source-compatibility.

Finally, additional explicit factory methods are added to the companion
objects of the newly-augmented IR case classes, which allows user code
to avoid having to specify any of the new analysis fields. Existing code
that created non-WIR IR nodes will be able to continue using the
previous factory signatures, which will cause all omitted analysis
fields to be set to Unknown.

---------------------- UNMITIGATED API CHANGES -------------------------

While passes that used WIR will be source-compatible with this change,
there is one significant change that affects any pass currently using
non-WIR IR: the signatures of pattern-matching cases for Reference,
SubField, SubIndex, SubAccess, and DefInstance must change to
accommodate the extra fields.

This cannot be worked at the API level due to restrictions on unapply
overloading, but it could theoretically be solved with macros or other
static rewriting. However, only four core transforms (RemoveProto,
ToWorkingIR, Dedup, and RemoveChirrtl) use non-WIR IR, and it is
expected that no user code currently relies on it, so the expected
migration strategy is simply to change the small fraction of code
relying on these nodes.
      dddb53fa
  21. May 23, 2020
  23. May 22, 2020
  25. May 20, 2020
  27. May 19, 2020
  29. May 18, 2020
  31. May 15, 2020