For traits or abstract classes that extend Bundle but have no concrete
methods, the plugin will print a benign warning that the user cannot
fix. It will no longer print that warning.

(cherry picked from commit ed4a9818

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit f9aee1f7

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

In Scala 2.13, Auto-application to `()` is deprecated. Any nullary
method (ie. a method with no arguments) that is defined with () must now
be called with (). @chiselName used to inject a case of this warning
into user code which would then cause a warning on the @chiselName macro
that the user has no way to fix.

(cherry picked from commit ca902680

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

The difference in logic depth for various paths now has a maximum of 1.

Also make treeReduce order the same for 2.12 and 2.13

.grouped(_) returns an Iterator
.toSeq on an Iterator returns a Stream in 2.12 and a List in 2.13
This can lead to changes in order when bumping from 2.12 to 2.13 that
can be avoided by simply using an eager collection explicitly.

Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 6975f77f

)

Co-authored-by: Martin Schoeberl <martin@jopdesign.com>

Fixes #2470

(cherry picked from commit 44165a25

)

Co-authored-by: Kevin Laeufer <laeufer@cs.berkeley.edu>

This is a quick fix for issue #2408

(cherry picked from commit d4ef9a96

)

Co-authored-by: Kevin Laeufer <laeufer@cs.berkeley.edu>

(cherry picked from commit 52165fe2

)

Co-authored-by: Lucheng Zhang <79909456+geekLucian@users.noreply.github.com>

(cherry picked from commit d6a357d2

)

Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Loosen restrictions on clocks to enable them to be connected to
DontCare, i.e., be invalidated.

Co-authored-by: Jack Koenig <koenig@sifive.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>

Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 5d8a0c8e

)

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>

* Use a single field instead of two in HasId (4-bytes per HasId)
* Set the prefix to Nil after setting ref to free up memory

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 3aa179f0

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Capture 1:1 mappings of Aggregates inside of views

This is implemented by including any corresponding Aggregates from the
DataView.mapping in the AggregateViewBinding.childMap (which is now of
type Map[Data, Data]).

This enables dynamically indexing Vecs that are themselves elements of
larger Aggregates in views when the corresponding element of the view is
a Vec of the same type. It also increases the number of cases where a
single Target can represent part of a view.

(cherry picked from commit 1f6b1ca1)

* Add FlatIO API for creating ports from Bundles without a prefix

(cherry picked from commit 772a3a1f)

* [docs] Add FlatIO to the general cookbook

(cherry picked from commit b4159641

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

* During sanitize, only filter the String if needed
* Do not recurse on name, saving an unnecessary call to sanitize

(cherry picked from commit 559b3df3

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 3940136b

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 4da1e89f

)

Co-authored-by: fzi-hielscher <47524191+fzi-hielscher@users.noreply.github.com>

This reduces memory use of every HasId by 64 bytes.

Every instance of HasId (including all Data) had 2 ListBuffer vals for
recording post-naming hooks, yet this feature is almost never used.
These are now vars of type List which allows the common case of Nil to
add no incremental memory use per instance of HasId.

(cherry picked from commit cf410180

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit 2c2d72ce

)

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>

(cherry picked from commit d4dd2119

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

Chisel <> semantics differ somewhat from FIRRTL <= semantics,
so we only emit <= when it would be legal. Otherwise we continue
the old behavior of emitting a connection for every leaf-level
Element.

Co-authored-by: Deborah Soung <debs@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 3553a158

)

Co-authored-by: Jared Barocsi <82000041+jared-barocsi@users.noreply.github.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>

Also delete an errant println in InstanceSpec

(cherry picked from commit 3462c54c

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 73d3c260

)

Co-authored-by: Liu Xiaoyi <circuitcoder0@gmail.com>

* Tweaks to the Verilog-vs-Chisel Page

* Update cookbook.md

* Update verilog-vs-chisel.md

* Update verilog-vs-chisel.md

(cherry picked from commit 7432bdff

)

Co-authored-by: Megan Wachs <megan@sifive.com>

(cherry picked from commit 98fdfc5e

)

Co-authored-by: Megan Wachs <megan@sifive.com>

* Issue errors on out-of-range extracts when width is known

Firrtl will catch this later on, but better to error early if possible.

* Test that errors are generated on OOB extracts when width is known

(cherry picked from commit 462def42

)

Co-authored-by: Andrew Waterman <andrew@sifive.com>

Co-authored-by: Shola Ogunkelu @Shorla
Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: Deborah Soung <debs@sifive.com>

Completed as part of Outreachy Internship Dec 2021-March 2022.

(cherry picked from commit 362702f3

)

Co-authored-by: Olushola Ogunkelu <77856859+Shorla@users.noreply.github.com>

Widths are now padded to the maximum width of the inputs.

Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 546b4e13

)

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>

(cherry picked from commit 2a985ac3

)

Co-authored-by: Deborah Soung <debs@sifive.com>

(cherry picked from commit 024847d7

)

Co-authored-by: Megan Wachs <megan@sifive.com>

(cherry picked from commit b55dc36d

)

Co-authored-by: Carlos Eduardo <me@carlosedp.com>

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 01575574

)

Co-authored-by: Tynan McAuley <tynan@galois.com>

* Only call _elementsImpl once in Bundle.elements

* Distinguish compiler plugin and reflective _elementsImpl

Bundle.elements now will only do post-processing if the user is using
plugin-generated _elementsImpl. This improves performance for the case
where the user does not opt-in to using the plugin to generate
_elementsImpl.

(cherry picked from commit 5fead89e

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 055a8529

)

Co-authored-by: John Ingalls <43973001+ingallsj@users.noreply.github.com>

* Change type of Bundle._elementsImpl to Iterable

It was previously SeqMap (ListMap on Scala 2.12). This change gives us
more freedom to optimize the implementation without breaking binary
compatibility. It is scala.collection.Iterable because it is perfectly
fine to return mutable collections (like Arrays) since the only use is
to Iterate on them.

* Disallow users implementing Bundle._elementsImpl

Currently, it would result in a runtime linkage error. This turns it
into a compile-time error.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 1b05a14a

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

Use Builder.deprecated instead of Builder.warning so that the warnings
are aggregated by source locator to prevent spamming the screen with
duplicated warnings.

(cherry picked from commit 538e223a

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

(cherry picked from commit 551854b2

)

Co-authored-by: Jack Koenig <koenig@sifive.com>

* Improve error reporting (#2376)

* Do not trim stack traces of exceptions with no stack trace

This prevents us from accidentally giving stack traces to exceptions
that don't have them and giving misleading messages telling users to use
--full-stacktrace when it won't actually do anything.

Also deprecate ChiselException.chiselStackTrace which is no longer being
used anywhere in this codebase.

* Add exception class for multiple-errors reported

New chisel3.internal.Errors replaces old anonymous class that would show
up as chisel3.internal.ErrorLog$$anon$1 in error messages.

* Add new option --throw-on-first-error

This tells Chisel not to aggregate recoverable errors but instead to
throw an exception on the first one. This gives a stack trace for users
who need it for debugging.

(cherry picked from commit ff2e9c92

)

* Waive MiMa false positives

The waived change is to a package private constructor.

Co-authored-by: Jack Koenig <koenig@sifive.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Warn if clock at memory instantiation differs from clock bound at port
creation and port clock is not manually passed

Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 465805ec

)

Co-authored-by: Aditya Naik <91489422+adkian-sifive@users.noreply.github.com>

Adds generation of `Bundle.elements` method to the chores done by the compiler plugin
For each `Bundle` find the relevant visible Chisel field members and construct a
hard-coded list of the elements and their names implemented as `_elementsImpl`

For more details: See plugins/README.md

- Should be no change in API
- Handles inheritance and mixins
- Handles Seq[Data]
- Tests in BundleElementSpec

Co-authored-by: chick <chick.markley@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
(cherry picked from commit 237200a4

)

Co-authored-by: Chick Markley <chick@qrhino.com>

* Fix the QMC bug for constant and dontcare output.
* Fix the Espresso bug for constant and dontcare output.

(cherry picked from commit 46b53320

)

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>

(cherry picked from commit 13fb4595

)

Co-authored-by: Adam Izraelevitz <adam.izraelevitz@sifive.com>