diff options
| author | Erhan Kurubas <erhan.kurubas@espressif.com> | 2022-05-28 22:31:34 +0200 |
|---|---|---|
| committer | Tomas Vanek <vanekt@fbl.cz> | 2022-06-08 08:46:09 +0000 |
| commit | 822097a351f8aef0036359bc3f4ad3972c1ddbe3 (patch) | |
| tree | 41a3fdaf7c2d51f42360196864e581db61daecd0 /src | |
| parent | 4f42600541d2f96a3a134699091e12179c82401a (diff) | |
| download | riscv-openocd-822097a351f8aef0036359bc3f4ad3972c1ddbe3.zip riscv-openocd-822097a351f8aef0036359bc3f4ad3972c1ddbe3.tar.gz riscv-openocd-822097a351f8aef0036359bc3f4ad3972c1ddbe3.tar.bz2 | |
telnet_server: fix valgrind error
Error: Uninitialised value was created by a heap allocation
at telnet_new_connection (telnet_server.c:227)
Signed-off-by: Erhan Kurubas <erhan.kurubas@espressif.com>
Change-Id: I698a3648be698c93a2395a718ee1ade028226995
Reviewed-on: https://review.openocd.org/c/openocd/+/7006
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Diffstat (limited to 'src')
| -rw-r--r-- | src/server/telnet_server.c | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/src/server/telnet_server.c b/src/server/telnet_server.c index 791a1a5..4fc71f3 100644 --- a/src/server/telnet_server.c +++ b/src/server/telnet_server.c @@ -222,9 +222,8 @@ static int telnet_new_connection(struct connection *connection) { struct telnet_connection *telnet_connection; struct telnet_service *telnet_service = connection->service->priv; - int i; - telnet_connection = malloc(sizeof(struct telnet_connection)); + telnet_connection = calloc(1, sizeof(struct telnet_connection)); if (!telnet_connection) { LOG_ERROR("Failed to allocate telnet connection."); @@ -234,9 +233,6 @@ static int telnet_new_connection(struct connection *connection) connection->priv = telnet_connection; /* initialize telnet connection information */ - telnet_connection->closed = false; - telnet_connection->line_size = 0; - telnet_connection->line_cursor = 0; telnet_connection->prompt = strdup("> "); telnet_connection->prompt_visible = true; telnet_connection->state = TELNET_STATE_DATA; @@ -257,11 +253,6 @@ static int telnet_new_connection(struct connection *connection) telnet_write(connection, "\r", 1); telnet_prompt(connection); - /* initialize history */ - for (i = 0; i < TELNET_LINE_HISTORY_SIZE; i++) - telnet_connection->history[i] = NULL; - telnet_connection->next_history = 0; - telnet_connection->current_history = 0; telnet_load_history(telnet_connection); log_add_callback(telnet_log_callback, connection); |