diff options
| author | Ben Marshall <ben-marshall@users.noreply.github.com> | 2021-01-04 23:22:53 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-04 15:22:53 -0800 |
| commit | 94be3245041c5102f5fdd8016b4ca98a578d6512 (patch) | |
| tree | 4afc98b802bf03a0ee3604c66438dfc15cd41b47 /isa | |
| parent | 7d069666a5841e5e5b3ba1723c6af26925a35a9c (diff) | |
| download | riscv-tests-94be3245041c5102f5fdd8016b4ca98a578d6512.zip riscv-tests-94be3245041c5102f5fdd8016b4ca98a578d6512.tar.gz riscv-tests-94be3245041c5102f5fdd8016b4ca98a578d6512.tar.bz2 | |
Disable rv32ua/rv64ua LR/SC test case 4 (#316)
- After discussion in riscv/riscv-tests#315, disable this test case, as it
makes implementation assumptions which are not valid with respect to the
specification.
- Leave code present but commented out.
On branch dev/benm-disable-lrsc-test-4
Changes to be committed:
modified: isa/rv64ua/lrsc.S
Diffstat (limited to 'isa')
| -rw-r--r-- | isa/rv64ua/lrsc.S | 22 |
1 files changed, 14 insertions, 8 deletions
diff --git a/isa/rv64ua/lrsc.S b/isa/rv64ua/lrsc.S index c7589d7..5711f8d 100644 --- a/isa/rv64ua/lrsc.S +++ b/isa/rv64ua/lrsc.S @@ -37,14 +37,20 @@ TEST_CASE( 3, a4, 0, \ lw a4, foo; \ ) -# make sure that sc with the wrong reservation fails. -# TODO is this actually mandatory behavior? -TEST_CASE( 4, a4, 1, \ - la a0, foo; \ - la a1, fooTest3; \ - lr.w a1, (a1); \ - sc.w a4, a1, (a0); \ -) +# +# Disable test case 4 for now. It assumes a <1K reservation granule, when +# in reality any size granule is valid. After discussion in issue #315, +# decided to simply disable the test for now. +# (See https://github.com/riscv/riscv-tests/issues/315) +# +## make sure that sc with the wrong reservation fails. +## TODO is this actually mandatory behavior? +#TEST_CASE( 4, a4, 1, \ +# la a0, foo; \ +# la a1, fooTest3; \ +# lr.w a1, (a1); \ +# sc.w a4, a1, (a0); \ +#) #define LOG_ITERATIONS 10 |