From 94be3245041c5102f5fdd8016b4ca98a578d6512 Mon Sep 17 00:00:00 2001 From: Ben Marshall Date: Mon, 4 Jan 2021 23:22:53 +0000 Subject: Disable rv32ua/rv64ua LR/SC test case 4 (#316) - After discussion in riscv/riscv-tests#315, disable this test case, as it makes implementation assumptions which are not valid with respect to the specification. - Leave code present but commented out. On branch dev/benm-disable-lrsc-test-4 Changes to be committed: modified: isa/rv64ua/lrsc.S --- isa/rv64ua/lrsc.S | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) (limited to 'isa') diff --git a/isa/rv64ua/lrsc.S b/isa/rv64ua/lrsc.S index c7589d7..5711f8d 100644 --- a/isa/rv64ua/lrsc.S +++ b/isa/rv64ua/lrsc.S @@ -37,14 +37,20 @@ TEST_CASE( 3, a4, 0, \ lw a4, foo; \ ) -# make sure that sc with the wrong reservation fails. -# TODO is this actually mandatory behavior? -TEST_CASE( 4, a4, 1, \ - la a0, foo; \ - la a1, fooTest3; \ - lr.w a1, (a1); \ - sc.w a4, a1, (a0); \ -) +# +# Disable test case 4 for now. It assumes a <1K reservation granule, when +# in reality any size granule is valid. After discussion in issue #315, +# decided to simply disable the test for now. +# (See https://github.com/riscv/riscv-tests/issues/315) +# +## make sure that sc with the wrong reservation fails. +## TODO is this actually mandatory behavior? +#TEST_CASE( 4, a4, 1, \ +# la a0, foo; \ +# la a1, fooTest3; \ +# lr.w a1, (a1); \ +# sc.w a4, a1, (a0); \ +#) #define LOG_ITERATIONS 10 -- cgit v1.1