diff options
author | Elvis Wang <elvis.wang@sifive.com> | 2024-11-28 15:07:36 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-11-28 15:07:36 +0800 |
commit | 9ea5be639d31560faec993b4aebb3e10c7d4c8e2 (patch) | |
tree | fc74f8f71a1eefb8e5ad6c5fad05374e09f019d5 /llvm/lib | |
parent | d36a4c07156de01b05ea41d5876c671de64e99c6 (diff) | |
download | llvm-9ea5be639d31560faec993b4aebb3e10c7d4c8e2.zip llvm-9ea5be639d31560faec993b4aebb3e10c7d4c8e2.tar.gz llvm-9ea5be639d31560faec993b4aebb3e10c7d4c8e2.tar.bz2 |
Recommit "[LV][VPlan] Remove any-of reduction from precomputeCost. NFC (#117109)" (#117289)
Update the test cases contains `any-of` printings from the
precomputeCost().
Origin message:
The any-of reduction contains phi and select instructions.
The select instruction might be optimized and removed in the vplan which
may cause VF difference between legacy and VPlan-based model. But if the
select instruction be removed, planContainsAdditionalSimplifications()
will catch it and disable the assertion.
Therefore, we can just remove the ayn-of reduction calculation in the
precomputeCost().
Recommit "[LV][VPlan] Remove any-of reduction from precomputeCost. NFC
(#117109)"
Diffstat (limited to 'llvm/lib')
-rw-r--r-- | llvm/lib/Transforms/Vectorize/LoopVectorize.cpp | 24 |
1 files changed, 2 insertions, 22 deletions
diff --git a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp index d68a262..95a5c65 100644 --- a/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp +++ b/llvm/lib/Transforms/Vectorize/LoopVectorize.cpp @@ -7303,34 +7303,14 @@ LoopVectorizationPlanner::precomputeCosts(VPlan &Plan, ElementCount VF, // The legacy cost model has special logic to compute the cost of in-loop // reductions, which may be smaller than the sum of all instructions involved - // in the reduction. For AnyOf reductions, VPlan codegen may remove the select - // which the legacy cost model uses to assign cost. Pre-compute their costs - // for now. + // in the reduction. // TODO: Switch to costing based on VPlan once the logic has been ported. for (const auto &[RedPhi, RdxDesc] : Legal->getReductionVars()) { if (ForceTargetInstructionCost.getNumOccurrences()) continue; - if (!CM.isInLoopReduction(RedPhi) && - !RecurrenceDescriptor::isAnyOfRecurrenceKind( - RdxDesc.getRecurrenceKind())) - continue; - - // AnyOf reduction codegen may remove the select. To match the legacy cost - // model, pre-compute the cost for AnyOf reductions here. - if (RecurrenceDescriptor::isAnyOfRecurrenceKind( - RdxDesc.getRecurrenceKind())) { - auto *Select = cast<SelectInst>(*find_if( - RedPhi->users(), [](User *U) { return isa<SelectInst>(U); })); - assert(!CostCtx.SkipCostComputation.contains(Select) && - "reduction op visited multiple times"); - CostCtx.SkipCostComputation.insert(Select); - auto ReductionCost = CostCtx.getLegacyCost(Select, VF); - LLVM_DEBUG(dbgs() << "Cost of " << ReductionCost << " for VF " << VF - << ":\n any-of reduction " << *Select << "\n"); - Cost += ReductionCost; + if (!CM.isInLoopReduction(RedPhi)) continue; - } const auto &ChainOps = RdxDesc.getReductionOpChain(RedPhi, OrigLoop); SetVector<Instruction *> ChainOpsAndOperands(ChainOps.begin(), |