You need to sign in or sign up before continuing.
- Nov 01, 2021
-
-
Rich Trott authored
Update mdast-util-to-markdown to 1.2.4 which reduces unnecessary escaping of `_` and some other characters. Re-run markdown formatter. PR-URL: https://github.com/nodejs/node/pull/40645 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
- Oct 07, 2021
-
-
Rich Trott authored
Use `make format-md` to format general markdown files. PR-URL: https://github.com/nodejs/node/pull/40322 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
- Sep 21, 2021
-
-
Rich Trott authored
Fix formatting that will change when run through upcoming remark preset. PR-URL: https://github.com/nodejs/node/pull/40154 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
- Feb 28, 2021
-
-
Michael Dawson authored
Change the top level docs to use HEAD in links Signed-off-by:
Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/37494 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
- Feb 01, 2021
-
-
Akash Negi authored
This corresponds to the format at https://developercertificate.org/. PR-URL: https://github.com/nodejs/node/pull/37138 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Pooja D P <Pooja.D.P@ibm.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
- Jan 16, 2021
-
-
Rich Trott authored
This section isn't particularly useful in this context and contributes to making the document longer and less effective. This is part of a larger effort to make the contributing docs brief, informative, and friendly. Refs: https://github.com/nodejs/TSC/issues/864#issuecomment-628646560 PR-URL: https://github.com/nodejs/node/pull/36905 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
- Jan 15, 2021
-
-
Rich Trott authored
Remove "How to Contribute in Issues". This is not Node.js-specific and is likely to cause many readers to tune out. If we want to include this kind of how-all-issue-trackers-are-intended-to-work information, let's link to an external source. But I think it's OK to simply remove it. Refs: https://github.com/nodejs/TSC/issues/864#issuecomment-628646560 PR-URL: https://github.com/nodejs/node/pull/36891 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
- Mar 04, 2020
-
-
ConorDavenport authored
* Updated cpp style guide file name and location and fixed links to this file. * Updated collaborator guide file name and location and fixed links to this file. * Updated documentation style guide file name and location and updated links referencing the file. * Moved files to appropriate location and updated naming style for some of them. Fixes: https://github.com/nodejs/node/issues/31741 PR-URL: https://github.com/nodejs/node/pull/31792 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
- Sep 23, 2019
-
-
Maledong authored
Remove the number '11' as the suffix anchor id for the 'Developer's Certificate of Origin 1.1'. PR-URL: https://github.com/nodejs/node/pull/29468 Refs: https://github.com/nodejs/node/pull/6257 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Nov 05, 2018
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/24010 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
- Oct 02, 2018
-
-
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/23140 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
- Jan 24, 2018
-
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18271 Fixes: https://github.com/nodejs/node/issues/17842 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Jan 04, 2018
-
-
Rich Trott authored
* Remove redundant "blocking it or stopping it" as blocking and stopping are the same thing in this case. * Make another sentence less wordy. Fix incorrect verb conjugation. Break into two clear sentences. PR-URL: https://github.com/nodejs/node/pull/17931 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
Remove incorrect usage of "in which". The sentence is better and shorter without it anyway. Replace incorrect "with" with "in". PR-URL: https://github.com/nodejs/node/pull/17930 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
- Dec 19, 2017
-
-
Rich Trott authored
Make the preamble to CONTRIBUTING.md more concise and focused. PR-URL: https://github.com/nodejs/node/pull/17700 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Dec 02, 2017
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17384 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
- Nov 28, 2017
-
-
Myles Borins authored
The CoC and moderation guidelines now live in the Admin repo. This PR updates the copy of CODE_OF_CONDUCT.md and references in other documents to the proper location. PR-URL: https://github.com/nodejs/node/pull/17301 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
- Nov 24, 2017
-
-
Ronald Eddy Jr authored
PR-URL: https://github.com/nodejs/node/pull/17261 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
- Nov 11, 2017
-
-
Maton Anthony authored
Add informations to CONTRIBUTING.md requesting the committers and especially the one working on breaking changes to write proper commits messages containing the reason behind the breaking changes, the case during which it can be triggered, and a description of the breaking change in itself. PR-URL: https://github.com/nodejs/node/pull/16846 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
- Oct 30, 2017
-
-
James M Snell authored
Allow commit message first line to exceed 50 chars if necessary PR-URL: https://github.com/nodejs/node/pull/16523 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
- Oct 25, 2017
-
-
Daijiro Wachi authored
CONTRIBUTING.md + L857: Unused definition + L861: Unused definition + L863: Unused definition doc/api/assert.md + L719: Unused definition doc/api/async_hooks.md + L460: Missing code-language flag doc/api/child_process.md + L1362: Unused definition doc/api/dns.md + L674: Unused definition doc/api/esm.md + L178: Missing code-language flag doc/api/http.md + L1868: Unused definition + L1887: Unused definition + L1888: Unused definition + L1889: Unused definition + L1916: Unused definition + L1917: Unused definition doc/api/https.md + L260: Unused definition doc/api/os.md + L1226: Unused definition doc/api/process.md + L1888: Unused definition doc/api/stream.md + L2227: Definitions with the same identifier doc/guides/writing-and-running-benchmarks.md + L1: Missing newline character at end of file Refs: https://github.com/nodejs/node/pull/12756 PR-URL: https://github.com/nodejs/node/pull/16385 Reviewed-By:
Anna Henningsen <anna@addaleax.net> ...
-
- Oct 21, 2017
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/16340 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Refs: https://github.com/nodejs/node/pull/16339#issuecomment-338240029
-
- Oct 14, 2017
-
-
Anna Henningsen authored
Ideally, most of these things would be enforced via linter rules. This is a first step into having a style guide that goes beyond what the linter currently enforces. PR-URL: https://github.com/nodejs/node/pull/16090 Fixes: https://github.com/nodejs/node/issues/12636 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Oct 02, 2017
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/15729 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Benjamin Coe authored
You can now run suites for subsystem using shorthand, e.g., http. Switch to black-list of default test folders from white-list. Tests run by 'make test', 'make coverage', etc., now configurable. Stop running known_issues suite when collecting test coverage. PR-URL: https://github.com/nodejs/node/pull/15450 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Sep 14, 2017
-
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/15123 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
- Jun 11, 2017
-
-
Nikolai Vavilov authored
It's impossible to push to git:// URLs. PR-URL: https://github.com/nodejs/node/pull/13602 Fixes: https://github.com/nodejs/node/issues/13600 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
- May 12, 2017
-
-
kysnm authored
PR-URL: https://github.com/nodejs/node/pull/12830 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com>
-
- May 05, 2017
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/12796 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Apr 23, 2017
-
-
Benjamin Fleischer authored
- Can now link to 'Commit Guidelines' from pull requests - Breaks up commit requirements and recommendations PR-URL: https://github.com/nodejs/node/pull/11732 Refs: https://github.com/nodejs/node/pull/11723#issuecomment-284556146 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
- Apr 21, 2017
-
-
Alex Autem authored
PR-URL: https://github.com/nodejs/node/pull/12552 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
- Apr 17, 2017
-
-
Mateusz Konieczny authored
PR-URL: https://github.com/nodejs/node/pull/12444 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
- Apr 05, 2017
-
-
JR McEntee authored
This update changes references to "Mac OS X", "OS X", and "OSX" in markdown files to "macOS". PR-URL: https://github.com/nodejs/node/pull/12106 Fixes: https://github.com/nodejs/node/issues/12086 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Mar 18, 2017
-
-
liusi authored
This PR adds cpp linting to windows build script. After this change, running command `vcbuild lint` will run both cpp linting and javascript linting on a windows machine. PR-URL: https://github.com/nodejs/node/pull/11856 Fixes: https://github.com/nodejs/node/issues/11816 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Mar 17, 2017
-
-
Sam Roberts authored
Put the commit guidelines themselves under a heading to be more prominent, and to allow linking directly to them (instead of the section on how to use git). Link the pull request template to the guidelines, so contributors can find them. PR-URL: https://github.com/nodejs/node/pull/11792 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Mar 06, 2017
-
-
Rich Trott authored
The stability index 3 (Locked) is unused and is being eliminated. Remove it from the documentation about the stability index. Remove mention of the Locked from CONTRIBUTING.md. The remaining text about the stability index is slight and not seemingly valuable. Removing it too. PR-URL: https://github.com/nodejs/node/pull/11661 Ref: https://github.com/nodejs/node/issues/11200 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Feb 17, 2017
-
-
Gibson Fahnestock authored
Also add a reference in CONTRIBUTING.md to it. PR-URL: https://github.com/nodejs/node/pull/11321 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Feb 07, 2017
-
-
Rich Trott authored
Currently, `vcbuild` only supports `jslint`. `vcbuild lint` will not work because there is no `lint` task specified in `vcbuild.bat`. Update documentation to use `vcbuild jslint` instead. PR-URL: https://github.com/nodejs/node/pull/11151 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
- Jan 31, 2017
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/11045 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Michal Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Jan 21, 2017
-
-
Gibson Fahnestock authored
This reverts commit ed9b6c12. PR-URL: https://github.com/nodejs/node/pull/10839 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-