- Mar 02, 2020
-
-
cjihrig authored
Notable changes: - Fix handling of large files in uv_fs_copyfile(). Fixes: https://github.com/nodejs/node/issues/30085 - Fix Android build errors. - uv_sleep() has been added. - uv_interface_addresses() IPv6 netmask support has been fixed. Fixes: https://github.com/nodejs/node/issues/30504 - uv_fs_mkstemp() has been added. PR-URL: https://github.com/nodejs/node/pull/30783 Backport-PR-URL: https://github.com/nodejs/node/pull/31969 Fixes: https://github.com/nodejs/node/issues/30085 Fixes: https://github.com/nodejs/node/issues/30504 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
cjihrig authored
Notable changes: - uv_random() has been added. - More work to read those pesky Windows environment variables. - Several build fixes for Tier 3 platforms (Android, NetBSD, OpenBSD, Haiku). - Stop using fsevents to watch files (using kqueue again). PR-URL: https://github.com/nodejs/node/pull/29996 Backport-PR-URL: https://github.com/nodejs/node/pull/31969 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
cjihrig authored
Notable changes: - `uv_tcp_close_reset()` has been added. - `uv_udp_set_source_membership()` has been added. - A double free in `uv_free_cpu_info()` on OpenBSD has been fixed. - Defined, but empty environment variables can now be read on Windows. - Several improvements to the cmake build process. - The `EILSEQ` error code is now mapped by libuv. PR-URL: https://github.com/nodejs/node/pull/29508 Backport-PR-URL: https://github.com/nodejs/node/pull/31969 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
cjihrig authored
Notable changes: - UV_FS_O_FILEMAP has been added for faster access to memory mapped files on Windows. - uv_fs_mkdir() now returns UV_EINVAL for invalid filenames on Windows. It previously returned UV_ENOENT. - The uv_fs_statfs() API has been added. - The uv_os_environ() and uv_os_free_environ() APIs have been added. Fixes: https://github.com/nodejs/node/issues/28599 Fixes: https://github.com/nodejs/node/issues/28945 Fixes: https://github.com/nodejs/node/issues/29008 PR-URL: https://github.com/nodejs/node/pull/29070 Backport-PR-URL: https://github.com/nodejs/node/pull/31969 Reviewed-By:
-
cjihrig authored
This upgrade is a small patch release, fixing compilation errors on Android, Cygwin, and uClibc - none of which are tested in the CI. PR-URL: https://github.com/nodejs/node/pull/28511 Backport-PR-URL: https://github.com/nodejs/node/pull/31969 Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By:
-
cjihrig authored
Notable changes: - Support for the Haiku platform has been added. - The maximum UV_THREADPOOL_SIZE has been increased from 128 to 1024. - uv_fs_copyfile() now works properly when the source and destination files are the same. PR-URL: https://github.com/nodejs/node/pull/28449 Backport-PR-URL: https://github.com/nodejs/node/pull/31969 Fixes: https://github.com/nodejs/node/issues/27746 Reviewed-By:
-
cjihrig authored
Notable changes: - uv_get_constrained_memory() has been added. - A race condition in uv_async_send() has been fixed. - uv_get_free_memory() and uv_get_total_memory() now read from /proc/meminfo, which should improve correctness when called from inside an lxc container. - A failed assertion in uv_fs_poll_stop() has been fixed. - A bug in MAC addresses for IP-aliases has been fixed. Fixes: https://github.com/nodejs/node/issues/27170 Fixes: https://github.com/nodejs/node/issues/27493 PR-URL: https://github.com/nodejs/node/pull/27718 Backport-PR-URL: https://github.com/nodejs/node/pull/31969 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
himself65 authored
Co-Authored-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/30006 Backport-PR-URL: https://github.com/nodejs/node/pull/31384 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
- Feb 27, 2020
-
-
Sam Roberts authored
They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: https://github.com/nodejs/node/issues/30030 Refs: https://github.com/nodejs/build/pull/2189#issuecomment-589767606 PR-URL: https://github.com/nodejs/node/pull/31936 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Andrew Hughes authored
PR-URL: https://github.com/nodejs/node/pull/31358 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
João Reis authored
PR-URL: https://github.com/nodejs/node/pull/30931 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Ben Noordhuis authored
The test was using fixed timeouts and that seems to be causing sporadic test failures on pi1-docker host (which is a very slow machine.) Fixes: https://github.com/nodejs/node/issues/30828 PR-URL: https://github.com/nodejs/node/pull/30834 Reviewed-By:
-
- Feb 26, 2020
-
-
Milad Farazmand authored
PR-URL: https://github.com/nodejs/node/pull/31753 Refs: https://github.com/v8/v8/commit/d89f4ef1cd629cb169f0d9efcaefd05ebf09fd3d Reviewed-By:
-
Ben Noordhuis authored
This commit back-ports the implementations of IsRename() and MayAlias() from the upstream 8.0 branch wholesale. Fixes several bugs where V8's load elimination pass considered values to be alive when they weren't. Fixes: https://github.com/nodejs/node/issues/31484 PR-URL: https://github.com/nodejs/node/pull/31613 Reviewed-By:
-
Gabriel Schulhof authored
Adds `napi_set_instance_data()` and `napi_get_instance_data()`, which allow native addons to store their data on and retrieve their data from `napi_env`. `napi_set_instance_data()` accepts a finalizer which is called when the `node::Environment()` is destroyed. This entails rendering the `napi_env` local to each add-on. Fixes: https://github.com/nodejs/abi-stable-node/issues/378 PR-URL: https://github.com/nodejs/node/pull/28682 Backport-PR-URL: https://github.com/nodejs/node/pull/30537 Reviewed-By:
-
Anna Henningsen authored
These do not need to be macros. PR-URL: https://github.com/nodejs/node/pull/26128 Backport-PR-URL: https://github.com/nodejs/node/pull/30537 Reviewed-By:
-
Rich Trott authored
The test failed in CI once with a timeout but there is insufficient information to further debug. Add additional debugging information. Refactored callbacks to be arrow functions, since that seems to be the direction we're moving. PR-URL: https://github.com/nodejs/node/pull/31698 Reviewed-By:
-
- Feb 25, 2020
-
-
garygsc authored
Backport-PR-URL: https://github.com/nodejs/node/pull/30361 PR-URL: https://github.com/nodejs/node/pull/19691 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Sam Roberts authored
Backport CLI switches for default TLS versions: - `--tls-max-v1.2` - `--tls-min-v1.0` - `--tls-min-v1.1` - `--tls-min-v1.2` PR-URL: https://github.com/nodejs/node/pull/27946 Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
cjihrig authored
EAI_FAIL is expected on OpenBSD, and has been observed on platforms such as FreeBSD and Windows. This commit makes EAI_FAIL an acceptable error code on all platforms. PR-URL: https://github.com/nodejs/node/pull/27500 Fixes: https://github.com/nodejs/node/issues/27487 Reviewed-By:
-
João Reis authored
PR-URL: https://github.com/nodejs/node/pull/30848 Reviewed-By:
-
AshCripps authored
These tests are already marked as flaky on 12.x and master. PR-URL: https://github.com/nodejs/node/pull/31887 Reviewed-By:
-
- Feb 21, 2020
-
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/27277 Reviewed-By:
-
- Feb 14, 2020
-
-
Michael Perrotte authored
PR-URL: https://github.com/nodejs/node/pull/31558 Reviewed-By:
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/31304 Reviewed-By:
-
- Feb 06, 2020
-
-
Beth Griggs authored
PR-URL: https://github.com/nodejs-private/node-private/pull/198
-
Beth Griggs authored
This is a security release. Vulnerabilities fixed: * **CVE-2019-15606**: HTTP header values do not have trailing OWS trimmed. * **CVE-2019-15605**: HTTP request smuggling using malformed Transfer-Encoding header. * **CVE-2019-15604**: Remotely trigger an assertion on a TLS server with a malformed certificate string. Also, HTTP parsing is more strict to be more secure. Since this may cause problems in interoperability with some non-conformant HTTP implementations, it is possible to disable the strict checks with the `--insecure-http-parser` command line flag, or the `insecureHTTPParser` http option. Using the insecure HTTP parser should be avoided. PR-URL: https://github.com/nodejs-private/node-private/pull/198
-
- Feb 05, 2020
-
-
Sam Roberts authored
See: https://hackerone.com/reports/735748 PR-URL: https://github.com/nodejs-private/node-private/pull/192 Reviewed-By:
Beth <Griggs <Bethany.Griggs@uk.ibm.com>
-
Sam Roberts authored
PR-URL: https://github.com/nodejs-private/http-parser-private/pull/4 Reviewed-By:
Matteo <Collina <matteo.collina@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Anna Henningsen authored
From the issue: > Some servers deviate from HTTP spec enougth that Node.js can't > communicate with them, but "work" when `--insecure-http-parser` > is enabled globally. It would be useful to be able to use this > mode, as a client, only when connecting to known bad servers. This is largely equivalent to https://github.com/nodejs/node/pull/31446 in terms of code changes. Fixes: https://github.com/nodejs/node/issues/31440 Refs: https://github.com/nodejs/node/pull/31446 Backport-PR-URL: https://github.com/nodejs/node/pull/30471 PR-URL: https://github.com/nodejs/node/pull/31448 Reviewed-By:
-
Sam Roberts authored
Test that using --insecure-http-parser will disable validation of invalid characters in HTTP headers. See: - https://github.com/nodejs/node/pull/30567 Backport-PR-URL: https://github.com/nodejs/node/pull/30471 PR-URL: https://github.com/nodejs/node/pull/31253 Reviewed-By:
-
Sam Roberts authored
Allow insecure HTTP header parsing. Make clear it is insecure. See: - https://github.com/nodejs/node/pull/30553 - https://github.com/nodejs/node/issues/27711#issuecomment-556265881 - https://github.com/nodejs/node/issues/30515 Backport-PR-URL: https://github.com/nodejs/node/pull/30471 PR-URL: https://github.com/nodejs/node/pull/30567 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
- Feb 04, 2020
-
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/30471 Reviewed-By:
-
- Feb 03, 2020
-
-
Fedor Indutny authored
`X509V3_EXT_print` can return value different from `1` if the X509 extension does not support printing to a buffer. Instead of failing with an unrecoverable assertion - replace the relevant value in the hashmap with a JS null value. Fixes: https://hackerone.com/reports/746733 Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/193 PR-URL: https://github.com/nodejs-private/node-private/pull/175 Reviewed-By:
-
- Feb 01, 2020
-
-
Sam Roberts authored
HTTP header values can have trailing OWS, but it should be stripped. It is not semantically part of the header's value, and if treated as part of the value, it can cause spurious inequality between expected and actual header values. Note that a single SPC of leading OWS is common before the field-value, and it is already handled by the HTTP parser by stripping all leading OWS. It is only the trailing OWS that must be stripped by the parser user. header-field = field-name ":" OWS field-value OWS ; https://tools.ietf.org/html/rfc7230#section-3.2 OWS = *( SP / HTAB ) ; https://tools.ietf.org/html/rfc7230#section-3.2.3 Fixes: https://hackerone.com/reports/730779 PR-URL: https://github.com/nodejs-private/node-private/pull/191 Reviewed-By:
Ben <Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
- Jan 10, 2020
-
-
Beth Griggs authored
PR-URL: https://github.com/nodejs/node/pull/31248
-
- Jan 09, 2020
-
-
Beth Griggs authored
- http2: fix session memory accounting after pausing (Michael Lehenbauer) [#30684](https://github.com/nodejs/node/pull/30684) - n-api: correct bug in napi_get_last_error (Octavian Soldea) [#28702](https://github.com/nodejs/node/pull/28702) - tools: update tzdata to 2019c (Myles Borins) [#30479](https://github.com/nodejs/node/pull/30479) PR-URL: https://github.com/nodejs/node/pull/31248
-
- Jan 07, 2020
-
-
Robert Nagy authored
MAX_HWM was added in 9208c890 where the highwatermark was changed to always increase in steps of highest power of 2 to prevent increasing hwm excessivly in tiny amounts. Why a limit was added on the highwatermark is unclear but breaks existing usage where a larger read size is used. The invariant for read(n) is that a buffer of size n is always returned. Considering a maximum ceiling on the buffer size breaks this invariant. This PR significantly increases the limit to make it less likely to break the previous invariant and also documents the limit. Fixes: https://github.com/nodejs/node/issues/29933 PR-URL: https://github.com/nodejs/node/pull/29938 Reviewed-By:
-
- Dec 31, 2019
-
-
Rich Trott authored
This will allow us to lint for use of `hostname` in prose without flagging `hostname` in code within headers. This also allows us to remove backslash escaping for `[` and `]` inside of header code, which makes the bare markdown more readable. Backport-PR-URL: https://github.com/nodejs/node/pull/31109 PR-URL: https://github.com/nodejs/node/pull/31086 Reviewed-By:
-
Rich Trott authored
Allow use of <code> in header elements without styling side effects. We can add styling later if desired. The goal here is to allow code to be set off in markdown without needing to escape characters and do lint exceptions for terms. This is probably a win in terms of accessibility too although it would be moreso if we had some visual differentiation for <code> inside of headers. As mentioned above, that can always be added at a later time. Backport-PR-URL: https://github.com/nodejs/node/pull/31109 PR-URL: https://github.com/nodejs/node/pull/31086 Reviewed-By:
-
