- Dec 04, 2015
-
-
Shigeki Ohtsu authored
This just replaces all sources of openssl-1.0.2e.tar.gz into deps/openssl/openssl deps: copy all openssl header files to include dir All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. deps: fix openssl assembly error on ia32 win32 `x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . deps: fix asm build error of openssl in x86_win32 See https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html node needs to stop using masm and move to nasm or yasm on Win32. openssl: fix keypress requirement in apps on win32 Reapply b9106137 . deps: add -no_rand_screen to openssl s_client In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. deps: update openssl config files Regenrate config files for supported platforms with Makefile. deps: update openssl asm and asm_obsolete files Regenerate asm files with Makefile and CC=gcc and ASM=gcc where gcc-4.8.4. Also asm files in asm_obsolete dir to support old compiler and assmebler are regenerated without CC and ASM envs. PR-URL: https://github.com/nodejs/node/pull/4134 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Dec 03, 2015
-
-
Stefan Budeanu authored
Prevent OpenSSL's fipsld from being used to link native modules because this requires the original OpenSSL source to be available after Node's installation. Fixes: https://github.com/nodejs/node/issues/3815 PR-URL: https://github.com/nodejs/node/pull/4023 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
Michael Cornacchia authored
The current implementation of tests for strings with length at or exceeding kStringMaxLength allocate a temporary buffer inside a try block to skip the test if there is insufficient memory. This commit adds an invocation of the garbage collector after the temporary buffer is allocated so that memory is freed for later allocations. Change the corresponding catch block to rethrow the original exception instead of asserting the exception message to provide more information about the exception. Add an additional check before trying to allocate memory to immediately skip the test on machines with insufficient total memory. PR-URL: https://github.com/nodejs/node/pull/3697 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Myles Borins authored
The CoC requests to avoid the casual use of profanity. PR-URL: https://github.com/nodejs/node/pull/4122 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Brian White authored
These properties were initially used to determine stream status back in node v0.8 and earlier. Since streams2 however, these properties were *always* true, which can be misleading for example if you are trying to immediately determine whether a Writable stream is still writable or not (to avoid a "write after end" exception). PR-URL: https://github.com/nodejs/node/pull/4083 Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
Brian White authored
This commit fixes two issues in test-cluster-disconnect-handles: 1. If the master's TCP connection to the worker fails, the worker process stays alive and causes many other tests that use the same common port number to also fail (with EADDRINUSE). 2. One particular problem that can cause the master's TCP connection to fail is attempting an IPv6 connection to the worker when no IPv6 network interfaces are available. PR-URL: https://github.com/nodejs/node/pull/4084 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
cjihrig authored
Determine object types of regular expressions, Dates, Maps, and Sets in the C++ layer instead of depending on toString() behavior in JavaScript. PR-URL: https://github.com/nodejs/node/pull/4100 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Andrei Sedoi authored
ES6 arrow functions are much more efficient than `.bind()` functions. PR-URL: https://github.com/nodejs/node/pull/4038 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Jan Krems authored
PR-URL: https://github.com/nodejs/node/pull/4075 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Dec 02, 2015
-
-
Evan Lucas authored
34a35919 added pretty printing for TypedArray, ArrayBuffer, and DataView. This change allows inspecting those across different contexts. Since instanceof does not work across contexts, we can use v8::Value::IsTypedArray, v8::Value::IsArrayBuffer, and v8::Value::IsDataView PR-URL: https://github.com/nodejs/node/pull/4098 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Zirak authored
When writing multiline input, one can't chain function calls as if the lines begin with a period, since those are treated as REPL commands. Before: > ([0, 1, 2] ... .map(x => x + 1)) Invalid REPL keyword After: > ([0, 1, 2] ... .map(x => x + 1)) [ 1, 2, 3 ] PR-URL: https://github.com/nodejs/node/pull/3835 Reviewed-By:Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Santiago Gimeno authored
Sometimes the test was timing out because the worker process remained stuck in the breakpoint and didn't exit. This could happen because the continue was sent before the breakpoint was set. If that's the case, with this change, a new continue command is sent so the worker process can end. PR-URL: https://github.com/nodejs/node/pull/4009 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Peter A. Bigot authored
The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: https://github.com/nodejs/node/issues/3992 PR-URL: https://github.com/nodejs/node/pull/3994 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Signed-off-by:
Peter A. Bigot <pab@pabigot.com>
-
Bryan English authored
It also tests displayPrompt by checking for '> '. PR-URL: https://github.com/nodejs/node/pull/3908 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
- Dec 01, 2015
-
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/4089 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Dave authored
When a client calls read() with a nonzero argument on a Socket, that Socket sets this._consuming to true. It never sets this._consuming back to false. ChildProcess.flushStdio() currently doesn't flush any streams where _consuming is truthy. But, that means that it never flushes any stream that has ever been read from. This prevents a child process from ever closing if one of its streams has been read from, causing issue #4049. This commit allows consuming streams to be flushed, and the child process to emit a close event. Fixes: https://github.com/nodejs/node/issues/4049 PR-URL: https://github.com/nodejs/node/pull/4071 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
test-dgram-multicast-multi-process was flaky on FreeBSD and Raspeberry Pi. This refactoring fixes the issue by eliminating a race condition. Fixes: https://github.com/nodejs/node/issues/2474 PR-URL: https://github.com/nodejs/node/pull/4042 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Brian White authored
These new checks are similar to the one introduced in 089d6886, but for other types of objects. Specifically, if an object was created in a different context, the constructor object will not be the same as the constructor object in the current context, so we have to compare constructor names instead. PR-URL: https://github.com/nodejs/node/pull/3385 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
yorkie authored
A value shouldn't be described as doing inherit from some class, more strictly, the value is an instance of the class `Error`. PR-URL: https://github.com/nodejs/node/pull/3658 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Stephan Belanger <admin@stephenbelanger.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Ben Noordhuis authored
Move the method that was added in commit 8ca412b7 from earlier this month from lib/util.js to lib/internal/util.js. Avoids exposing a method that we may not wish to expose just yet, seeing how it relies on implementation details. PR-URL: https://github.com/nodejs/node/pull/4026 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Ben Noordhuis authored
Remove a hack that was introduced in commit bb6d468d from November 2010. This is groundwork for a follow-up commit that makes it possible to use internal modules in lib/repl.js. PR-URL: https://github.com/nodejs/node/pull/4026 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
jpersson authored
Links nested in backticks were not visually distinguishable before, this fixes them. PR-URL: https://github.com/nodejs/node/pull/4068 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Nov 30, 2015
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4011 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
- Nov 27, 2015
-
-
Nathan Woltman authored
Make the win32 and posix versions of path.format() consistent in when they add a directory separator between the dir and base parts of the path (always add it unless the dir part is the same as the root). Also, path.format() is now more functional in that it uses the name and ext parts of the path if the base part is left out and it uses the root part if the dir part is left out. Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2408
-
Rich Trott authored
Mark test-net-socket-local-address flaky on FreeBSD. It times out with some frequency on CI. Ref: https://github.com/nodejs/node/issues/2475 PR-URL: https://github.com/nodejs/node/pull/4016 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
cjihrig authored
A number of REPL tests define the same ArrayStream object. This commit moves the repeated code into common.js. PR-URL: https://github.com/nodejs/node/pull/4027 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Julien Gilli authored
test-domain-exit-dispose-again had been written for node v0.10.x, and was using the fact that callbacks scheduled with `process.nextTick` wouldn't run if the domain attached to it was disposed. This is not longer the case, and as a result the test would not catch any regression: it would always pass. This change rewrites that test to check that the current domain is cleared properly when processing the rest of the timers list if a timer's callback throws an error. This makes the test fail without the original fix, and pass with the original fix, as expected. PR: #3990 PR-URL: https://github.com/nodejs/node/pull/3990 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Roman Reiss authored
By using the same unit for the offset of the main column as used for the left column width, we ensure that browsers render the columns conistently. Ref: https://github.com/nodejs/help/issues/32 PR-URL: https://github.com/nodejs/node/pull/3948 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
test-http-client-timeout-with-data fails on Raspberry Pi in CI from time to time. Use a platform-based timeout to improve reliability. PR-URL: https://github.com/nodejs/node/pull/4015 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Nov 26, 2015
-
-
cjihrig authored
Currently, when a file with a syntax error is imported in the REPL, no information is provided on the error's location. This commit adds the error's location to the stack trace. Refs: https://github.com/nodejs/node/issues/2762 Refs: https://github.com/nodejs/node/issues/3411 Refs: https://github.com/nodejs/node/issues/3784 PR-URL: https://github.com/nodejs/node/pull/4013 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
cjihrig authored
This commit adds the decorateErrorStack() method. This function uses the internal util's getHiddenValue() method to extract arrow messages from error objects and attach them to the error's stack trace. PR-URL: https://github.com/nodejs/node/pull/4013 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rich Trott authored
See https://github.com/nodejs/node/issues/3957 for details and examples failures. Ref: https://github.com/nodejs/node/issues/3957 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/4006
-
Rich Trott authored
See https://github.com/nodejs/node/issues/3635 for details and failure examples. Ref: https://github.com/nodejs/node/issues/3635 PR-URL: https://github.com/nodejs/node/pull/4005 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Nov 25, 2015
-
-
Tom Gallacher authored
If an undefined encoding is passed to byteLength(), assume that it is UTF8 immediately. This yields a small speedup, as it prevents string operations on the encoding argument. PR-URL: https://github.com/nodejs/node/pull/4010 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Chunyang Dai authored
This feature supports the Intel Vtune profiling support for JITted JavaScript on IA32 / X64 / X32 platform. The advantage of this profiling is that the user / developer of NodeJS application can get the detailed profiling information for every line of the JavaScript source code. This information will be very useful for the owner to optimize their applications. This feature is a compile-time option. For windows platform, the user needs to pass the following parameter to vcbuild.bat: "enable-vtune" For other OS, the user needs to pass the following parameter to ./configure command: "--enable-vtune-profiling" PR-URL: https://github.com/nodejs/node/pull/3785 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Matt Loring authored
The tick processor is used to provide readable profiling information from isolate tick logs (produced by a call to node -prof). This patch installs the file at $PREFIX/share/doc/node/tick-processor. PR-URL: https://github.com/nodejs/node/pull/3032 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Michaël Zasso authored
Original commit message: Use baseline code to compute message locations. This switches Isolate::ComputeLocation to use baseline code when computing message locations. This unifies locations between optimized and non-optimized code by always going through the FrameSummary for location computation. R=bmeurer@chromium.org TEST=message/regress/regress-4266 BUG=v8:4266 LOG=n Review URL: https://codereview.chromium.org/1331603002 Cr-Commit-Position: refs/heads/master@{#30635} Fixes: https://github.com/nodejs/node/issues/3934 PR-URL: https://github.com/nodejs/node/pull/3937 Reviewed-By:Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rich Trott authored
Test test-net-socket-local-address is flaky in FreeBSD jail but robust otherwise. Fixes: https://github.com/nodejs/node/issues/2475 PR-URL: https://github.com/nodejs/node/pull/3995 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Jan Schär authored
Adds localAddress and localPort to req so we have better error messages. Also fixes a case where ex is used before it is declared. PR-URL: https://github.com/nodejs/node/pull/3946 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
cjihrig authored
This commit adds an internal util method that makes hidden values in the C++ layer visible in JS. PR-URL: https://github.com/nodejs/node/pull/3988 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-