Commits · fe11f6bf7cf8de128c224d06cb076e7fe571dfd3 · github.com / v8-riscv / node

Jul 09, 2020

quic: cleanup QuicSocketFlags, used shared state struct · fe11f6bf

James M Snell authored Jul 08, 2020

Some of the flags were no longer being used.

Switched to use an AliasedStruct for shared state to avoid
extraneous expensive JS=>C++ calls.

Removed unused QuicSocket option

PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: Anna Henningsen <anna@addaleax.net>

fe11f6bf

quic: use getter/setter for stateless reset toggle · d08e99de

James M Snell authored Jul 08, 2020

PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: Anna Henningsen <anna@addaleax.net>

d08e99de

quic: unref timers again · f2753c76

Anna Henningsen authored Jul 08, 2020

0f97d606 accidentally removed this.

Refs: https://github.com/nodejs/node/pull/34186

PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: James M Snell <jasnell@gmail.com>

f2753c76

quic: use Number() instead of bigint for QuicSocket stats · 71236097
James M Snell authored Jul 07, 2020
```
PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: Anna Henningsen <anna@addaleax.net>
```
71236097
quic: refactor/improve/document QuicSocket listening event · 94372b12
James M Snell authored Jul 07, 2020
```
PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: Anna Henningsen <anna@addaleax.net>
```
94372b12

quic: refactor/improve QuicSocket ready event handling · afc9390a

James M Snell authored Jul 07, 2020

PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: Anna Henningsen <anna@addaleax.net>

afc9390a

quic: add tests confirming error handling for QuicSocket close event · e3813261
James M Snell authored Jul 07, 2020
```
PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: Anna Henningsen <anna@addaleax.net>
```
e3813261

quic: refactor/improve error handling for busy event · cc89aac5

James M Snell authored Jul 07, 2020

Also, change setServerBusy into a setter

PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: Anna Henningsen <anna@addaleax.net>

cc89aac5

quic: handle errors thrown / rejections in the session event · edc71ef0

James M Snell authored Jul 07, 2020

Errors thrown within the session event handler will be handled
by destroying the session (allowing a proper connection close
to be sent to the client peer). They will not crash the parent
QuicSocket by default. Instead, a `'sessionError'` event will
be emitted, allowing the error to be logged or handled.

PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: Anna Henningsen <anna@addaleax.net>

edc71ef0

quic: remove unnecessary bool conversion · bcde849b

James M Snell authored Jul 07, 2020

The argument will always be a boolean already

PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: Anna Henningsen <anna@addaleax.net>

bcde849b

quic: additional minor cleanups in node_quic_session.h · c5351316

James M Snell authored Jul 07, 2020

PR-URL: https://github.com/nodejs/node/pull/34247


Reviewed-By: Anna Henningsen <anna@addaleax.net>

c5351316

http: add note about timer unref · e8f57456

Robert Nagy authored Jun 30, 2020

PR-URL: https://github.com/nodejs/node/pull/34143


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

e8f57456

stream: add promises version to utility functions · 527e2147

rickyes authored Jun 28, 2020

PR-URL: https://github.com/nodejs/node/pull/33991
Fixes: https://github.com/nodejs/node/issues/33582


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

527e2147

test: add known issue for fs.open() keeping event loop open · 6ae1b9c4

Rich Trott authored Jul 06, 2020

PR-URL: https://github.com/nodejs/node/pull/34228


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

6ae1b9c4

test: add n-api null checks for conversions · c08920b0

Gabriel Schulhof authored Jun 30, 2020

Add assertions that conversion and coercion N-APIs return appropriate
error statuses when given `NULL`s for parameters they expect to not be
`NULL`.

For `napi_get_value_string_*` this also checks that it returns
`napi_string_expected` when passed a `napi_value` not containing a
string.

PR-URL: https://github.com/nodejs/node/pull/34142


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

c08920b0

Jul 08, 2020

Forces Powershell to use tls1.2 · b99253cf

Johannes Schöpp authored May 28, 2020

Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: https://github.com/nodejs/node/issues/33140

PR-URL: https://github.com/nodejs/node/pull/33609


Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

b99253cf

test: add arrayOfStreams to pipeline · e0ecde97

rickyes authored Jul 01, 2020

PR-URL: https://github.com/nodejs/node/pull/34156


Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

e0ecde97

test: skip an ipv6 test on IBM i · 7a84e2e0

Xu Meng authored Jul 04, 2020

Due to some unknown system configuration, the code
`socket_ipv6.bind(0, 111::1)` does not throw the
expected error EADDRNOTAVAIL on some IBM i systems.
This issue is still being investigated. To get the
IBM i CI passing, skip it for now.

PR-URL: https://github.com/nodejs/node/pull/34209


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

7a84e2e0

test: add regression test for C++-created Buffer transfer · cb67be7f

Anna Henningsen authored Jun 30, 2020

Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.

Fixes: https://github.com/nodejs/node/issues/34126

PR-URL: https://github.com/nodejs/node/pull/34140


Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

cb67be7f

src: exit explicitly after printing V8 help · 6bc871f4

Anna Henningsen authored Jun 30, 2020

V8 will not exit the process after handling --help anymore:
https://chromium-review.googlesource.com/c/v8/v8/+/2276276

As a drive-by fix, correctly return in the `print_bash_completion`
case as well.

Refs: https://github.com/nodejs/node/pull/34135


Co-authored-by: Ulan Degenbaev <ulan@chromium.org>

PR-URL: https://github.com/nodejs/node/pull/34136


Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

6bc871f4

domain: fix unintentional deprecation warning · 2243d79f

Anna Henningsen authored Jul 07, 2020

646e5a47 changed the way that the domain hook callback
is called. Previously, the callback was only used in the case that
async_hooks were *not* being used (since domains already integrate
with async hooks the way they should), and the corresponding
deprecation warning also only emitted in that case.

However, that commit didn’t move that condition along when the code
was ported from C++ to JS. As a consequence, the domain hook callback
was used when it wasn’t necessary to use it, and the deprecation
warning emitted accidentally along with it.

Refs: https://github.com/nodejs/node/commit/646e5a471766e27e8317bb54d1fd1d2c72cffb69#diff-9f21ce1b9d6d46fdd07b969e8a04e140L192
Refs: https://github.com/nodejs/node/commit/646e5a471766e27e8317bb54d1fd1d2c72cffb69#diff-e6db408e12db906ead6ddfac3de15a6fR119
Refs: https://github.com/nodejs/node/pull/33801#issuecomment-654744913

PR-URL: https://github.com/nodejs/node/pull/34245
Fixes: https://github.com/nodejs/node/issues/34069

Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

2243d79f

Jul 07, 2020

src: add encoding_type variable in WritePrivateKey · 30612316

Daniel Bevenius authored Jul 03, 2020

This commit adds a local variable named encoding_type which is set to
the value of the Maybe using ToChecked().

The motivation for this is the code for ToChecked() could be executed
multiple times depending on path taken at runtime. I also think this
improves readability, or at least it is as readable as before this
change.

PR-URL: https://github.com/nodejs/node/pull/34181


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>

30612316

test: fix flaky test-fs-stream-construct · 772fdb0c

Rich Trott authored Jul 04, 2020

The test is marked flaky on ARM because it times out on Raspberry Pi
devices in CI. Split the single test file into four separate test files
to ease debugging. Add fs.close() to avoid timing out.

Fixes: https://github.com/nodejs/node/issues/33796

PR-URL: https://github.com/nodejs/node/pull/34203


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

772fdb0c

Jul 06, 2020

lib: replace http to https of comment link urls · ee3416b0

sapics authored Jun 29, 2020

PR-URL: https://github.com/nodejs/node/pull/34158


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

ee3416b0

doc: replace http to https of link urls · 3975799f

sapics authored Jun 30, 2020

PR-URL: https://github.com/nodejs/node/pull/34158


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

3975799f

doc: remove errors that were never released · bf772896

Rich Trott authored Jul 04, 2020

Refs: https://github.com/nodejs/node/pull/33764#issuecomment-653667275

PR-URL: https://github.com/nodejs/node/pull/34197


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

bf772896

test: replace deprecated function call from test-repl-history-navigation · 9f0671eb

Rich Trott authored Jul 04, 2020

test-repl-history-navigation fails with NODE_PENDING_DEPRECATION=1.
Replace deprecated repl.inputStream with repl.input.

PR-URL: https://github.com/nodejs/node/pull/34199


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

9f0671eb

repl: fix verb conjugation in deprecation message · ddfaafa9

Rich Trott authored Jul 04, 2020

PR-URL: https://github.com/nodejs/node/pull/34198


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

ddfaafa9

src: fix minor comment typo in KeyObjectData · 67ba8250

Daniel Bevenius authored Jul 02, 2020

PR-URL: https://github.com/nodejs/node/pull/34167


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>

67ba8250

src: fix unused namespace member · 82c435d0

Nikola Glavina authored Jul 05, 2020

C++ linter fails because of unused ArrayBuffer namespace member

PR-URL: https://github.com/nodejs/node/pull/34212


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

82c435d0

doc: move ERR_FEATURE_UNAVAILABLE_ON_PLATFORM to current errors · 654df09a

Rich Trott authored Jul 04, 2020

ERR_FEATURE_UNAVAILABLE_ON_PLATFORM is incorrectly included in the list
of errors that have never been released. It was added in
67e067eb and included in every release
in the 14.x line.

PR-URL: https://github.com/nodejs/node/pull/34196


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

654df09a

doc: move digitalinfinity to emeritus · 7eb500b5

Rich Trott authored Jul 03, 2020

Had an email exchange with Hitesh where he indicated that it was a fine
time to move him to emeritus.

PR-URL: https://github.com/nodejs/node/pull/34191


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

7eb500b5

doc: move gibfahn to emeritus · 8a57788e

Rich Trott authored Jul 03, 2020

Asked Gibson in email if he should be moved to emeritus and he indicated
it was a good idea.

PR-URL: https://github.com/nodejs/node/pull/34190


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

8a57788e

quic: use TimerWrap for idle and retransmit timers · 0f97d606

James M Snell authored Jul 03, 2020



Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/34186


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

0f97d606

src: replace InspectorTimer with TimerWrap utility · e19a2518

James M Snell authored Jul 03, 2020



Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/34186


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

e19a2518

src: add TimerWrap utility · d4f69002

James M Snell authored Jul 03, 2020



Consolidate uv_timer_t boilerplate code into a shared utility.
There are several places throughout the code where we use uv_timer_t
internally (inspector, perf, quic), with some code duplication.
This eliminates the duplicated code, ensures that cleanup occurs
correctly, and simplifies use of the timers.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/34186


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

d4f69002

doc: specify how fs.WriteStream/ReadStreams are created · e7dadd37

James M Snell authored Jul 03, 2020

Alternative to https://github.com/nodejs/node/pull/33841



Co-authored-by: zombieleet <zombieleetnca@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/34188


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

e7dadd37

quic: add missing memory tracker fields · 1b1e9854

James M Snell authored Jul 03, 2020

PR-URL: https://github.com/nodejs/node/pull/34160


Reviewed-By: Anna Henningsen <anna@addaleax.net>

1b1e9854

quic: cleanup timers if they haven't been already · 5a87e9b0

James M Snell authored Jul 03, 2020

PR-URL: https://github.com/nodejs/node/pull/34160


Reviewed-By: Anna Henningsen <anna@addaleax.net>

5a87e9b0

quic: fixup lint issues · 3837d9cf

James M Snell authored Jul 02, 2020

PR-URL: https://github.com/nodejs/node/pull/34160


Reviewed-By: Anna Henningsen <anna@addaleax.net>

3837d9cf