- Oct 18, 2020
-
-
Rich Trott authored
Bump remark-lint-preset-node@1.16.0 to remark-lint-preset-node@1.17.1. Refs: https://github.com/nodejs/remark-preset-lint-node/pull/139 PR-URL: https://github.com/nodejs/node/pull/35668 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Rich Trott authored
This is in preparation for updating remark-preset-lint-node to 1.17.1. PR-URL: https://github.com/nodejs/node/pull/35668 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Simen Bekkhus authored
PR-URL: https://github.com/nodejs/node/pull/35593 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
- Oct 17, 2020
-
-
H Adinarayana authored
PR-URL: https://github.com/nodejs/node/pull/35657 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/35653 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/35690 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
himself65 authored
Use `common.mustCall` and `util.debuglog`. Remove unnecessary functions PR-URL: https://github.com/nodejs/node/pull/32805 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/35522 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/35086 Reviewed-By:
Ruy Adorno <ruyadorno@github.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Yash Ladha authored
Currently we are returning the stringified error code while in other process methods we are throwin a UVException and only exclusion is in the CPUUsage. Converted it to follow the convention. PR-URL: https://github.com/nodejs/node/pull/34762 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Mary Marchini <oss@mmarchini.me> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Sourav Shaw authored
Since the section refers to EventEmitter, instances in the example should be created of the same class EventEmitter. PR-URL: https://github.com/nodejs/node/pull/33513 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Oct 16, 2020
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/35642 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Rich Trott authored
0 is deprecated. Change to 1, which is experimental. PR-URL: https://github.com/nodejs/node/pull/35672 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Danny Sonnenschein authored
This adds support for DNS Certification Authority Authorization (RFC 8659) to Node.js. PR-URL: https://github.com/nodejs/node/pull/35466 Fixes: https://github.com/nodejs/node/issues/19239 Refs: https://github.com/nodejs/node/issues/14713 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Michaël Zasso authored
The other way is deprecated. PR-URL: https://github.com/nodejs/node/pull/35638 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Michaël Zasso authored
It is already installed in the GitHub runners. PR-URL: https://github.com/nodejs/node/pull/35638 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Daijiro Wachi authored
Refs: https://github.com/web-platform-tests/wpt/pull/25987 PR-URL: https://github.com/nodejs/node/pull/35636 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Myles Borins authored
Notable changes: crypto: * update certdata to NSS 3.56 (Shelley Vohr) https://github.com/nodejs/node/pull/35546 doc: * add aduh95 to collaborators (Antoine du Hamel) https://github.com/nodejs/node/pull/35542 fs: * (SEMVER-MINOR) add rm method (Ian Sutherland) https://github.com/nodejs/node/pull/35494 http: * (SEMVER-MINOR) allow passing array of key/val into writeHead (Robert Nagy) https://github.com/nodejs/node/pull/35274 src: * (SEMVER-MINOR) expose v8::Isolate setup callbacks (Shelley Vohr) https://github.com/nodejs/node/pull/35512 PR-URL: https://github.com/nodejs/node/pull/35648
-
Robert Nagy authored
Fixes some compatibility issues where it is expected that for await stops reading when the stream is destroyed. Refs: https://github.com/nodejs/node/pull/34887 PR-URL: https://github.com/nodejs/node/pull/35640 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
SSLWrap was needlessly defined as a template class, splitting the TLS implementation over multiple locations. The original idea, I surmise, was to make it possible to reuse SSLWrap for some other purpose that never manifest. This squashes them down into a single TLSWrap class and moves tls_wrap.h/cc into src/crypto. Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35552 Reviewed-By:
Alba Mendez <me@alba.sh>
-
- Oct 15, 2020
-
-
James M Snell authored
Running tests comparitively on older versions of Node.js that do not have AbortController can be a pain. Only add the AbortController to knownGlobals if it actually exists. Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35616 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35625 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/35613 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Gireesh Punathil authored
This api does not alter the behavior of diagnostic report configured on uncaught exceptions. This is deemed as a bug. Honor this API. Refs: https://github.com/nodejs/node/pull/35588 PR-URL: https://github.com/nodejs/node/pull/35595 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Hussaina Begum Nandyala authored
Signed-off-by:
Hussaina Begum Nandyala <hexxdump@gmail.com> PR-URL: https://github.com/nodejs/node/pull/35618 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Ian Sutherland authored
This is a follow up to #35494 to add a deprecation warning when using recursive rmdir. This only warns if you are attempting to remove a file or a nonexistent path. PR-URL: https://github.com/nodejs/node/pull/35562 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35634 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org>
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/35559 PR-URL: https://github.com/nodejs/node/pull/35612 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Anna Henningsen authored
Original commit message: [heap-profiler] Fix crash when a snapshot deleted while taking one Fix a crash/hang that occurred when deleting a snapshot during the GC that is part of taking another one. Specifically, when deleting the only other snapshot in such a situation, the `v8::HeapSnapshot::Delete()` method sees that there is only one (complete) snapshot at that point, and decides that it is okay to perform “delete all snapshots” instead of just deleting the requested one. That resets the internal string lookup table of the heap profiler, but the new snapshot that is currently in progress still holds references to the old string lookup table, leading to a use-after-free segfault or infinite loop. Fix this by guarding against resetting the string table while another heap snapshot is being taken, and add a test that would crash before this fix. This can be triggered in Node.js by repeatedly calling `v8.getHeapSnapshot()`, which provides heap snapshots as weakly held host objects. Change-Id: If9ac3728bf79114000982f1e7bb05e8034299e3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464823 Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#70445} Refs: https://github.com/v8/v8/commit/3176bfd447a909fa9608687fe3eabcf62ec7b2eb PR-URL: https://github.com/nodejs/node/pull/35612 Refs: https://github.com/nodejs/node/issues/35559 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Anna Henningsen authored
Provide helpers for a) spinning the event loop and b) setting up and tearing down the objects involved in a single Node.js instance, as they would typically be used. The former helper is also usable inside Node.js itself, for both Worker and main threads. PR-URL: https://github.com/nodejs/node/pull/35597 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/35541 Refs: https://github.com/nodejs/node/pull/32703 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com>
-
- Oct 14, 2020
-
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/35631 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
Ruy Adorno <ruyadorno@github.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/35631 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
Ruy Adorno <ruyadorno@github.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/node/pull/35206 PR-URL: https://github.com/nodejs/node/pull/35599 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35611 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com>
-
Rod Vagg authored
Ref: https://github.com/nodejs/node-gyp/issues/2233 Ref: https://github.com/nodejs/gyp-next/pull/69 PR-URL: https://github.com/nodejs/node/pull/35635 Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Ujjwal Sharma authored
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.6.0 PR-URL: https://github.com/nodejs/node/pull/35635 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/35551 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/35566 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Tobias Nießen authored
"GB" refers to 10**9 bytes, whereas the actual limit is 2**30. The correct unit symbol is "GiB". PR-URL: https://github.com/nodejs/node/pull/35051 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-