- May 03, 2021
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38406 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Michaël Zasso authored
This reverts commit b9ffb82f. The bug was fixed in libuv 1.41.0. Refs: https://github.com/libuv/libuv/pull/3072 PR-URL: https://github.com/nodejs/node/pull/38494 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
helloyou2012 authored
Fixes: https://github.com/nodejs/node/issues/33940 PR-URL: https://github.com/nodejs/node/pull/38292 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
- May 02, 2021
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38465 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Antoine du Hamel authored
Reassign `name` and `length` properties to the returned function to not break code that relies on it. PR-URL: https://github.com/nodejs/node/pull/38464 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/10555 Signed-off-by:
James M Snell <jasnell@gmail.com> Refs: https://github.com/nodejs/node/pull/10846 PR-URL: https://github.com/nodejs/node/pull/38447 Reviewed-By:
Alba Mendez <me@alba.sh> Reviewed-By:
Adrian Estrada <edsadr@gmail.com>
-
Luigi Pinca authored
Use a shallow clone instead of cloning the whole repository. PR-URL: https://github.com/nodejs/node/pull/38463 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38466 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Michaël Zasso authored
Original commit message: [interpreter] Apply Reflect.apply transform in BytecodeGenerator Calls with a spread expression in a non-final position get transformed to calls to Reflect.apply. This transformation is currently done in the parser, which does not compose well with other features (e.g. direct eval checking, optional chaining). Do this transform in the BytecodeGenerator instead. Bug: v8:11573, v8:11558, v8:5690 Change-Id: I56c90a2036fe5b43e0897c57766f666bf72bc3a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2765783 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73534} Refs: https://github.com/v8/v8/commit/fd75c97d3f56f0e4b8f2842c08b0f8d1c47bed00 PR-URL: https://github.com/nodejs/node/pull/38455 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
XadillaX authored
Fixes: https://github.com/nodejs/node/issues/38407 PR-URL: https://github.com/nodejs/node/pull/38408 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- May 01, 2021
-
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/38475 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com>
-
Rich Trott authored
fs.truncateSync() emits a deprecation warning when called with a file descriptor. Move to fs.ftruncateSync(). PR-URL: https://github.com/nodejs/node/pull/38448 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Yash Ladha authored
PR-URL: https://github.com/nodejs/node/pull/37986 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Yash Ladha authored
Added toJSON method to the InternalPerformance class as per the convention followed in other performance classes and per the spec: https://www.w3.org/TR/hr-time/#tojson-method Fixes: https://github.com/nodejs/node/issues/37623 PR-URL: https://github.com/nodejs/node/pull/37771 Fixes: https://github.com/nodejs/node/issues/37623 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ruben Bridgewater authored
The documentation and layout example was not up to date with the latest changes. Signed-off-by:
Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/37079 Fixes: https://github.com/nodejs/node/issues/37054 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Ruben Bridgewater authored
A specially crafted object with circular structures behind getters could cause a infinite recursion. This is now fixed by detecting the objects as already visited. Signed-off-by:
Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/37079 Fixes: https://github.com/nodejs/node/issues/37054 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
pezhmanparsaee authored
PR-URL: https://github.com/nodejs/node/pull/37890 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Filip Skokan <panva.ip@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/38226 PR-URL: https://github.com/nodejs/node/pull/38476 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Ruy Adorno <ruyadorno@github.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38444 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/38482 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Nitzan Uziely <linkgoron@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Filip Skokan <panva.ip@gmail.com>
-
- Apr 30, 2021
-
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/38446 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Mary Marchini <oss@mmarchini.me> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/38450 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Shelley Vohr authored
For certain embedder use cases there are more complex memory allocation requirements that the default V8 page allocator does not handle. For example, using MAP_JIT when running under a hardened runtime environment on macOS. This allows embedders like Electron to provide their own allocator that does handle these cases. PR-URL: https://github.com/nodejs/node/pull/38362 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Leko authored
Update url tests to the latest upstream commit. PR-URL: https://github.com/nodejs/node/pull/38435 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
- Apr 29, 2021
-
-
Jesse Chan authored
"PushAllRegistersAndIterateStack" is implemented in assembly and called from "stack.cc" via 'extern "C"'. [1] However, LTO does not work well with symbol usage from assembly. [2] This change workarounds the issue by disabling LTO for the target. With GCC 10 and "./configure --enable-lto", compilation succeeds after this change. [1] v8/v8@c10863153 [2] https://gcc.gnu.org/wiki/LinkTimeOptimizationFAQ#Symbol_usage_from_assembly_language Refs: #35957 Refs: #38335 Signed-off-by:
Jesse Chan <jc@linux.com> PR-URL: https://github.com/nodejs/node/pull/38346 Refs: https://github.com/nodejs/node/issues/35957 Refs: https://github.com/nodejs/node/issues/38335 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> Fixes: https://github.com/nodejs/node/issues/38231 PR-URL: https://github.com/nodejs/node/pull/38436 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Michael Dawson authored
Signed-off-by:
Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/38424 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Qingyu Deng authored
PR-URL: https://github.com/nodejs/node/pull/37892 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
The key thing about the tests in `test/abort` is that tests in that directory do not generate core files (thanks to testcfg.py). Make a note of that in the test README. PR-URL: https://github.com/nodejs/node/pull/38422 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Matteo Collina authored
PR-URL: https://github.com/nodejs/node/pull/38410 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/9.0.257.21...9.0.257.24 PR-URL: https://github.com/nodejs/node/pull/38423 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/38419 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/24640 Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/38421 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Nitzan Uziely <linkgoron@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Rich Trott authored
The fixer for non-ascii-character does not typidally do the right thing. It removes the entire node, not the offending character. I discovered this when it removed the entire contents of a file and I wasn't sure which auto-fix rule was doing it. This commit adds a minimal test for the rule. The tests require that auto-fix results be supplied, so if someone wants to re-add auto-fixing to the rule, we'll have tests that it does the right thing. PR-URL: https://github.com/nodejs/node/pull/38413 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/17669 Signed-off-by:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/38449 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
- Apr 28, 2021
-
-
Rich Trott authored
For issues that ESLint can fix automatically, fix them. PR-URL: https://github.com/nodejs/node/pull/38411 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Rich Trott authored
For issues that ESLint can fix automatically, fix them. PR-URL: https://github.com/nodejs/node/pull/38411 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Antoine du Hamel authored
Fixes: https://github.com/nodejs/node/issues/38391 PR-URL: https://github.com/nodejs/node/pull/38398 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Voltrex authored
Added JSDoc typings for the `fs` lib module. PR-URL: https://github.com/nodejs/node/pull/38306 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
DeeDeeG authored
Ensures the `_depot_tools` dir bootstrapped during this script is added to the PATH, before `ninja` is executed, as `_depot_tools` already has a copy of `ninja` in it. This means one less system requirement to be able to run this script. (It seems like this was already intended to be on the PATH?) Note: This script is used by the `test-v8` Makefile target. PR-URL: https://github.com/nodejs/node/pull/38299 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-