- Nov 11, 2017
-
-
Swathi Kalahastri authored
PR-URL: https://github.com/nodejs/node/pull/16911 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Vidya Subramanyam authored
PR-URL: https://github.com/nodejs/node/pull/16910 Reviewed-By:
-
Refael Ackermann authored
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
-
Joyee Cheung authored
This PR makes the prototype accessors added by StreamBase::AddMethods nonenumerable and checks the signatures in the accessors so they throw instead of raising assertions when called with incompatible receivers. They could be enumerated when inspecting the prototype with util.inspect or the inspector protocol. PR-URL: https://github.com/nodejs/node/pull/16860 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/16893 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Yihong Wang authored
cctest has `so.59` extension when building node shared library in linux. The appending is defined in node.gypi and the cctest target in node.gyp includes node.gypi. Moving the appending from node.gypi to node target in node.gyp fixes the issue. Signed-off-by:
Yihong Wang <yh.wang@ibm.com> PR-URL: https://github.com/nodejs/node/pull/16680 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
cjihrig authored
Fixes: https://github.com/nodejs/node/issues/14957 PR-URL: https://github.com/nodejs/node/pull/16839 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/16835 Reviewed-By:
-
cjihrig authored
There is currently one if branch missing coverage in lib/vm.js. This commit adds a test to cover the case where the third argument to runInNewContext() is a string. PR-URL: https://github.com/nodejs/node/pull/16906 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Neil Vass authored
Print content of domain stack if it doesn't match expected values PR-URL: https://github.com/nodejs/node/pull/16885 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
- Nov 10, 2017
-
-
Franziska Hinkelmann authored
This fixes the flaky message/console test on our CI. Original commit message: [test/message] Allow numbers to have more than one leading digit. The {NUMBER} regexp only allowed one, leading to occasional test failures such as: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/17156 Bug: Change-Id: I25a08b80640d9af19ba70c61c846163685f1cb82 Reviewed-on: https://chromium-review.googlesource.com/753322 Reviewed-by:Franziska Hinkelmann <franzih@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49109} PR-URL: https://github.com/nodejs/node/pull/16890 Ref: https://github.com/nodejs/build/issues/936 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Mamatha J V authored
PR-URL: https://github.com/nodejs/node/pull/16909 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Daniel Bevenius authored
The motivation for this commit is that we need to specify system CA certificates when building node. While we are aware of the environment variable NODE_EXTRA_CA_CERTS this is not a great solution as we build an RPM and we also don't want users to be able to unset them. The suggestion is to add a configure time property like this: --openssl-system-ca-path=OPENSSL_SYSTEM_CA_PATH Use the specified path to system CA (PEM format) in addition to the OpenSSL supplied CA store or compiled- in Mozilla CA copy. Usage example: $ ./configure --openssl-system-ca-path=/etc/pki/tls/certs/ca-bundle.crt This would add the specified CA certificates in addition to the ones already being used. PR-URL: https://github.com/nodejs/node/pull/16790 Reviewed-By: -
Steven R. Loomis authored
- Update to released ICU 60.1, including: - CLDR 32 (many new languages and data improvements) - Unicode 10 (8,518 new characters, including four new scripts, 7,494 new Han characters, and 56 new emoji characters) - UTF-8 malformed bytes now handled according to W3C/WHATWG spec Fixes: https://github.com/nodejs/node/issues/15540 PR-URL: https://github.com/nodejs/node/pull/16876 Reviewed-By:
-
Rod Vagg authored
For variables such as LD_LIBRARY_PATH and DYLD_LIBRARY_PATH that are needed for dynamically linked binaries PR-URL: https://github.com/nodejs/node/pull/16405 Reviewed-By:
-
Franziska Hinkelmann authored
Add an intro section and example for the vm module. PR-URL: https://github.com/nodejs/node/pull/16867 Reviewed-By:
-
- Nov 09, 2017
-
-
Daniel Bevenius authored
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. PR-URL: https://github.com/nodejs/node/pull/16720 Reviewed-By:
-
Ben Noordhuis authored
`&vec[0]` is undefined behavior when `vec.size() == 0`. It is mostly academic because package.json files are not usually empty and because with most STL implementations it decays to something that is legal C++ as long as the result is not dereferenced, but better safe than sorry. Note that the tests don't actually fail because of that, I added them as sanity checks. PR-URL: https://github.com/nodejs/node/pull/16871 Reviewed-By:
-
Daniel Bevenius authored
Original commit message: I believe the paths to the V8 include headers are incorrect. The paths to other sources seem to be relative to the parent directory. When building Node.js I get the following warning on Windows: Warning: Missing input files: deps\v8\src\..\..\include\v8-inspector-protocol.h deps\v8\src\..\..\include\v8-inspector.h This commit updates the two include paths. Bug: Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f Reviewed-on: https://chromium-review.googlesource.com/743981 Reviewed-by:Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49121} This commit also increments the v8_embedder_string version. PR-URL: https://github.com/nodejs/node/pull/16900 Fixes: https://github.com/nodejs/node/issues/16614 Refs: https://github.com/v8/v8/commit/b8331cc0303f7b5c18d84527d5951bafea9a46d9 Reviewed-By:
-
Ben Noordhuis authored
Make the `uv_fs_realpath()` binding (which calls the libc `realpath()` on UNIX and `GetFinalPathNameByHandle()` on Windows) available as the `fs.realpath.native()` and `fs.realpathSync.native()` functions. The binding was already available as `process.binding('fs').realpath` but was not exposed or tested - and partly broken as a result. Fixes: https://github.com/nodejs/node/issues/8715 PR-URL: https://github.com/nodejs/node/pull/15776 Refs: https://github.com/nodejs/node/pull/7899 Reviewed-By:Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Daniel Bevenius authored
This reverts commit 4e769a84. The reason for reverting this is that I forgot to increment the v8_embedder_string in the above commit. PR-URL: https://github.com/nodejs/node/pull/16899 Reviewed-By:
-
Daniel Bevenius authored
Original commit message: I believe the paths to the V8 include headers are incorrect. The paths to other sources seem to be relative to the parent directory. When building Node.js I get the following warning on Windows: Warning: Missing input files: deps\v8\src\..\..\include\v8-inspector-protocol.h deps\v8\src\..\..\include\v8-inspector.h This commit updates the two include paths. Bug: Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f Reviewed-on: https://chromium-review.googlesource.com/743981 Reviewed-by:
-
- Nov 08, 2017
-
-
Katie Stockton Roberts authored
In test-stream-pipe-await-train-manual-resume, include unexpected value in error messages. PR-URL: https://github.com/nodejs/node/pull/16884 Reviewed-By:
-
Adam Wegrzynek authored
Include the value that differed from the expected value in an assertion message in test-require-dot. PR-URL: https://github.com/nodejs/node/pull/16805 Reviewed-By:
-
Joyee Cheung authored
This adds direct anchors for the error codes in errors.html. For example, previously the anchor for ERR_ASSERTION is #errors_err_assertion, now there is also #ERR_ASSERTION. PR-URL: https://github.com/nodejs/node/pull/16779 Reviewed-By:
-
Paul Ashfield authored
PR-URL: https://github.com/nodejs/node/pull/16821 Reviewed-By:
-
Adam Jeffery authored
In test-require-extensions-main, include the values that caused the test to fail in the messages reporting the failure. PR-URL: https://github.com/nodejs/node/pull/16831 Reviewed-By:
-
woj authored
Use fixtures module in test/parallel/test-tls-js-stream.js. PR-URL: https://github.com/nodejs/node/pull/16817 Reviewed-By:
-
Matteo Collina authored
If the console destination is a unix pipe (net.Socket), write() is async. If the destination is broken, we are adding an 'error' event listener to avoid a process crash. This PR makes sure that we are adding that listener only once. Fixes: https://github.com/nodejs/node/issues/16767 PR-URL: https://github.com/nodejs/node/pull/16770 Fixes: https://github.com/nodejs/node/issues/16767 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/16390 Reviewed-By:
-
Joyee Cheung authored
This commit introduces test/common/internet.address, which includes a set of addresses for doing internet tests. These addresses can be overriden using NODE_TEST_* environment variables. PR-URL: https://github.com/nodejs/node/pull/16390 Reviewed-By:
-
Vipin Menon authored
PR-URL: https://github.com/nodejs/node/pull/16879 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/16581 Reviewed-By:
-
Rich Trott authored
test-fs-utimes was doing some tests against __filename. This made the test unreliable when multiple copies were run simultaneously. In general, tests should use files in either the tmp directory or else fixtures, so change to using `common.tmpDir` instead. Each copy of the test (if using `test.py` harness for parallel runs) will use its own directory, making the test robust again. PR-URL: https://github.com/nodejs/node/pull/16774 Reviewed-By:
-
Daniel Bevenius authored
This commit add missing options to the Windows help message and removes options that no longer exist (test-uv). PR-URL: https://github.com/nodejs/node/pull/16707 Reviewed-By:
-
Paul Blanche authored
Include unexpected value in assertion messages. PR-URL: https://github.com/nodejs/node/pull/16820 Reviewed-By:
-
Andres Kalle authored
PR-URL: https://github.com/nodejs/node/pull/16866 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Bryan English <bryan@bryanenglish.com>
-
Gibson Fahnestock authored
Notable Changes: - **openssl**: - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) [#16691](https://github.com/nodejs/node/pull/16691) - ***Revert*** "**https**: - refactor to use http internals" (Myles Borins) [#16660](https://github.com/nodejs/node/pull/16660) PR-URL: https://github.com/nodejs/node/pull/16783
-
cjihrig authored
This commit changes the wording of subprocess.killed to reflect that a child process was successfully signaled, and not necessarily terminated. Fixes: https://github.com/nodejs/node/issues/16747 PR-URL: https://github.com/nodejs/node/pull/16748 Reviewed-By:
-
cjihrig authored
This commit adds checks for overflow to args and env in Spawn(). It seems extremely unlikely that either of these values would overflow from a valid use case. Fixes: https://github.com/nodejs/node/issues/15622 PR-URL: https://github.com/nodejs/node/pull/16761 Reviewed-By:
-
