- Sep 23, 2018
-
-
Michaël Zasso authored
Original commit message: [tracing] do not add traces when disabled https://github.com/nodejs/node/issues/21038 Change-Id: Ic4c9f403b5e54a97d3170b2311dd5aab8c8357c8 Reviewed-on: https://chromium-review.googlesource.com/1217726 Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by:Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55809} Refs: https://github.com/v8/v8/commit/2363cdfefeb643285cbe8593b7c17d80e5d06cd9 PR-URL: https://github.com/nodejs/node/pull/22754 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Michaël Zasso authored
Synchronize source files list with upstream's BUILD.gn PR-URL: https://github.com/nodejs/node/pull/22754 Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 7.0. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/22754 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/22754 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/22754 Reviewed-By:
-
- Sep 22, 2018
-
-
Anna Henningsen authored
Providing `No space left on device` is misleading in this case. Replace it with something that describes it more accurately. Refs: https://stackoverflow.com/questions/22475849/node-js-error-enospc/32600959 PR-URL: https://github.com/nodejs/node/pull/21846 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
MaleDong authored
In short: Some unit tests are using string literals to simply tell you a conclusion what's right/wrong BUT not tell you what actually values are. So it's necessary to print them out in the console. Refs: https://github.com/nodejs/node/pull/22849 PR-URL: https://github.com/nodejs/node/pull/22891 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Michaël Zasso authored
- In release guide - In Travis config Refs: https://github.com/nodejs/node/pull/20109 PR-URL: https://github.com/nodejs/node/pull/22991 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Anatoli Papirovski authored
A push stream should have its writable side closed upon receipt, to avoid emitting the 'aborted' event when the readable side is closed. PR-URL: https://github.com/nodejs/node/pull/22878 Fixes: https://github.com/nodejs/node/issues/22851 Reviewed-By:
-
Michaël Zasso authored
In V8 7.0, the array sorting algorithm was changed to Timsort, which is stable. A compare function returning only `true` or `false` (converted to 0 and 1) cannot work properly. PR-URL: https://github.com/nodejs/node/pull/22992 Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com>
-
Daniel Bevenius authored
This commit adds a CheckOptions function that the options classes can optionally implement to check that options specified are correct (dependencies between options are met or options that are mutually exclusive). In the process of doing this the error pointer passed to Parse was changed to be of type vector so that potentially multiple options check failures can be reported. PR-URL: https://github.com/nodejs/node/pull/22943 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Alexander Mills authored
PR-URL: https://github.com/nodejs/node/pull/22950 Fixes: https://github.com/nodejs/node/issues/22916 Reviewed-By:
-
Rich Trott authored
common.leakedGlobals() was exposed only to test its logic. The logic can instead be tested by running a fixture file that leaks a global and seeing if `common` causes an AssertionError on exit. This way, the entire functionality of leak detection is tested rather than just the leakedGlobals() function. It also reduces API surface area for the common monolith by one function. PR-URL: https://github.com/nodejs/node/pull/22965 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Mohammed Essehemy authored
PR-URL: https://github.com/nodejs/node/pull/23006 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Rich Trott authored
Add links to the class definition for repl.ReplServer in places where it would be helpful. PR-URL: https://github.com/nodejs/node/pull/23005 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/22956 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/22935 Reviewed-By:
-
Rich Trott authored
Provide a test to cover adding setting `onmessage` to a non-function. This provides previously-missing coverage for an else block in the `onmessage` setter. PR-URL: https://github.com/nodejs/node/pull/22942 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/22928 Reviewed-By:
-
- Sep 21, 2018
-
-
Tobias Nießen authored
Calling setAuthTag multiple times can result in hard to detect bugs since to the user, it is unclear which invocation actually affected OpenSSL. PR-URL: https://github.com/nodejs/node/pull/22931 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
Daniel Bevenius authored
This commit adds a --completion-bash option to node which can be sourced to provide bash code completion for node options. Usage: $ node --completion-bash > node_bash_completion $ source node_bash_completion $ node --[tab] PR-URL: https://github.com/nodejs/node/pull/20713 Reviewed-By:
-
Michaël Zasso authored
Replace references to the outdated `update-v8` tool to its replacement in `node-core-utils` PR-URL: https://github.com/nodejs/node/pull/22913 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Ruben Bridgewater authored
Currently the documentation is not specific how fast-tracking should be applied. This specifies exactly how things should be done to prevent confusion. PR-URL: https://github.com/nodejs/node/pull/22929 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
George Adams <george.adams@uk.ibm.com>
-
Hitesh Kanwathirtha authored
PR-URL: https://github.com/nodejs/node/pull/22984 Reviewed-By:
-
Tobias Nießen authored
There is a very small chance (about 0.4%) that OpenSSL will successfully decrypt a key without the correct passphrase and will then fail while parsing its ASN.1 structure. In those rare cases, the error message will be different. PR-URL: https://github.com/nodejs/node/pull/22980 Fixes: https://github.com/nodejs/node/issues/22978 Reviewed-By:
-
Rich Trott authored
common.hasSmallICU is used in only one test and is a one-liner. Move into the test where it is used to chip away at the `common` monolith. PR-URL: https://github.com/nodejs/node/pull/22937 Reviewed-By:
-
Jeremy Apthorp authored
This fixes an error when compiling with clang-cl on Windows: ``` src/node.cc(2437,5): error: jump from this goto statement to its label is a Microsoft extension [-Werror,-Wmicrosoft-goto] goto out; ^ src/node.cc(2441,9): note: jump bypasses variable initialization DWORD pid = args[0].As<Integer>()->Value(); ^ ``` PR-URL: https://github.com/nodejs/node/pull/22961 Reviewed-By: -
Joyee Cheung authored
The `name`, `message` and `code` attributes of the DOMException interface should be enumerable and configurable. Aligning the definition with the Web allows us to use it when running the Web Platform Tests. Refs: https://heycam.github.io/webidl/#idl-DOMException PR-URL: https://github.com/nodejs/node/pull/22550 Refs: https://github.com/web-platform-tests/wpt/commit/125950d10a346482075c55d27f61a1021ca68d68 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
- Sep 20, 2018
-
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/22933 Refs: https://github.com/nodejs/node/pull/22550 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22660 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Tobias Nießen authored
This adds support for RSA, DSA and EC key pair generation with a variety of possible output formats etc. PR-URL: https://github.com/nodejs/node/pull/22660 Fixes: https://github.com/nodejs/node/issues/15116 Reviewed-By:
-
Michaël Zasso authored
Notable changes: * fs * Fixed fsPromises.readdir `withFileTypes`. https://github.com/nodejs/node/pull/22832 * http2 * Added `http2stream.endAfterHeaders` property. https://github.com/nodejs/node/pull/22843 * util * Added `util.types.isBoxedPrimitive(value)`. https://github.com/nodejs/node/pull/22620 * Added new collaborators: * boneskull (https://github.com/boneskull) - Christopher Hiller * The Technical Steering Committee has new members: * apapirovski (https://github.com/apapirovski) - Anatoli Papirovski * gabrielschulhof (https://github.com/gabrielschulhof) - Gabriel Schulhof PR-URL: https://github.com/nodejs/node/pull/22932 -
ZYSzys authored
PR-URL: https://github.com/nodejs/node/pull/22643 Reviewed-By:
-
Masashi Hirano authored
Added tests to check error in dns.lookupService to increase coverage. PR-URL: https://github.com/nodejs/node/pull/22908 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/22898 Refs: https://github.com/v8/v8/compare/6.9.427.22...6.9.427.23 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22949 Refs: https://github.com/nodejs/node/pull/21616 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22949 Refs: https://github.com/nodejs/node/pull/21875 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/22949 Refs: https://github.com/nodejs/node/pull/14731 Reviewed-By:
-
Mark Abel authored
Fixes: https://github.com/nodejs/node/issues/22472 Co-authored-by:
-
Tobias Nießen authored
I assume that permitting digest === null was unintentional when digest === undefined was deprecated since their behavior was equivalent. The sha1 default for digest === null has somehow made it through refactoring of the PBKDF2 module multiple times, even though digest === undefined has been EOL for some time now. This change deprecates setting digest to null so we can fix the behavior in Node.js 12 or so. PR-URL: https://github.com/nodejs/node/pull/22861 Reviewed-By:
-
