- Feb 10, 2016
-
-
Shigeki Ohtsu authored
This replaces all sources of openssl-1.0.1r.tar.gz into deps/openssl/openssl PR-URL: https://github.com/nodejs/node/pull/4967 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> deps: copy all openssl header files to include dir All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. PR-URL: https://github.com/nodejs/node/pull/4967 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> deps: separate sha256/sha512-x86_64.pl for openssl sha256-x86_64.pl does not exist in the origin openssl distribution. It was copied from sha512-x86_64.pl and both sha256/sha512 scripts were modified so as to generates only one asm file specified as its key hash length. PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> deps: fix openssl assembly error on ia32 win32 `x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> openssl: fix keypress requirement in apps on win32 reapply b9106137 PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> deps: add -no_rand_screen to openssl s_client In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. (cherry picked from commit 9f0f7c38e6df975dd39735d0e9ef968076369c74) Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25368
-
James M Snell authored
PR-URL: https://github.com/nodejs/node-private/pull/21
-
James M Snell authored
PR-URL: https://github.com/nodejs/node-private/pull/21
-
James M Snell authored
includes parsing improvements to ensure closer HTTP spec conformance PR-URL: https://github.com/nodejs/node-private/pull/21
-
James M Snell authored
The `--security-revert={cvenum}` command line flag is a special purpose flag to be used only in stable or LTS branches when a breaking change is required to address a security vulnerability. Whenever a vulnerability requires a breaking change, and a CVE has been assigned, the flag can be used to force Node to revert to the insecure behavior that was implemented before the fix was applied. Note that this flag is intended to be used only as a last resort in the case a security update breaks existing code. When used, a security warning will be printed to stderr when Node launches. The `--security-revert={cvenum}` flag takes a single CVE number as an argument. Multiple instances of the `--security-revert={cvenum}` flag can be used on the command line to revert multiple changes. Whenever a new `--security-revert={cvenum}` is enabled, it should be documented in the release notes and in the API docs. Master and the first release of a new major (e.g. v6.0) should not have any reverts available. Every time a new `--security-revert={cvenum}` is added, there should be a semver-minor bump in the stable and LTS branch. PR-URL: https://github.com/nodejs/node-private/pull/21
-
- Dec 04, 2015
-
-
Rod Vagg authored
-
Rod Vagg authored
Security Update Notable items: * http: Fix a bug where an HTTP socket may no longer have a socket but a pipelined request triggers a pause or resume, a potential denial-of-service vector. (Fedor Indutny) * openssl: Upgrade to 1.0.1q, fixes CVE-2015-3194 "Certificate verify crash with missing PSS parameter", a potential denial-of-service vector for Node.js TLS servers; TLS clients are also impacted. Details are available at <http://openssl.org/news/secadv/20151203.txt>. (Ben Noordhuis) #4133 PR-URL: https://github.com/nodejs/node-private/pull/13
-
Ben Noordhuis authored
Contains fixes for: * CVE-2015-3194 Certificate verify crash with missing PSS parameter * CVE-2015-3195 X509_ATTRIBUTE memory leak fixup! character encoding noise fixup! update opensslconf.h PR-URL: https://github.com/nodejs/node/pull/4133 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
- Dec 03, 2015
-
-
Fedor Indutny authored
Always check that socket still has the parser. It may be destroyed interim, and we may end up with an uncaught exception. Fix: https://github.com/nodejs/node/issues/3508 PR-URL: https://github.com/nodejs/node-private/pull/5 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Nov 25, 2015
-
-
Rod Vagg authored
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2806
-
João Reis authored
When MSBuild invokes rc.exe, it passes NODE_TAG unstringified, but passes it correctly to cl.exe. Hence, this workaround was made to apply only to the resource file. Fixes: https://github.com/nodejs/node/issues/2963 PR-URL: https://github.com/nodejs/node/pull/3053 Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/3642 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/3642 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/3642 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com>
-
- Nov 24, 2015
-
-
Michael Dawson authored
As part of the fix for logjam, node was upgraded to a level of openssl which rejects connections to servers that are using keys smaller than 768 bits. It is still possible, however, to create a server that uses a smaller key size and and older client may be able to connect to it. This PR moves us to a secure by default stance on the server side as well, preventing the creation of a server using a dhe key size less than 768. This can be overridden with the command line option which is also added. It is derived from https://github.com/nodejs/node/commit/9b35be58100237365c24ab394d3dc6462f9675e6 which was landed in later io.js/node versions but makes the limit 1024. This PR uses the smaller limit in order to meet the recomendations for logjam while matching was was done on the client side in openssl to minimize the potential impacton users. The command line option will only be documented in the release notes and will not be added to the tls documentation. The goal is that people who are upgrading are aware and can use the option if they run into issues, but otherwise the option is not visible/used. PR-URL: https://github.com/nodejs/node/pull/3890 Fixes: https://github.com/nodejs/LTS/issues/49 Reviewed-By:
Myles Borins <mborins@us.ibm.com> Reviewed-By:
James Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <r@va.gg> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
- Nov 15, 2015
-
-
Forrest L Norvell authored
This is a roll-up release that includes all changes to npm since 2.13.4. PR-URL: https://github.com/nodejs/node/pull/3684 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
Fix the following build error by putting #if guards around the variables: ../src/node.cc: In function 'void node::ParseArgs(int*, const char**, int*, const char***, int*, const char***)': ../src/node.cc:3037:7: error: 'SSL2_ENABLE' was not declared in this scope SSL2_ENABLE = true; ^ ../src/node.cc:3039:7: error: 'SSL3_ENABLE' was not declared in this scope SSL3_ENABLE = true; Fixes: https://github.com/nodejs/node-v0.x-archive/issues/8645 PR-URL: https://github.com/nodejs/node/pull/3825 Reviewed-By:Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Oct 01, 2015
-
-
Jeremy Whitlock authored
caeb6773 Do not abort the process if an error is thrown from within a domain, an error handler is setup for the domain and --abort-on-uncaught-exception was passed on the command line. However, if an error is thrown from within the top-level domain's error handler and --abort-on-uncaught-exception was passed on the command line, make the process abort. Fixes: #8877 Fixes: https://github.com/nodejs/node-v0.x-archive/issues/8877 PR-URL: https://github.com/nodejs/node-v0.x-archive/pull/25835 Reviewed-By:
misterdjules - Julien Gilli <jgilli@nodejs.org>
-
Jeremy Whitlock authored
fbff7054 Add v8::Isolate::SetAbortOnUncaughtException() so the user can be notified when an uncaught exception has bubbled. Fixes: https://github.com/nodejs/node-v0.x-archive/issues/8877 PR-URL: https://github.com/nodejs/node-v0.x-archive/pull/25835 Reviewed-By:
misterdjules - Julien Gilli <jgilli@nodejs.org>
-
- Sep 16, 2015
-
-
João Reis authored
Try the next version of Microsoft Visual Studio when vcvarsall.bat fails to set VCINSTALLDIR. PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Lucien Greathouse authored
This is a port of b0dd3bf4 . Original commit message: Windows 10 wasn't listed in the executable manifest. This caused problems with trying to detect Windows 10 via `os.release()`. PR-URL: https://github.com/nodejs/io.js/pull/2332 Reviewed-By:
Roman Reiss <me@silverwind.io> PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
This is a port of 4208dc4f . Original commit message: PR-URL: https://github.com/nodejs/node/pull/2036 Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in https://github.com/nodejs/node-v0.x-archive/pull/25857 PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
João Reis authored
To compile with VS2015, the == and != methods in zone-allocator.h need to be marked const. This change was introduced upstream in https://chromium.googlesource.com/v8/v8.git/+/f9e4527f32c2c268cb79428c74ea9703e9db3aec PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Andy Polyakov authored
Backports http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=aab3560b65b9254d17770bb6fe3ca7edd7451429 from openssl upstream, to add support for Visual Studio 2015. This is already included in the newer openssl 1.0.2. Original commit message: e_os.h: limit _MSC_VER trickery to older compilers. PR: #3390 Original pull request: http://rt.openssl.org/Ticket/Display.html?user=guest&pass=guest&id=3390 This was ported to v0.10 in https://github.com/joyent/node/pull/25857 PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Shigeki Ohtsu authored
This is a port of eb459c81 , used as a floating patch over gyp. Original commit message: This issue has already submitted to the upstream in https://code.google.com/p/gyp/issues/detail?id=477 Use this commit until the upstream is to be fixed. PR-URL: https://github.com/iojs/io.js/pull/1325 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> This was ported to v0.10 in https://github.com/joyent/node/pull/25857 PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
João Reis authored
This is a port of a525c724 . Original commit message: Gyp update to be able to generate VS2015 projects. PR-URL: https://github.com/joyent/node/pull/25857 Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
João Reis authored
This is a port of e192f615 . Original commit message: Older WiX versions included a header with extern "C" declaration, hence the custom action source must be C++. Reviewed-By:
João Reis <reis@janeasystems.com> PR-URL: https://github.com/joyent/node/pull/25569 PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Julien Gilli authored
This is a port of 16bcd68d . Original commit message: The original change that added support for running custom actions during the install process (e7c84f82 ) assumed that Visual Studio 2013 is used to generate the installer file. However, that is not always the case, and older versions of Visual Studio should allow users to generate Windows installer files. This change makes the custom actions visual studio project use the visual studio version that is found by vcbuild.bat. Reviewed-By:
João Reis <reis@janeasystems.com> PR-URL: https://github.com/joyent/node/pull/25569 PR-URL: https://github.com/nodejs/node/pull/2843 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
- Sep 11, 2015
-
-
Ben Noordhuis authored
It was pointed out by Zhou Ran that the Windows XP implementation of uv_rwlock_rdlock() and friends may unlock the inner write mutex on a different thread than the one that locked it, resulting in undefined behavior. The only place that uses rwlocks is the crypto module. Make that use normal (simple) mutexes instead. OpenSSL's critical sections are generally very short, with exclusive access outnumbering shared access by a factor of three or more, so it's not as if using rwlocks gives a decisive performance advantage. PR-URL: https://github.com/nodejs/node/pull/2723 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Aug 29, 2015
-
-
Tyler Anton authored
Changed child_process.exec documentation to reflect that the parameters stdout and stderr are instances of Buffer only if {encoding: null}. Otherwise, they are instances of String with the encoding. Fixes #9434 removed .DS_Store PR-URL: https://github.com/joyent/node/pull/14088 Reviewed-By:jasnell - James M Snell <jasnell@gmail.com> Reviewed-By:
piscisaureus - Bert Belder <bertbelder@gmail.com>
-
- Aug 28, 2015
-
-
cjihrig authored
spawnSync() modifies the options argument. This commit makes a copy of options before any modifications occur. PR-URL: https://github.com/joyent/node/pull/9159 Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com>
-
Devin Nakamura authored
PR-URL: https://github.com/joyent/node/pull/25642 Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com>
-
Samuel Mills (Henchman) authored
Updated documentation as per the issue below: https://github.com/joyent/node/issues/25466 Event listeners can alter parts of the passed object, in some circumstances the changes are passed to the next listeners due to pass by reference. This is documentation of that behavior. PR-URL: https://github.com/joyent/node/pull/25467 Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com>
-
Evan Lucas authored
Fixes a SIGSEGV by making sure `txt_chunk` is not empty before setting it on `txt_records` Fixes: https://github.com/joyent/node/issues/9285 PR-URL: https://github.com/joyent/node/pull/9300 Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com>
-
- Aug 25, 2015
-
-
João Reis authored
PR-URL: https://github.com/joyent/node/pull/25893 Reviewed-By:
Alexis Campailla <alexis@janeasystems.com>
-
Steven R. Loomis authored
This change is a backport of nodejs/node@4c06515a2f13c9b0890b374bb3ab3c0740c282e2. Original commit message: The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. Also, adds general mechanism for floating patches on top of ICU. Fixes: nodejs/node#2279 PR-URL: nodejs/node#2283 Reviewed-By:
João Reis <reis@janeasystems.com> Fixes: #25792 PR-URL: https://github.com/joyent/node/pull/25804 Reviewed-By:
João Reis <reis@janeasystems.com>
-
- Aug 22, 2015
-
-
Kat Marchán authored
PR-URL: https://github.com/joyent/node/pull/25825 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Max Deepfield authored
libuv link fix PR-URL: https://github.com/joyent/node/pull/25885 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Aug 20, 2015
-
-
George Kotchlamazashvili authored
Specifies origin and includes a list of possible values PR-URL: https://github.com/joyent/node/pull/25777 Reviewed-By:
James M Snell <jasnell@gmail.com>
-