- Sep 12, 2015
-
-
Minwoo Jung authored
"Calls" is used frequently throughout the docs except for this line. Use "Calls" over "Executes" to make it consistent. PR-URL: https://github.com/nodejs/node/pull/2800 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: https://github.com/nodejs/node/issues/2468 PR-URL: https://github.com/nodejs/node/pull/2785 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Anne-Gaelle Colom authored
behaviour -> behavior PR-URL: https://github.com/nodejs/node/pull/2784 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Fedor Indutny authored
Do not let the module struct to be deallocated by `uv_dlclose` before reading data from it. PR-URL: https://github.com/nodejs/node/pull/2792 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com>
-
Anne-Gaelle Colom authored
PR-URL: https://github.com/nodejs/node/pull/2765 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Brian White authored
Fixes: https://github.com/nodejs/node/issues/2779 PR-URL: https://github.com/nodejs/node/pull/2781 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rich Trott authored
FreeBSD does not support the V4MAPPED flag so expect an error. This is a partial fix for https://github.com/nodejs/node/issues/2468. It only fixes it on FreeBSD. Failures on other platforms are due to other reasons and need to be fixed separately. PR-URL: https://github.com/nodejs/node/pull/2724 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Fixes: https://github.com/nodejs/node/issues/2468
-
Rich Trott authored
This fixes a minor typographical error in the Assertion Testing doc. PR-URL: https://github.com/nodejs/node/pull/2728 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Karl Skomski authored
It was previously ignored by features.gypi and therefore enabled by default for release builds. See https://code.google.com/p/chromium/issues/detail?id=318206 PR-URL: https://github.com/nodejs/node/pull/2731 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
* support process.release * support all io.js versions * support node v4+ including new download locations * enable delay-load hook by default by default * download header-only tarballs instead of full source See https://github.com/nodejs/node-gyp/pull/711 for full details PR-URL: https://github.com/nodejs/node/pull/2700 Reviewed-By:
Forrest L Norvell <forrest@npmjs.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2699 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org>
-
Evan Lucas authored
Previously, in _validateStdio we were using stdio.fd || stdio. If stdio.fd was falsy (or 0 in the case of stdin), then the entire stdio object would be passed which could cause a crash. Fixes: https://github.com/nodejs/node/issues/2721 PR-URL: https://github.com/nodejs/node/pull/2727 Reviewed-By:
silverwind - Roman Reiss <me@silverwind.io> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
indutny - Fedor Indutny <fedor.indutny@gmail.com>
-
Ben Noordhuis authored
It was pointed out by Zhou Ran that the Windows XP implementation of uv_rwlock_rdlock() and friends may unlock the inner write mutex on a different thread than the one that locked it, resulting in undefined behavior. The only place that uses rwlocks is the crypto module. Make that use normal (simple) mutexes instead. OpenSSL's critical sections are generally very short, with exclusive access outnumbering shared access by a factor of three or more, so it's not as if using rwlocks gives a decisive performance advantage. PR-URL: https://github.com/nodejs/node/pull/2723 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Rod Vagg authored
Update AUTHORS list using tools/update-authors.sh
-
- Sep 07, 2015
-
-
Ben Noordhuis authored
cpplint uses the top-level .git directory to determine what the root is for #include guards. If it doesn't find a .git directory, it walks up all the way to the system root and subsequently complains that guards must be written as HOME_USER_SRC_NODE_SRC_FILENAME_H_. This commit replaces the .git-based path munging with a fixed root path relative to the location of the cpplint script, making it possible to successfully run `make test` from an extracted tarball. Fixes: https://github.com/nodejs/node/issues/2693 PR-URL: https://github.com/nodejs/node/pull/2710 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Kat Marchán authored
This patch should make the tests pass on the downstreamed npm. PR-URL: https://github.com/nodejs/node/pull/2696 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/2696 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
- Sep 06, 2015
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2674 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Karl Skomski authored
The version used before returned -1 on truncation which does not conform to the standard. PR-URL: https://github.com/nodejs/node/pull/2404 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Karl Skomski authored
Long exception lines resulted in a stack buffer overflow or assertion because it was assumed snprintf not counts discarded chars or the assertion itself was incorrect: `(off) >= sizeof(arrow)` PR-URL: https://github.com/nodejs/node/pull/2404 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Sakthipriyan Vairamani authored
Recursive file watching is supported by libuv since 1.7.0. Refer https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L126. This patch notes that in the docs and enables testing this feature. It also adds proper TAP plugin parsable message for other platforms. PR-URL: https://github.com/nodejs/node/pull/2649 Fixes: https://github.com/nodejs/node/issues/375 Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org> Reviewed-By:
silverwind - Roman Reiss <me@silverwind.io>
-
Michaël Zasso authored
Fixes a regression that appeared with the new Buffer implementation in v3. Without this change, calling the SlowBuffer constructor with something else than a number would abort on the C++ side. This makes sure that the length argument is coerced to number or is 0. Fixes: https://github.com/nodejs/node/issues/2634 PR-URL: https://github.com/nodejs/node/pull/2635 Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2685 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Fedor Indutny authored
The `context_` is not initialized until the `CreateV8Context` will return. Make sure that it will be empty (by moving away initialization from constructor) at start, and ignore getter callbacks until it will have some value. PR-URL: https://github.com/nodejs/io.js/pull/2091 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Jeremiah Senkpiel authored
Now parts of our public and public-ish APIs fall back to old-style listenerCount() if the emitter does not have a listenerCount function. Fixes: https://github.com/nodejs/node/issues/2655 Refs: 8f58fb92 PR-URL: https://github.com/nodejs/node/pull/2661 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Karl Skomski authored
PR-URL: https://github.com/nodejs/node/pull/2376 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
James M Snell authored
Port of joyent/node commits: * https://github.com/nodejs/node-v0.x-archive/commit/e17c5a72b23f920f291d61f2780068c18768cb92 * https://github.com/nodejs/node-v0.x-archive/commit/70dafa7b624abd43432e03304d65cc527fbecc11 Pull over test-child-process-spawn-typeerror.js from v0.12, replacing the existing test in master. The new test includes a broader set of tests on the various arg choices and throws. Reviewed-By:
trevnorris - Trevor Norris <trevnorris@nodejs.org> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani PR-URL: https://github.com/nodejs/node/pull/2667 Fixes: https://github.com/nodejs/node/issues/2515
-
Rich Trott authored
This retains the key elements of test-child-process-fork-getconnections (forks a child process, sends a bunch of sockets, uses getConnections() to enumerate them) but contains some code to work around an apparent intermittent bug that occurs on OS X where a socket seems to close itself unexpectedly. https://github.com/nodejs/node/issues/2610 was opened for the bug that was causing the problem in the first place. PR-URL: https://github.com/nodejs/node/pull/2609 Fixes: https://github.com/nodejs/node/issues/1100 Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com>
-
Jeremiah Senkpiel authored
Fixes: https://github.com/nodejs/node/issues/2113 Ref: 17a379ec PR-URL: https://github.com/nodejs/node/pull/2605 Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
mscdex - Brian White <mscdex@mscdex.net>
-
Johan Bergström authored
Fixes: https://github.com/nodejs/node/issues/1972 PR-URL: https://github.com/nodejs/node/pull/2322 Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Alexis Campailla authored
This test has failed recently during a PR test in Jenkins, for reasons seemingly not related to the change in the PR. PR-URL: https://github.com/nodejs/node/pull/2648 Reviewed-By:
evanlucas - Evan Lucas <evanlucas@me.com>
-
Karl Skomski authored
v8 will silently return an empty handle which doesn't delete our data if string length is above String::kMaxLength Fixes: https://github.com/nodejs/node/issues/1374 PR-URL: https://github.com/nodejs/node/pull/2402 Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By:
indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Amended by @rvagg to change author date from "1970-08-16 16:09:02 +0200" to "2015-08-16 16:09:02 +0200" as per discussion @ https://github.com/nodejs/node/issues/2713
-
- Sep 04, 2015
-
-
João Reis authored
Ref: https://github.com/nodejs/node/issues/2660 PR-URL: https://github.com/nodejs/node/pull/2662 Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org>
-
João Reis authored
This test is already being investigated, but until a solution is found it should be marked flaky. Ref: https://github.com/nodejs/node/issues/2319 Ref: https://github.com/nodejs/node/pull/2356 PR-URL: https://github.com/nodejs/node/pull/2659 Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org>
-
saper authored
Note: chunk in test-heap.cc:1989 discarded as related code missing from current version in node. Original commit message: Use static_cast<> for NULL (clang 3.7) The following errors come up when compiling v8 with clang 3.7 on FreeBSD/amd64: src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Smi *' is not allowed local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:131:20: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Object *' is not allowed Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from 'nullptr_t' to 'Address' (aka 'unsigned char *') is not allowed Address base = reinterpret_cast<Address>(NULL); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +add myself to the AUTHORS file. BUG= Review URL: https://codereview.chromium.org/1277353002 Cr-Commit-Position: refs/heads/master@{#30103} PR-URL: https://github.com/nodejs/node/pull/2636 Reviewed-By:thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Jeremiah Senkpiel authored
This commit addresses most of the review comments in https://github.com/nodejs/node/pull/2540, which are kept in this separate commit so as to better preserve the prior two patches as they landed in 0.12. This commit: - Fixes a bug with unrefActive timers and disposed domains. - Fixes a bug with unrolling an unrefActive timer from another. - Adds a test for both above bugs. - Improves check logic, making it stricter, simpler, or both. - Optimizes nicer with a smaller, separate function for the try/catch. Fixes: https://github.com/nodejs/node-convergence-archive/issues/23 Ref: https://github.com/nodejs/node/issues/268 PR-URL: https://github.com/nodejs/node/pull/2540 Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Julien Gilli authored
Commit 934bfe23 had introduced a regression where node would crash trying to access a null unref timer if a given unref timer's callback would remove other unref timers set to fire in the future. More generally, it makes the unrefTimeout function more solid by not mutating the unrefList while traversing it. Fixes: https://github.com/joyent/node/issues/8897 Conflicts: lib/timers.js Fixes: https://github.com/nodejs/node-convergence-archive/issues/23 Ref: https://github.com/nodejs/node/issues/268 PR-URL: https://github.com/nodejs/node/pull/2540 Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Julien Gilli authored
Before this change, _unrefActive would keep the unrefList sorted when adding a new timer. Because _unrefActive is called extremely frequently, this linear scan (O(n) at worse) would make _unrefActive show high in the list of contributors when profiling CPU usage. This commit changes _unrefActive so that it doesn't try to keep the unrefList sorted. The insertion thus happens in constant time. However, when a timer expires, unrefTimeout has to go through the whole unrefList because it's not ordered anymore. It is usually not large enough to have a significant impact on performance because: - Most of the time, the timers will be removed before unrefTimeout is called because their users (sockets mainly) cancel them when an I/O operation takes place. - If they're not, it means that some I/O took a long time to happen, and the initiator of subsequents I/O operations that would add more timers has to wait for them to complete. With this change, _unrefActive does not show as a significant contributor in CPU profiling reports anymore. Fixes: https://github.com/joyent/node/issues/8160 Signed-off-by:
Timothy J Fontaine <tjfontaine@gmail.com> Conflicts: lib/timers.js Fixes: https://github.com/nodejs/node-convergence-archive/issues/23 Ref: https://github.com/nodejs/node/issues/268 PR-URL: https://github.com/nodejs/node/pull/2540 Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Evan Lucas authored
ParseArgs sets the first element of v8_args to argv[0], so v8_argc will always be at least 1. This change only calls V8::SetFlagsFromCommandLine if v8_argc > 1, leading to an additional startup improvement of ~5%. PR-URL: https://github.com/nodejs/node/pull/2646 Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com>
-
- Sep 02, 2015
-
-
Rod Vagg authored
-