Commit e73eafd7 authored by Karl Skomski's avatar Karl Skomski Committed by Rod Vagg
Browse files

src: fix memory leak in ExternString

v8 will silently return an empty handle
which doesn't delete our data if string length is
above String::kMaxLength

Fixes: https://github.com/nodejs/node/issues/1374
PR-URL: https://github.com/nodejs/node/pull/2402


Reviewed-By: default avatartrevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: default avatarindutny - Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: default avatarbnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

Amended by @rvagg to change author date from
  "1970-08-16 16:09:02 +0200"
to
  "2015-08-16 16:09:02 +0200"
as per discussion @ https://github.com/nodejs/node/issues/2713
parent 1865cad7
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment